mirror of
https://github.com/Vateron-Media/XC_VM.git
synced 2026-10-15 12:02:46 +02:00
feat(streaming): add pure buildLive() assembler with shadow-diff (no flip)
Phase 1 of extracting the live ffmpeg command assembly out of startStream.
buildLive(array $data): string is a byte-faithful copy of the inline assembly,
fed from a prepared $data array instead of loop-local state, with the delay
playlist I/O and segment-start/sleep left in startStream (arriving via
$data['segmentStart']/['delayActive']). The one non-verbatim change is the
ac3/eac3 dts_legacy bin switch, now a local reassignment instead of mutating the
$rFFMPEG_CPU/$rFFPROBE globals (the $rFFPROBE write was already dead). Homed on
StreamProcess for now so the private output/logo/aac helpers resolve via self::;
a FFmpegCommand facade is a follow-up.
startStream computes buildLive() alongside the inline assembly and error_log()s
any divergence, but still executes the inline $rFFMPEG -- shadow mode, no flip.
Once the diff log stays empty on real traffic the call site can switch over.
Characterisation tests cover simple/custom_ffmpeg/loopback/delay/rtmp branches
and assert no unresolved {TOKEN} survives.
Verified: phpstan level 5 green, phpunit 397/397, make gates green.
This commit is contained in:
Divarion_D
@@ -0,0 +1,156 @@
|
||||
<?php
|
||||
|
||||
use PHPUnit\Framework\TestCase;
|
||||
use XcVm\Domain\Stream\StreamProcess;
|
||||
|
||||
/**
|
||||
* Characterisation tests for StreamProcess::buildLive() — the pure live ffmpeg
|
||||
* command assembler extracted from startStream. These lock the string structure
|
||||
* per branch (simple / custom_ffmpeg / loopback / delay / rtmp) and, crucially,
|
||||
* assert no unresolved {TOKEN} survives — the most likely extraction defect.
|
||||
*
|
||||
* The authoritative equivalence oracle is the shadow-diff wired into startStream
|
||||
* (both strings computed on real traffic, divergence logged); these fixtures
|
||||
* guard against future drift.
|
||||
*/
|
||||
final class StreamProcessBuildLiveTest extends TestCase {
|
||||
|
||||
public static function setUpBeforeClass(): void {
|
||||
foreach ([
|
||||
'SERVER_ID' => 1,
|
||||
'STREAMS_PATH' => '/tmp/xcvm-test-streams/',
|
||||
'DELAY_PATH' => '/tmp/xcvm-test-delay/',
|
||||
'FFMPEG_BIN_40' => '/bin/ffmpeg40',
|
||||
'FFPROBE_BIN_40' => '/bin/ffprobe40',
|
||||
] as $k => $v) {
|
||||
if (!defined($k)) {
|
||||
define($k, $v);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
/** Base $data for a plain live restream; override per test. */
|
||||
private function data(array $overrides = []): array {
|
||||
$base = [
|
||||
'stream' => [
|
||||
'stream_info' => [
|
||||
'custom_ffmpeg' => '',
|
||||
'stream_all' => 0,
|
||||
'custom_map' => '',
|
||||
'type_key' => 'live_streams',
|
||||
'gen_timestamps' => 0,
|
||||
'read_native' => 0,
|
||||
'enable_transcode' => 0,
|
||||
'transcode_profile_id' => 0,
|
||||
'transcode_attributes' => '[]',
|
||||
'profile_options' => '[]',
|
||||
'delay_minutes' => 0,
|
||||
'rtmp_output' => 0,
|
||||
],
|
||||
'server_info' => ['parent_id' => 0, 'server_id' => 1],
|
||||
'stream_arguments' => [],
|
||||
],
|
||||
'settings' => [
|
||||
'ffmpeg_warnings' => 0,
|
||||
'read_native_hls' => 0,
|
||||
'dts_legacy_ffmpeg' => 0,
|
||||
'ignore_keyframes' => 0,
|
||||
'live_streaming_pass' => 'secret',
|
||||
],
|
||||
'servers' => [1 => ['rtmp_port' => 1935]],
|
||||
'streamID' => 42,
|
||||
'streamSource' => 'http://src.example/live.ts',
|
||||
'fetchOptions' => '',
|
||||
'ffprobe' => ['container' => 'mpegts', 'codecs' => ['video' => ['codec_name' => 'h264'], 'audio' => ['codec_name' => 'aac']]],
|
||||
'protocol' => 'http',
|
||||
'source' => 'http://src.example/live.ts',
|
||||
'segmentSettings' => ['seg_time' => 6, 'seg_list_size' => 8, 'seg_delete_threshold' => 4],
|
||||
'externalPush' => [],
|
||||
'probesize' => 1000000,
|
||||
'analyseDuration' => 500000,
|
||||
'llod' => false,
|
||||
'loopback' => false,
|
||||
'segmentStart' => 0,
|
||||
'delayActive' => false,
|
||||
'ffmpegCpu' => '/bin/ffmpeg',
|
||||
'ffmpegGpu' => '/bin/ffmpeg-gpu',
|
||||
];
|
||||
// shallow-merge stream_info / settings so tests can tweak single keys
|
||||
if (isset($overrides['stream_info'])) {
|
||||
$base['stream']['stream_info'] = array_merge($base['stream']['stream_info'], $overrides['stream_info']);
|
||||
unset($overrides['stream_info']);
|
||||
}
|
||||
if (isset($overrides['server_info'])) {
|
||||
$base['stream']['server_info'] = array_merge($base['stream']['server_info'], $overrides['server_info']);
|
||||
unset($overrides['server_info']);
|
||||
}
|
||||
return array_merge($base, $overrides);
|
||||
}
|
||||
|
||||
private function build(array $overrides = []): string {
|
||||
$m = new ReflectionMethod(StreamProcess::class, 'buildLive');
|
||||
$m->setAccessible(true);
|
||||
return $m->invoke(null, $this->data($overrides));
|
||||
}
|
||||
|
||||
// ── the key invariant: every placeholder is resolved ───────
|
||||
|
||||
public function testNoUnresolvedPlaceholderRemains(): void {
|
||||
foreach ([
|
||||
[], // simple
|
||||
['loopback' => true], // loopback
|
||||
['delayActive' => true, 'segmentStart' => 3, 'stream_info' => ['delay_minutes' => 5]],
|
||||
['stream_info' => ['rtmp_output' => 1]], // rtmp
|
||||
['stream_info' => ['custom_ffmpeg' => '-i in -c copy out']],
|
||||
] as $ov) {
|
||||
$out = $this->build($ov);
|
||||
$this->assertStringNotContainsString('{', $out, 'unresolved placeholder in: ' . $out);
|
||||
}
|
||||
}
|
||||
|
||||
// ── simple live ────────────────────────────────────────────
|
||||
|
||||
public function testSimpleLiveStructure(): void {
|
||||
$out = $this->build();
|
||||
$this->assertStringStartsWith('/bin/ffmpeg ', $out, 'cpu bin (no gpu)');
|
||||
$this->assertStringContainsString('-progress "' . STREAMS_PATH . '42_.progress"', $out);
|
||||
$this->assertStringContainsString("-i 'http://src.example/live.ts'", $out);
|
||||
$this->assertStringContainsString(STREAMS_PATH . '42_%d.ts', $out, 'hls segments');
|
||||
$this->assertStringContainsString('>/dev/null 2>>' . STREAMS_PATH . '42.errors', $out);
|
||||
$this->assertStringContainsString('echo $! > ' . STREAMS_PATH . '42_.pid', $out);
|
||||
}
|
||||
|
||||
// ── custom_ffmpeg branch ───────────────────────────────────
|
||||
|
||||
public function testCustomFfmpegBypassesTemplate(): void {
|
||||
$out = $this->build(['stream_info' => ['custom_ffmpeg' => '-i INPUT -c:v libx264 OUTPUT']]);
|
||||
$this->assertStringContainsString('-i INPUT -c:v libx264 OUTPUT', $out);
|
||||
// custom path emits neither gen_pts input flags nor a fetch-options slot
|
||||
$this->assertStringNotContainsString('-thread_queue_size', $out);
|
||||
}
|
||||
|
||||
// ── loopback ───────────────────────────────────────────────
|
||||
|
||||
public function testLoopbackHasNoReconnectAndNoLlod(): void {
|
||||
$out = $this->build(['loopback' => true, 'llod' => true]);
|
||||
$this->assertStringNotContainsString('-reconnect', $out, 'loopback source is not http-reconnect');
|
||||
$this->assertStringNotContainsString('-tune zerolatency', $out, 'LLOD options suppressed on loopback');
|
||||
}
|
||||
|
||||
// ── delay resume ───────────────────────────────────────────
|
||||
|
||||
public function testDelayUsesDelayPathAndStartNumber(): void {
|
||||
$out = $this->build(['delayActive' => true, 'segmentStart' => 3, 'stream_info' => ['delay_minutes' => 5]]);
|
||||
$this->assertStringContainsString('-start_number 3', $out);
|
||||
$this->assertStringContainsString(DELAY_PATH . '42_%d.ts', $out);
|
||||
$this->assertStringContainsString('-f hls', $out);
|
||||
}
|
||||
|
||||
// ── rtmp output ────────────────────────────────────────────
|
||||
|
||||
public function testRtmpOutputAppendsFlvTarget(): void {
|
||||
$out = $this->build(['stream_info' => ['rtmp_output' => 1]]);
|
||||
$this->assertStringContainsString('rtmp://127.0.0.1:1935/live/42?password=secret', $out);
|
||||
$this->assertStringContainsString('-f flv', $out);
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user