The suite ran on in-memory SQLite, an engine production never uses: it hid
column lengths, MySQL-only syntax and type coercion (the identity bug fixed in
the previous commit passed CI that way). SQLite is gone:
- TestDb connects only to MariaDB/MySQL (XCVM_TEST_DB_DSN/_USER/_PASS; root over
the local socket, else 127.0.0.1:3306). Each instance gets a throwaway
schema, dropped with it, in the installer's sql_mode, with an explicit
connect timeout (a boot under test can zero default_socket_timeout).
- InstallSchema and the tests take the production DDL as is: the SQLite
reducers, the keys they re-added, the faked information_schema and the
sqliteCreateFunction() stand-ins are removed; test DDL is MySQL DDL.
- ReplicaBootTest, DbConnectRefusalTest and LazyDatabaseHandlerTest reach the
test server instead of SQLite files; RecordingFinalizer no longer swallows
an information_schema failure "for tests on SQLite".
- `make test-db` starts a throwaway mariadb:11.4 (tmpfs) for a machine without
a server; the CI PHPUnit job gets the same as a service.
The suite also runs on a panel host with the bundled PHP and its own php.ini:
tests reach the code through MAIN_HOME, not `<repo>/src`; repository checks
and process-isolated tests (ionCube Loader + OPcache CLI segfault on a script
read from stdin) are in the skip-on-panel group; xcvm_test_child_php() starts
a child that fakes \XC_VM without the real extension; Redis-down tests use
RedisManager::useConnector() instead of an eval'd \XC_VM.
Stale opt-in tests fixed on the way: the real-agent provisioning test answers
the agent-started check, the extension integration test sends the typed starts
and reads the binary signature raw, a fake producer starts as PHP_BINARY, and
the certbot test waits for the line its background command writes.
queue, scanner, signals and watchdog each had their whole pass inside a while
whose last statement was an unconditional break, so every pass fell out of the
loop and restartDaemon() re-executed console.php: a fresh bootstrap, settings
read and database connect per pass, per node — four times a second in the
signals daemon. The plan's 24 h RSS and queries/s acceptance cannot be measured
on a process that never lives a second.
Every break that means something (a code change, nginx stopped, MAIN's
database gone) stays, and restartDaemon() still re-execs then, which is how a
deploy is picked up. Two things fell out of it: the signals daemon paced itself
inside the branch that read `signals`, so a node whose query failed spun as
fast as MariaDB would answer; and the watchdog's CPU sample was a delta over
its own 2 s sleep every pass, because a fresh process never had a previous
read of /proc/stat.
The numeric cluster settings render as number inputs with the bounds the save
clamps to, instead of text fields that no digits-only script covered.
Divarion_D