Commit Graph
2 Commits
Author SHA1 Message Date
Divarion_D 9e118da975 test: run the unit suite on MariaDB only, and on the panel's own stack
The suite ran on in-memory SQLite, an engine production never uses: it hid
column lengths, MySQL-only syntax and type coercion (the identity bug fixed in
the previous commit passed CI that way). SQLite is gone:

- TestDb connects only to MariaDB/MySQL (XCVM_TEST_DB_DSN/_USER/_PASS; root over
  the local socket, else 127.0.0.1:3306). Each instance gets a throwaway
  schema, dropped with it, in the installer's sql_mode, with an explicit
  connect timeout (a boot under test can zero default_socket_timeout).
- InstallSchema and the tests take the production DDL as is: the SQLite
  reducers, the keys they re-added, the faked information_schema and the
  sqliteCreateFunction() stand-ins are removed; test DDL is MySQL DDL.
- ReplicaBootTest, DbConnectRefusalTest and LazyDatabaseHandlerTest reach the
  test server instead of SQLite files; RecordingFinalizer no longer swallows
  an information_schema failure "for tests on SQLite".
- `make test-db` starts a throwaway mariadb:11.4 (tmpfs) for a machine without
  a server; the CI PHPUnit job gets the same as a service.

The suite also runs on a panel host with the bundled PHP and its own php.ini:
tests reach the code through MAIN_HOME, not `<repo>/src`; repository checks
and process-isolated tests (ionCube Loader + OPcache CLI segfault on a script
read from stdin) are in the skip-on-panel group; xcvm_test_child_php() starts
a child that fakes \XC_VM without the real extension; Redis-down tests use
RedisManager::useConnector() instead of an eval'd \XC_VM.

Stale opt-in tests fixed on the way: the real-agent provisioning test answers
the agent-started check, the extension integration test sends the typed starts
and reads the binary signature raw, a fake producer starts as PHP_BINARY, and
the certbot test waits for the line its background command writes.
2026-10-04 16:12:23 +03:00
obscuremind 9c3db348f2 fix(nginx): no thread pool; workers no longer abort when they exit
The shipped nginx is statically linked. At a worker's graceful exit,
exit() runs the global destructors, which deregister the binary's unwind
tables (__deregister_frame_info_bases), while the thread pool's threads
are still unwinding out of pthread_exit(): ngx_thread_pool_destroy()
waits for each thread's flag, set just before pthread_exit(), not for
the thread. A thread that finds no frame info aborts (uw_init_context_1
-> abort). A core from the test MAIN shows both stacks; nginx's
error.log called it 'worker process ... exited on signal 6', about one
reload in eleven (9 in 100 under traffic).

The pool did no work anyway: max_queue=0 refused every task, so aio
threads never ran. Both nginx.conf files drop thread_pool and aio
threads; segments still go out by sendfile.
2026-10-03 06:30:55 +00:00