mirror of
https://github.com/Vateron-Media/XC_VM.git
synced 2026-10-04 04:02:30 +02:00
Divarion_D
5b35907388
Clean up the admin stream loopback scripts (api/live/proxy_api/thumb/
timeshift/vod) for readability and to give their core logic unit-test
coverage, without changing behavior — except the two bugs called out below.
Readability:
- Invert the pervasive empty `if (c) {} else { body }` into `if (!c) { body }`.
- Flatten deep if/else nests into guard-clause / elseif chains (live, vod).
- Drop dead blank lines.
Testability (pure logic extracted, then covered):
- New value object XcVm\Domain\Stream\AdminStreamToken (decode + isValid)
replaces the uitoken decrypt+expiry+IP block duplicated across live/thumb/
timeshift/vod; it reuses the existing-but-unadopted NetworkUtils::ipMatches().
Token start/duration are kept raw (a timeshift date string must not be cast).
- Four pure helpers folded into the existing StreamUtils (not new one-method
classes): sanitizeSegmentName, containerMimeType, timeshiftStartTimestamp,
segmentRetryBudget — replacing inline path sanitization, a 44-line MIME
switch, the timeshift date parser, and the retry-budget math.
- Tests: AdminStreamTokenTest, NetworkUtilsTest (ipMatches had no coverage),
and StreamUtilsTest extended for the four helpers. OPENSSL_EXTRA is defined
in tests/bootstrap.php so token round-trips work.
Bug fixes (behavior changes):
- live: the retry budget used `$rTotalFails < intval(...) ?: 20`, which by
operator precedence parsed as `(... < ...) ?: 20` — always truthy — so the
`seg_time * 2` floor was ignored and the budget was always the configured
wait. Now max(seg_time*2, wait ?: 20) via StreamUtils::segmentRetryBudget().
- proxy_api: the per-second byte-rate divided by `time() - last`, which is 0
for two samples in the same second (division by zero). Clamp to >= 1s.
86 lines
2.2 KiB
PHP
86 lines
2.2 KiB
PHP
<?php
|
|
|
|
$projectRoot = dirname(__DIR__);
|
|
$srcRoot = $projectRoot . '/src';
|
|
$flatRoot = $projectRoot;
|
|
|
|
if (file_exists($srcRoot . '/vendor/autoload.php')) {
|
|
$appRoot = $srcRoot;
|
|
} elseif (file_exists($flatRoot . '/vendor/autoload.php')) {
|
|
$appRoot = $flatRoot;
|
|
} else {
|
|
throw new RuntimeException('Unable to locate vendor/autoload.php in expected project paths.');
|
|
}
|
|
|
|
$tmpRoot = __DIR__ . '/.tmp';
|
|
$binRoot = $tmpRoot . '/bin';
|
|
|
|
if (!is_dir($tmpRoot)) {
|
|
mkdir($tmpRoot, 0775, true);
|
|
}
|
|
if (!is_dir($binRoot)) {
|
|
mkdir($binRoot, 0775, true);
|
|
}
|
|
|
|
$fakeBinary = $binRoot . '/fake_bin.sh';
|
|
if (!file_exists($fakeBinary)) {
|
|
file_put_contents($fakeBinary, "#!/bin/sh\nexit 0\n");
|
|
chmod($fakeBinary, 0755);
|
|
}
|
|
|
|
if (!defined('MAIN_HOME')) {
|
|
define('MAIN_HOME', $appRoot . '/');
|
|
}
|
|
|
|
if (!defined('PHP_BIN')) {
|
|
define('PHP_BIN', PHP_BINARY);
|
|
}
|
|
// Extra OpenSSL entropy/seed used by Encryption (real value in AppConfig.php).
|
|
// Any stable value works for tests that round-trip encrypt/decrypt.
|
|
if (!defined('OPENSSL_EXTRA')) {
|
|
define('OPENSSL_EXTRA', 'test-openssl-extra');
|
|
}
|
|
// FfmpegPaths::binary() builds paths under BIN_PATH . 'ffmpeg_bin/<ver>/'. No such
|
|
// fixtures exist here, so lookups miss and the code falls back to FFMPEG_BIN_40.
|
|
if (!defined('BIN_PATH')) {
|
|
define('BIN_PATH', $binRoot . '/');
|
|
}
|
|
if (!defined('VOD_PATH')) {
|
|
define('VOD_PATH', $tmpRoot . '/vod/');
|
|
}
|
|
if (!is_dir(VOD_PATH)) {
|
|
mkdir(VOD_PATH, 0775, true);
|
|
}
|
|
|
|
foreach (array('40', '71', '80') as $version) {
|
|
$ffmpegConst = 'FFMPEG_BIN_' . $version;
|
|
$ffprobeConst = 'FFPROBE_BIN_' . $version;
|
|
if (!defined($ffmpegConst)) {
|
|
define($ffmpegConst, $fakeBinary);
|
|
}
|
|
if (!defined($ffprobeConst)) {
|
|
define($ffprobeConst, $fakeBinary);
|
|
}
|
|
}
|
|
|
|
if (!isset($_FILES)) {
|
|
$_FILES = array();
|
|
}
|
|
|
|
if (!function_exists('igbinary_serialize')) {
|
|
function igbinary_serialize($value) {
|
|
return serialize($value);
|
|
}
|
|
}
|
|
if (!function_exists('igbinary_unserialize')) {
|
|
function igbinary_unserialize($value) {
|
|
return unserialize($value);
|
|
}
|
|
}
|
|
|
|
require_once MAIN_HOME . 'vendor/autoload.php';
|
|
require_once __DIR__ . '/Unit/M3uParser/ExtCustomTag.php';
|
|
|
|
// Test support: in-memory SQLite harness for DB-touching repositories/services.
|
|
require_once __DIR__ . '/Support/TestDb.php';
|