mirror of
https://github.com/Vateron-Media/XC_VM.git
synced 2026-09-26 04:02:51 +02:00
Divarion_D
5e92e521da
The scheduled auto-restart check was three chained `if (!cond) goto label195;` statements testing the configured days + HH:MM against the current weekday/hour/minute. Replace them with a pure isAutoRestartDue() predicate (injectable for tests) and a single `goto label195`. Two more gotos gone (47 -> 45), and the schedule logic is unit tested. Verified: phpstan level 5 green, phpunit 6 monitor tests green, make gates green.
65 lines
2.9 KiB
PHP
65 lines
2.9 KiB
PHP
<?php
|
|
|
|
use PHPUnit\Framework\TestCase;
|
|
use XcVm\Cli\Commands\MonitorCommand;
|
|
|
|
/**
|
|
* Unit tests for pure helpers extracted from MonitorCommand's obfuscated
|
|
* goto-based execute(). Each helper replaces a self-contained goto cluster; the
|
|
* tests lock its behaviour so the control-flow untangling cannot silently drift.
|
|
*/
|
|
final class MonitorCommandTest extends TestCase {
|
|
|
|
/** Invoke a private static MonitorCommand method via reflection. */
|
|
private function call(string $method, ...$args) {
|
|
$m = new ReflectionMethod(MonitorCommand::class, $method);
|
|
$m->setAccessible(true);
|
|
return $m->invoke(null, ...$args);
|
|
}
|
|
|
|
// ── parseFrameRate (label768/780/1047/1052/1057) ───────────
|
|
|
|
public function testPlainInteger(): void {
|
|
$this->assertSame(30.0, $this->call('parseFrameRate', '30'));
|
|
$this->assertSame(25.0, $this->call('parseFrameRate', 25));
|
|
}
|
|
|
|
public function testRationalFrameRate(): void {
|
|
$this->assertSame(25.0, $this->call('parseFrameRate', '25/1'));
|
|
$this->assertEqualsWithDelta(29.97, $this->call('parseFrameRate', '30000/1001'), 0.001);
|
|
}
|
|
|
|
public function testZeroAndMalformedAreZero(): void {
|
|
$this->assertSame(0.0, $this->call('parseFrameRate', ''));
|
|
$this->assertSame(0.0, $this->call('parseFrameRate', '0'));
|
|
$this->assertSame(0.0, $this->call('parseFrameRate', '0/0'), 'division-by-zero guarded');
|
|
$this->assertSame(0.0, $this->call('parseFrameRate', '30/0'), 'zero denominator guarded');
|
|
}
|
|
|
|
// ── isAutoRestartDue (label195 schedule chain) ─────────────
|
|
|
|
public function testAutoRestartDueWhenDayHourMinuteMatch(): void {
|
|
$now = mktime(14, 30, 0, 8, 8, 2026);
|
|
// derive the expected components from the same $now -> timezone-agnostic.
|
|
$day = date('l', $now);
|
|
$at = date('H', $now) . ':' . date('i', $now);
|
|
$this->assertTrue($this->call('isAutoRestartDue', ['days' => [$day], 'at' => $at], $now));
|
|
}
|
|
|
|
public function testAutoRestartNotDueOnMismatch(): void {
|
|
$now = mktime(14, 30, 0, 8, 8, 2026);
|
|
$day = date('l', $now);
|
|
$at = date('H', $now) . ':' . date('i', $now);
|
|
$this->assertFalse($this->call('isAutoRestartDue', ['days' => ['Nonesuch'], 'at' => $at], $now), 'wrong day');
|
|
$this->assertFalse($this->call('isAutoRestartDue', ['days' => [$day], 'at' => ((intval(date('H', $now)) + 1) % 24) . ':' . date('i', $now)], $now), 'wrong hour');
|
|
$this->assertFalse($this->call('isAutoRestartDue', ['days' => [$day], 'at' => date('H', $now) . ':' . (((intval(date('i', $now)) + 1) % 60)) ], $now), 'wrong minute');
|
|
}
|
|
|
|
public function testAutoRestartNotDueWhenUnconfigured(): void {
|
|
$now = mktime(14, 30, 0, 8, 8, 2026);
|
|
$this->assertFalse($this->call('isAutoRestartDue', [], $now));
|
|
$this->assertFalse($this->call('isAutoRestartDue', ['days' => [], 'at' => '14:30'], $now), 'empty days');
|
|
$this->assertFalse($this->call('isAutoRestartDue', ['days' => ['Saturday']], $now), 'no time');
|
|
}
|
|
}
|