mirror of
https://github.com/Vateron-Media/XC_VM.git
synced 2026-10-03 04:02:10 +02:00
Divarion_D
c27950093f
Move the 17 global lookup arrays from resources/data/admin_constants.php into PSR-4 classes and enums, eliminating the last big pile of `global` reference data. New XcVm\Core\Reference\* (const + static accessors, FfmpegBinaries-style): GeoReference, LocaleReference, DeviceReference, UiReference, PermissionReference, StatusBadge. New XcVm\Core\Enum\* (backed enums with label()/options(), ModuleState-style): Theme (int), ResellerAction and ClientFilter (string). All consumers migrated off `global $rX` / `$GLOBALS['rX']` and the BaseAdminController extract bridge: TableController, DashboardController, SearchAjaxController, SettingsController, ResellerAPI and ResellerLoginController call the classes directly, and 21 view templates import them via `use`. The extract whitelist entries, the bootstrap require and admin_constants.php itself are removed. Fixes a latent bug: TableController read $rClientFilters without a `global`, so the client-request log showed raw status codes instead of labels; ClientFilter::labelFor() now resolves them. The reference classes and the three new enums are excluded from the load-balancer build (all consumers are already MAIN-only). Adds unit tests for the enums, StatusBadge and the reference data.
29 lines
1.1 KiB
PHP
29 lines
1.1 KiB
PHP
<?php
|
|
|
|
use XcVm\Core\Enum\ResellerAction;
|
|
use PHPUnit\Framework\TestCase;
|
|
|
|
final class ResellerActionEnumTest extends TestCase {
|
|
|
|
public function testBackingValuesMatchLegacyKeys(): void {
|
|
$this->assertSame('new', ResellerAction::New->value);
|
|
$this->assertSame('send_event', ResellerAction::SendEvent->value);
|
|
$this->assertSame('adjust_credits', ResellerAction::AdjustCredits->value);
|
|
}
|
|
|
|
public function testLabel(): void {
|
|
$this->assertSame('Create', ResellerAction::New->label());
|
|
$this->assertSame('MAG Event', ResellerAction::SendEvent->label());
|
|
$this->assertSame('Adjust Credits', ResellerAction::AdjustCredits->label());
|
|
}
|
|
|
|
public function testOptionsMatchLegacyMap(): void {
|
|
$options = ResellerAction::options();
|
|
$this->assertCount(9, $options);
|
|
$this->assertSame('Create', $options['new']);
|
|
$this->assertSame('MAG Event', $options['send_event']);
|
|
// Ordering preserved: first key is 'new'.
|
|
$this->assertSame('new', array_key_first($options));
|
|
}
|
|
}
|