mirror of
https://github.com/Vateron-Media/XC_VM.git
synced 2026-10-03 12:02:29 +02:00
Divarion_D
489555f039
Mechanical output of `make rector-fix` over the class-based trees, reviewed change by change. Most of it is empty()/=== [] normalisation, a chained === turned into in_array(..., true) in FanoutConfig, and multi-line condition reformatting. Three changes were checked more closely because they looked behaviour-affecting: - Translator::isRtl() loses its (string) cast on $lang. Safe: $currentLang is a non-nullable `private static string`, so the ??= above always leaves a string. - TableController loses htmlValue() and jsArgument(). They are escaping helpers, so the removal was verified rather than trusted: neither has a single reference anywhere under src/, views included. Genuinely dead. - StartupCommand and StreamsCronJob have three private helpers turned from static into instance methods (LocallyCalledStaticMethodToNonStatic). That last one broke 7 tests, which reached the helpers through Reflection and invoked them statically. Fixed in the tests rather than by reverting the rule — reverting would only lose the argument again on the next `make rector-fix`. The Reflection helpers now bind an instance only when the method needs one, so they survive the flip in either direction. Also re-ran the two KNOWN BUG greps from build/rector.php (the rules that drop parens around an assignment-in-condition and invert the guard): both clean. Verified: 857 tests, make gates, make cs, CRAP gate.
62 lines
2.0 KiB
PHP
62 lines
2.0 KiB
PHP
<?php
|
|
|
|
use PHPUnit\Framework\TestCase;
|
|
use XcVm\Cli\CronJobs\StreamsCronJob;
|
|
|
|
/**
|
|
* Coverage for StreamsCronJob connection parsing — the fix for the TypeError
|
|
* raised when getConnections() returns the Redis [keys, data] pair instead of
|
|
* the MySQL user-id map. Both shapes (and a single connection row) must yield
|
|
* the stream's UUIDs, filtered to that stream.
|
|
*/
|
|
final class StreamsCronConnectionsTest extends TestCase {
|
|
|
|
/**
|
|
* Call a private helper. Whether it is static is an implementation detail
|
|
* (Rector's LocallyCalledStaticMethodToNonStatic flips it), so bind an
|
|
* instance only when the method actually needs one.
|
|
*/
|
|
private function call(string $rMethod, ...$rArgs) {
|
|
$rM = new ReflectionMethod(StreamsCronJob::class, $rMethod);
|
|
$rM->setAccessible(true);
|
|
return $rM->invoke($rM->isStatic() ? null : new StreamsCronJob(), ...$rArgs);
|
|
}
|
|
|
|
private function uuids($rConnections, $rStreamID): array {
|
|
return $this->call('connectionUuidsForStream', $rConnections, $rStreamID);
|
|
}
|
|
|
|
private function collect($rNode): array {
|
|
return $this->call('collectUuidRows', $rNode);
|
|
}
|
|
|
|
public function testRedisPairShapeFiltersByStream(): void {
|
|
$rConnections = [
|
|
['redis-key-1', 'redis-key-2'],
|
|
[
|
|
['uuid' => 'a', 'stream_id' => 5],
|
|
['uuid' => 'b', 'stream_id' => 9],
|
|
],
|
|
];
|
|
$this->assertSame(['a'], $this->uuids($rConnections, 5));
|
|
}
|
|
|
|
public function testMysqlGroupedShapeKeepsRowsWithoutStreamId(): void {
|
|
$rConnections = [
|
|
10 => [['uuid' => 'c', 'stream_id' => 5]],
|
|
11 => [['uuid' => 'd']], // no stream_id → kept
|
|
];
|
|
$this->assertSame(['c', 'd'], $this->uuids($rConnections, 5));
|
|
}
|
|
|
|
public function testSingleConnectionRow(): void {
|
|
$this->assertSame(['e'], $this->uuids(['uuid' => 'e', 'stream_id' => 5], 5));
|
|
}
|
|
|
|
public function testNonArrayAndEmptyYieldNothing(): void {
|
|
$this->assertSame([], $this->uuids([], 5));
|
|
$this->assertSame([], $this->uuids(null, 5));
|
|
$this->assertSame([], $this->collect('a-redis-key-string'));
|
|
}
|
|
}
|