From 1be48c276be8c36501cefda5dd636d5815dc7f3e Mon Sep 17 00:00:00 2001
From: Reece <reece@stirlingpdf.com>
Date: Fri, 26 Sep 2025 18:12:13 +0100
Subject: [PATCH] fix text infinite loop

---
 .../components/tools/sign/SignSettings.tsx    |  2 +-
 frontend/src/tools/Sign.tsx                   | 25 +++++++++++--------
 2 files changed, 16 insertions(+), 11 deletions(-)

diff --git a/frontend/src/components/tools/sign/SignSettings.tsx b/frontend/src/components/tools/sign/SignSettings.tsx
index 728dacfcfe..74dc83d390 100644
--- a/frontend/src/components/tools/sign/SignSettings.tsx
+++ b/frontend/src/components/tools/sign/SignSettings.tsx
@@ -242,7 +242,7 @@ const SignSettings = ({
       {onSave && (
         <Button
           onClick={onSave}
-          color="green"
+          color="blue"
           variant="filled"
           fullWidth
         >
diff --git a/frontend/src/tools/Sign.tsx b/frontend/src/tools/Sign.tsx
index 0304928a0c..807dd732d9 100644
--- a/frontend/src/tools/Sign.tsx
+++ b/frontend/src/tools/Sign.tsx
@@ -23,9 +23,20 @@ const Sign = (props: BaseToolProps) => {
   const activeModeRef = useRef<'draw' | 'placement' | null>(null);
 
   // Single handler that activates placement mode
-  const handleSignaturePlacement = () => {
+  const handleSignaturePlacement = useCallback(() => {
     activateSignaturePlacementMode();
-  };
+  }, [activateSignaturePlacementMode]);
+
+  // Memoized callbacks for SignSettings to prevent infinite loops
+  const handleActivateDrawMode = useCallback(() => {
+    activeModeRef.current = 'draw';
+    activateDrawMode();
+  }, [activateDrawMode]);
+
+  const handleActivateSignaturePlacement = useCallback(() => {
+    activeModeRef.current = 'placement';
+    handleSignaturePlacement();
+  }, [handleSignaturePlacement]);
 
   const base = useBaseTool(
     'sign',
@@ -122,14 +133,8 @@ const Sign = (props: BaseToolProps) => {
           parameters={base.params.parameters}
           onParameterChange={base.params.updateParameter}
           disabled={base.endpointLoading}
-          onActivateDrawMode={() => {
-            activeModeRef.current = 'draw';
-            activateDrawMode();
-          }}
-          onActivateSignaturePlacement={() => {
-            activeModeRef.current = 'placement';
-            handleSignaturePlacement();
-          }}
+          onActivateDrawMode={handleActivateDrawMode}
+          onActivateSignaturePlacement={handleActivateSignaturePlacement}
           onDeactivateSignature={deactivateDrawMode}
           onUpdateDrawSettings={updateDrawSettings}
           onUndo={undo}