From a184b394d66a798c2f1bcfc183e098944ebfd1b1 Mon Sep 17 00:00:00 2001 From: Anthony Stirling Date: Thu, 21 May 2026 15:20:11 +0100 Subject: [PATCH] Strip rationale-history comments from JDK 25 references --- .github/workflows/backend-build.yml | 3 --- AGENTS.md | 2 +- DeveloperGuide.md | 2 +- build.gradle | 5 +---- 4 files changed, 3 insertions(+), 9 deletions(-) diff --git a/.github/workflows/backend-build.yml b/.github/workflows/backend-build.yml index aba02c3609..5cd4ca1a01 100644 --- a/.github/workflows/backend-build.yml +++ b/.github/workflows/backend-build.yml @@ -18,9 +18,6 @@ jobs: strategy: fail-fast: false matrix: - # JDK 25 is the floor: JPDFium's published artifacts require - # org.gradle.jvm.version=25 (FFM is final at 22+, JPDFium picked 25 - # as its source target). Earlier JDKs can't even resolve the dep. jdk-version: [25] spring-security: [true, false] steps: diff --git a/AGENTS.md b/AGENTS.md index 7a9ab7b304..08dfc53634 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -431,7 +431,7 @@ The frontend is organized with a clear separation of concerns: ## Important Notes -- **Java Version**: Requires JDK 25 (raised from 21 to support JPDFium's FFM bindings, which target `org.gradle.jvm.version=25`). +- **Java Version**: Requires JDK 25. - **Lombok**: Used extensively - ensure IDE plugin is installed - **File Persistence**: - **Backend**: Designed to be stateless - files are processed in memory/temp locations only diff --git a/DeveloperGuide.md b/DeveloperGuide.md index a9e7c1c106..8bb4a6c167 100644 --- a/DeveloperGuide.md +++ b/DeveloperGuide.md @@ -45,7 +45,7 @@ This guide focuses on developing for Stirling 2.0, including both the React fron - [Task](https://taskfile.dev/installation/) — unified command runner (recommended) - Docker - Git -- Java JDK 25 (required — JPDFium FFM bindings target JVM 25) +- Java JDK 25 - Node.js 18+ and npm (required for frontend development) - Gradle 7.0 or later (Included within the repo) - [uv](https://docs.astral.sh/uv/) — Python package manager (required for engine development) diff --git a/build.gradle b/build.gradle index f1c399b45c..6253035012 100644 --- a/build.gradle +++ b/build.gradle @@ -32,10 +32,7 @@ ext { logback = "1.5.32" // junit-platform-launcher version managed by Spring Boot BOM // modernJavaVersion drives javac --release and the restart-helper - // compile target. Bumped from 21 to 25 because JPDFium publishes with - // org.gradle.jvm.version=25 (FFM is finalized at 22+, JPDFium picks 25 - // as its source target). Anything < 25 fails Gradle's variant attribute - // match at compile time. + // compile target. modernJavaVersion = 25 }