# Description of Changes A new universal file context rather than the splintered ones for the main views, tools and manager we had before (manager still has its own but its better integreated with the core context) File context has been split it into a handful of different files managing various file related issues separately to reduce the monolith - FileReducer.ts - State management fileActions.ts - File operations fileSelectors.ts - Data access patterns lifecycle.ts - Resource cleanup and memory management fileHooks.ts - React hooks interface contexts.ts - Context providers Improved thumbnail generation Improved indexxedb handling Stopped handling files as blobs were not necessary to improve performance A new library handling drag and drop https://github.com/atlassian/pragmatic-drag-and-drop (Out of scope yes but I broke the old one with the new filecontext and it needed doing so it was a might as well) A new library handling virtualisation on page editor @tanstack/react-virtual, as above. Quickly ripped out the last remnants of the old URL params stuff and replaced with the beginnings of what will later become the new URL navigation system (for now it just restores the tool name in url behavior) Fixed selected file not regestered when opening a tool Fixed png thumbnails Closes #(issue_number) --- ## Checklist ### General - [ ] I have read the [Contribution Guidelines](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/CONTRIBUTING.md) - [ ] I have read the [Stirling-PDF Developer Guide](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/devGuide/DeveloperGuide.md) (if applicable) - [ ] I have read the [How to add new languages to Stirling-PDF](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/devGuide/HowToAddNewLanguage.md) (if applicable) - [ ] I have performed a self-review of my own code - [ ] My changes generate no new warnings ### Documentation - [ ] I have updated relevant docs on [Stirling-PDF's doc repo](https://github.com/Stirling-Tools/Stirling-Tools.github.io/blob/main/docs/) (if functionality has heavily changed) - [ ] I have read the section [Add New Translation Tags](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/devGuide/HowToAddNewLanguage.md#add-new-translation-tags) (for new translation tags only) ### UI Changes (if applicable) - [ ] Screenshots or videos demonstrating the UI changes are attached (e.g., as comments or direct attachments in the PR) ### Testing (if applicable) - [ ] I have tested my changes locally. Refer to the [Testing Guide](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/devGuide/DeveloperGuide.md#6-testing) for more details. --------- Co-authored-by: Reece Browne <you@example.com>
190 lines
5.8 KiB
TypeScript
190 lines
5.8 KiB
TypeScript
/**
|
|
* File lifecycle management - Resource cleanup and memory management
|
|
*/
|
|
|
|
import { FileId, FileContextAction, FileRecord, ProcessedFilePage } from '../../types/fileContext';
|
|
|
|
const DEBUG = process.env.NODE_ENV === 'development';
|
|
|
|
/**
|
|
* Resource tracking and cleanup utilities
|
|
*/
|
|
export class FileLifecycleManager {
|
|
private cleanupTimers = new Map<string, number>();
|
|
private blobUrls = new Set<string>();
|
|
private fileGenerations = new Map<string, number>(); // Generation tokens to prevent stale cleanup
|
|
|
|
constructor(
|
|
private filesRef: React.MutableRefObject<Map<FileId, File>>,
|
|
private dispatch: React.Dispatch<FileContextAction>
|
|
) {}
|
|
|
|
/**
|
|
* Track blob URLs for cleanup
|
|
*/
|
|
trackBlobUrl = (url: string): void => {
|
|
// Only track actual blob URLs to avoid trying to revoke other schemes
|
|
if (url.startsWith('blob:')) {
|
|
this.blobUrls.add(url);
|
|
}
|
|
};
|
|
|
|
|
|
/**
|
|
* Clean up resources for a specific file (with stateRef access for complete cleanup)
|
|
*/
|
|
cleanupFile = (fileId: string, stateRef?: React.MutableRefObject<any>): void => {
|
|
// Use comprehensive cleanup (same as removeFiles)
|
|
this.cleanupAllResourcesForFile(fileId, stateRef);
|
|
|
|
// Remove file from state
|
|
this.dispatch({ type: 'REMOVE_FILES', payload: { fileIds: [fileId] } });
|
|
};
|
|
|
|
/**
|
|
* Clean up all files and resources
|
|
*/
|
|
cleanupAllFiles = (): void => {
|
|
// Revoke all blob URLs
|
|
this.blobUrls.forEach(url => {
|
|
try {
|
|
URL.revokeObjectURL(url);
|
|
} catch (error) {
|
|
// Ignore revocation errors
|
|
}
|
|
});
|
|
this.blobUrls.clear();
|
|
|
|
// Clear all cleanup timers and generations
|
|
this.cleanupTimers.forEach(timer => clearTimeout(timer));
|
|
this.cleanupTimers.clear();
|
|
this.fileGenerations.clear();
|
|
|
|
// Clear files ref
|
|
this.filesRef.current.clear();
|
|
};
|
|
|
|
/**
|
|
* Schedule delayed cleanup for a file with generation token to prevent stale cleanup
|
|
*/
|
|
scheduleCleanup = (fileId: string, delay: number = 30000, stateRef?: React.MutableRefObject<any>): void => {
|
|
// Cancel existing timer
|
|
const existingTimer = this.cleanupTimers.get(fileId);
|
|
if (existingTimer) {
|
|
clearTimeout(existingTimer);
|
|
this.cleanupTimers.delete(fileId);
|
|
}
|
|
|
|
// If delay is negative, just cancel (don't reschedule)
|
|
if (delay < 0) {
|
|
return;
|
|
}
|
|
|
|
// Increment generation for this file to invalidate any pending cleanup
|
|
const currentGen = (this.fileGenerations.get(fileId) || 0) + 1;
|
|
this.fileGenerations.set(fileId, currentGen);
|
|
|
|
// Schedule new cleanup with generation token
|
|
const timer = window.setTimeout(() => {
|
|
// Check if this cleanup is still valid (file hasn't been re-added)
|
|
if (this.fileGenerations.get(fileId) === currentGen) {
|
|
this.cleanupFile(fileId, stateRef);
|
|
} else {
|
|
if (DEBUG) console.log(`🗂️ Skipped stale cleanup for file ${fileId} (generation mismatch)`);
|
|
}
|
|
}, delay);
|
|
|
|
this.cleanupTimers.set(fileId, timer);
|
|
};
|
|
|
|
/**
|
|
* Remove a file immediately with complete resource cleanup
|
|
*/
|
|
removeFiles = (fileIds: FileId[], stateRef?: React.MutableRefObject<any>): void => {
|
|
fileIds.forEach(fileId => {
|
|
// Clean up all resources for this file
|
|
this.cleanupAllResourcesForFile(fileId, stateRef);
|
|
});
|
|
|
|
// Dispatch removal action once for all files (reducer only updates state)
|
|
this.dispatch({ type: 'REMOVE_FILES', payload: { fileIds } });
|
|
};
|
|
|
|
/**
|
|
* Complete resource cleanup for a single file
|
|
*/
|
|
private cleanupAllResourcesForFile = (fileId: FileId, stateRef?: React.MutableRefObject<any>): void => {
|
|
// Remove from files ref
|
|
this.filesRef.current.delete(fileId);
|
|
|
|
// Cancel cleanup timer and generation
|
|
const timer = this.cleanupTimers.get(fileId);
|
|
if (timer) {
|
|
clearTimeout(timer);
|
|
this.cleanupTimers.delete(fileId);
|
|
}
|
|
this.fileGenerations.delete(fileId);
|
|
|
|
// Clean up blob URLs from file record if we have access to state
|
|
if (stateRef) {
|
|
const record = stateRef.current.files.byId[fileId];
|
|
if (record) {
|
|
// Clean up thumbnail blob URLs
|
|
if (record.thumbnailUrl && record.thumbnailUrl.startsWith('blob:')) {
|
|
try {
|
|
URL.revokeObjectURL(record.thumbnailUrl);
|
|
} catch (error) {
|
|
// Ignore revocation errors
|
|
}
|
|
}
|
|
|
|
if (record.blobUrl && record.blobUrl.startsWith('blob:')) {
|
|
try {
|
|
URL.revokeObjectURL(record.blobUrl);
|
|
} catch (error) {
|
|
// Ignore revocation errors
|
|
}
|
|
}
|
|
|
|
// Clean up processed file thumbnails
|
|
if (record.processedFile?.pages) {
|
|
record.processedFile.pages.forEach((page: ProcessedFilePage, index: number) => {
|
|
if (page.thumbnail && page.thumbnail.startsWith('blob:')) {
|
|
try {
|
|
URL.revokeObjectURL(page.thumbnail);
|
|
} catch (error) {
|
|
// Ignore revocation errors
|
|
}
|
|
}
|
|
});
|
|
}
|
|
}
|
|
}
|
|
};
|
|
|
|
/**
|
|
* Update file record with race condition guards
|
|
*/
|
|
updateFileRecord = (fileId: FileId, updates: Partial<FileRecord>, stateRef?: React.MutableRefObject<any>): void => {
|
|
// Guard against updating removed files (race condition protection)
|
|
if (!this.filesRef.current.has(fileId)) {
|
|
if (DEBUG) console.warn(`🗂️ Attempted to update removed file (filesRef): ${fileId}`);
|
|
return;
|
|
}
|
|
|
|
// Additional state guard for rare race conditions
|
|
if (stateRef && !stateRef.current.files.byId[fileId]) {
|
|
if (DEBUG) console.warn(`🗂️ Attempted to update removed file (state): ${fileId}`);
|
|
return;
|
|
}
|
|
|
|
this.dispatch({ type: 'UPDATE_FILE_RECORD', payload: { id: fileId, updates } });
|
|
};
|
|
|
|
/**
|
|
* Cleanup on unmount
|
|
*/
|
|
destroy = (): void => {
|
|
this.cleanupAllFiles();
|
|
};
|
|
} |