From 6683bb160f3575d8eff53ec813d9bd40ba23577a Mon Sep 17 00:00:00 2001 From: Roxedus Date: Sun, 17 Oct 2021 17:31:38 +0200 Subject: [PATCH] Remove umask_set --- README.md | 1 + readme-vars.yml | 9 +++++---- root/etc/services.d/radarr/run | 5 ----- 3 files changed, 6 insertions(+), 9 deletions(-) diff --git a/README.md b/README.md index cc482fb..a08e34c 100644 --- a/README.md +++ b/README.md @@ -244,6 +244,7 @@ Once registered you can define the dockerfile to use with `-f Dockerfile.aarch64 ## Versions +* **17.10.21:** - Remove `UMASK_SET`. * **11.07.21:** - Make the paths clearer to the user * **17.01.21:** - Deprecate `UMASK_SET` in favor of UMASK in baseimage, see above for more information. * **09.27.20:** - Merge Preview into Nightly. diff --git a/readme-vars.yml b/readme-vars.yml index b116699..08ee002 100644 --- a/readme-vars.yml +++ b/readme-vars.yml @@ -45,17 +45,18 @@ opt_param_usage_include_env: false app_setup_block_enabled: true app_setup_block: | Access the webui at `:7878`, for more information check out [Radarr](https://github.com/Radarr/Radarr). - + ### Media folders - + We have set `/movies` and `/downloads` as ***optional paths***, this is because it is the easiest way to get started. While easy to use, it has some drawbacks. Mainly losing the ability to hardlink (TL;DR a way for a file to exist in multiple places on the same file system while only consuming one file worth of space), or atomic move (TL;DR instant file moves, rather than copy+delete) files while processing content. - + Use the optional paths if you dont understand, or dont want hardlinks/atomic moves. - + The folks over at servarr.com wrote a good [write-up](https://wiki.servarr.com/docker-guide#consistent-and-well-planned-paths) on how to get started with this. # changelog changelogs: + - { date: "17.10.21:", desc: "Remove `UMASK_SET`." } - { date: "11.07.21:", desc: "Make the paths clearer to the user" } - { date: "17.01.21:", desc: "Deprecate `UMASK_SET` in favor of UMASK in baseimage, see above for more information." } - { date: "09.27.20:", desc: "Merge Preview into Nightly." } diff --git a/root/etc/services.d/radarr/run b/root/etc/services.d/radarr/run index 9a42a4e..e2d5e7b 100644 --- a/root/etc/services.d/radarr/run +++ b/root/etc/services.d/radarr/run @@ -1,10 +1,5 @@ #!/usr/bin/with-contenv bash -if [ -n "${UMASK_SET}" ] && [ -z "${UMASK}" ]; then - echo -e "You are using a legacy method of defining umask\nplease update your environment variable from UMASK_SET to UMASK\nto keep the functionality after July 2021" - umask ${UMASK_SET} -fi - exec \ s6-setuidgid abc /app/radarr/bin/Radarr \ -nobrowser -data=/config