From 59703e268c75fd1e91fefc1967ccce98cb9da5de Mon Sep 17 00:00:00 2001 From: Kenneth Hsu Date: Tue, 26 Sep 2017 19:45:07 -0700 Subject: [PATCH] Avoid unnecessary enumeration. Instead of enumerating the entire sequence and checking that the number of elements is positive, we can simply check to see if the sequence contains at least one element. --- Duplicati/Library/Modules/Builtin/HyperVOptions.cs | 2 +- Duplicati/Library/Modules/Builtin/MSSQLOptions.cs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Duplicati/Library/Modules/Builtin/HyperVOptions.cs b/Duplicati/Library/Modules/Builtin/HyperVOptions.cs index 8c93cdc23..81938bf9b 100644 --- a/Duplicati/Library/Modules/Builtin/HyperVOptions.cs +++ b/Duplicati/Library/Modules/Builtin/HyperVOptions.cs @@ -214,7 +214,7 @@ namespace Duplicati.Library.Modules.Builtin if (paths == null || !Utility.Utility.IsClientWindows) return false; - return paths.Where(x => !string.IsNullOrWhiteSpace(x)).Where(x => x.Equals(m_HyperVPathAllRegExp, StringComparison.OrdinalIgnoreCase) || Regex.IsMatch(x, m_HyperVPathGuidRegExp, RegexOptions.IgnoreCase | RegexOptions.CultureInvariant)).Count() > 0; + return paths.Where(x => !string.IsNullOrWhiteSpace(x)).Where(x => x.Equals(m_HyperVPathAllRegExp, StringComparison.OrdinalIgnoreCase) || Regex.IsMatch(x, m_HyperVPathGuidRegExp, RegexOptions.IgnoreCase | RegexOptions.CultureInvariant)).Any(); } #endregion diff --git a/Duplicati/Library/Modules/Builtin/MSSQLOptions.cs b/Duplicati/Library/Modules/Builtin/MSSQLOptions.cs index 2dce505ef..3c8bcbf3c 100644 --- a/Duplicati/Library/Modules/Builtin/MSSQLOptions.cs +++ b/Duplicati/Library/Modules/Builtin/MSSQLOptions.cs @@ -211,7 +211,7 @@ namespace Duplicati.Library.Modules.Builtin if (paths == null || !Utility.Utility.IsClientWindows) return false; - return paths.Where(x => !string.IsNullOrWhiteSpace(x)).Where(x => x.Equals(m_MSSQLPathAllRegExp, StringComparison.OrdinalIgnoreCase) || Regex.IsMatch(x, m_MSSQLPathDBRegExp, RegexOptions.IgnoreCase | RegexOptions.CultureInvariant)).Count() > 0; + return paths.Where(x => !string.IsNullOrWhiteSpace(x)).Where(x => x.Equals(m_MSSQLPathAllRegExp, StringComparison.OrdinalIgnoreCase) || Regex.IsMatch(x, m_MSSQLPathDBRegExp, RegexOptions.IgnoreCase | RegexOptions.CultureInvariant)).Any(); } #endregion