From 043a11967a49f4745be1f8d5ed72426baf20cf12 Mon Sep 17 00:00:00 2001 From: Kenneth Hsu Date: Sun, 15 Mar 2020 12:09:13 -0700 Subject: [PATCH 1/2] Remove unused members from Duplicati.Library.Main.ResultClasses. --- Duplicati/Library/Main/ResultClasses.cs | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/Duplicati/Library/Main/ResultClasses.cs b/Duplicati/Library/Main/ResultClasses.cs index 12e1bff78..8032ff671 100644 --- a/Duplicati/Library/Main/ResultClasses.cs +++ b/Duplicati/Library/Main/ResultClasses.cs @@ -72,21 +72,6 @@ namespace Duplicati.Library.Main protected long m_foldersCreated = 0; protected long m_retryAttemptCount = 0; - public void AddNumberOfRemoteCalls(long count) - { - System.Threading.Interlocked.Add(ref m_remoteCalls, count); - } - - public void AddBytesUploaded(long count) - { - System.Threading.Interlocked.Add(ref m_bytesUploaded, count); - } - - public void AddBytesDownloaded(long count) - { - System.Threading.Interlocked.Add(ref m_bytesDownloaded, count); - } - public long RemoteCalls { get { return m_remoteCalls; } } public long BytesUploaded { get { return m_bytesUploaded; } } public long BytesDownloaded { get { return m_bytesDownloaded; } } From bf5ae9afacd07ddd12d1faaf8066185702a7d4a5 Mon Sep 17 00:00:00 2001 From: Kenneth Hsu Date: Sun, 15 Mar 2020 12:11:10 -0700 Subject: [PATCH 2/2] Disable false ReSharper warnings for unused properties. These properties are referenced in the logs. --- Duplicati/Library/Main/ResultClasses.cs | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/Duplicati/Library/Main/ResultClasses.cs b/Duplicati/Library/Main/ResultClasses.cs index 8032ff671..2f3ef85bd 100644 --- a/Duplicati/Library/Main/ResultClasses.cs +++ b/Duplicati/Library/Main/ResultClasses.cs @@ -199,7 +199,10 @@ namespace Duplicati.Library.Main } } + // ReSharper disable once UnusedMember.Global + // This is referenced in the logs. public string Version { get { return string.Format("{0} ({1})", AutoUpdater.UpdaterManager.SelfVersion.Version, AutoUpdater.UpdaterManager.SelfVersion.Displayname); } } + public DateTime EndTime { get; set; } public DateTime BeginTime { get; set; } public TimeSpan Duration { get { return EndTime.Ticks == 0 ? new TimeSpan(0) : EndTime - BeginTime; } } @@ -323,12 +326,23 @@ namespace Duplicati.Library.Main [JsonIgnore] public IEnumerable Messages { get { return m_messages; } } + + // ReSharper disable once UnusedMember.Global + // This is referenced in the logs. public int MessagesActualLength { get { return Messages == null ? 0 : Messages.Count(); } } + [JsonIgnore] public IEnumerable Warnings { get { return m_warnings; } } + + // ReSharper disable once UnusedMember.Global + // This is referenced in the logs. public int WarningsActualLength { get { return Warnings == null ? 0 : Warnings.Count(); } } + [JsonIgnore] public IEnumerable Errors { get { return m_errors; } } + + // ReSharper disable once UnusedMember.Global + // This is referenced in the logs. public int ErrorsActualLength { get { return Errors == null ? 0 : Errors.Count(); } } [JsonProperty(PropertyName = "Messages")] @@ -715,6 +729,9 @@ namespace Duplicati.Library.Main { [JsonIgnore] public IEnumerable> DeletedSets { get; private set; } + + // ReSharper disable once UnusedMember.Global + // This is referenced in the logs. public int DeletedSetsActualLength { get { return DeletedSets == null ? 0 : DeletedSets.Count(); } } [JsonProperty(PropertyName = "DeletedSets")] @@ -908,6 +925,9 @@ namespace Duplicati.Library.Main private readonly List>>> m_verifications = new List>>>(); [JsonIgnore] public IEnumerable>>> Verifications { get { return m_verifications; } } + + // ReSharper disable once UnusedMember.Global + // This is referenced in the logs. public int VerificationsActualLength { get { return Verifications == null ? 0 : Verifications.Count(); } } [JsonProperty(PropertyName = "Verifications")]