From d02cf960c8eda7455ece873289e6e812f4fe6fe5 Mon Sep 17 00:00:00 2001 From: Kenneth Hsu Date: Sat, 8 Dec 2018 20:33:55 -0800 Subject: [PATCH] Convert write-only IBrowserWindow.Title property to method. Write-only properties are confusing and the behavior is better implemented as a method, which more clearly conveys the write-only semantics. --- Duplicati/GUI/Duplicati.GUI.TrayIcon/IBrowserWindow.cs | 2 +- Duplicati/GUI/Duplicati.GUI.TrayIcon/TrayIconBase.cs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Duplicati/GUI/Duplicati.GUI.TrayIcon/IBrowserWindow.cs b/Duplicati/GUI/Duplicati.GUI.TrayIcon/IBrowserWindow.cs index ad88911f5..661f671cd 100644 --- a/Duplicati/GUI/Duplicati.GUI.TrayIcon/IBrowserWindow.cs +++ b/Duplicati/GUI/Duplicati.GUI.TrayIcon/IBrowserWindow.cs @@ -7,7 +7,7 @@ namespace Duplicati.GUI.TrayIcon { public interface IBrowserWindow { - string Title { set; } + void SetTitle(string title); WindowIcons Icon { set; } } } diff --git a/Duplicati/GUI/Duplicati.GUI.TrayIcon/TrayIconBase.cs b/Duplicati/GUI/Duplicati.GUI.TrayIcon/TrayIconBase.cs index f580f5d3e..c52505810 100644 --- a/Duplicati/GUI/Duplicati.GUI.TrayIcon/TrayIconBase.cs +++ b/Duplicati/GUI/Duplicati.GUI.TrayIcon/TrayIconBase.cs @@ -156,7 +156,7 @@ namespace Duplicati.GUI.TrayIcon if (window != null) { window.Icon = WindowIcons.Regular; - window.Title = "Duplicati status"; + window.SetTitle("Duplicati status"); } }