From b785cfb50eb6781d7b5c08332fe62857b9513256 Mon Sep 17 00:00:00 2001 From: Kenneth Hsu Date: Mon, 3 May 2021 12:01:08 -0700 Subject: [PATCH 1/3] Restore NuGet packages in separate step. This more closely mirrors the steps in the unit_tests job. --- .github/workflows/tests.yml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 572f4a258..9b54e483b 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -66,10 +66,11 @@ jobs: - name: Install NuGet uses: nuget/setup-nuget@v1.0.5 + - name: Restore NuGet Packages + run: nuget restore Duplicati.sln + - name: Build Duplicati - run: | - nuget restore Duplicati.sln - msbuild -p:Configuration=Release -p:DefineConstants=ENABLE_GTK Duplicati.sln + run: msbuild -p:Configuration=Release -p:DefineConstants=ENABLE_GTK Duplicati.sln - name: Set up Python uses: actions/setup-python@v2 From e435622ca66813081ef553ba0e1f0a7f27d9fae8 Mon Sep 17 00:00:00 2001 From: Kenneth Hsu Date: Mon, 3 May 2021 12:03:28 -0700 Subject: [PATCH 2/3] Install gtk-sharp2 package for tests run on ubuntu-latest. This seems to have been previously included when the job ran on Ubuntu 18.04.5. Now that it has been upgraded to Ubuntu 20.04.2, the gtk-sharp libraries appear to be missing. --- .github/workflows/tests.yml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 9b54e483b..64a466dda 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -32,6 +32,10 @@ jobs: - name: Restore NuGet Packages run: nuget restore Duplicati.sln + - name: Install additional dependencies + if: matrix.os == 'ubuntu-latest' + run: sudo apt-get install gtk-sharp2 + - name: Build Duplicati (Linux and macOS) if: matrix.os != 'windows-latest' run: msbuild -p:Configuration=Release -p:DefineConstants=ENABLE_GTK Duplicati.sln @@ -69,6 +73,9 @@ jobs: - name: Restore NuGet Packages run: nuget restore Duplicati.sln + - name: Install additional dependencies + run: sudo apt-get install gtk-sharp2 + - name: Build Duplicati run: msbuild -p:Configuration=Release -p:DefineConstants=ENABLE_GTK Duplicati.sln From a69599c37c5de6ec2c33c6766baf4a9ac0f24837 Mon Sep 17 00:00:00 2001 From: Kenneth Hsu Date: Mon, 3 May 2021 14:03:20 -0700 Subject: [PATCH 3/3] Use title case for job steps for consistency. --- .github/workflows/tests.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 64a466dda..37fca57bc 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -32,7 +32,7 @@ jobs: - name: Restore NuGet Packages run: nuget restore Duplicati.sln - - name: Install additional dependencies + - name: Install Additional Dependencies if: matrix.os == 'ubuntu-latest' run: sudo apt-get install gtk-sharp2 @@ -73,7 +73,7 @@ jobs: - name: Restore NuGet Packages run: nuget restore Duplicati.sln - - name: Install additional dependencies + - name: Install Additional Dependencies run: sudo apt-get install gtk-sharp2 - name: Build Duplicati