Commit Graph
605 Commits
Author SHA1 Message Date
User 8755390dc8 don't store journal data for partial backups 2019-11-20 20:46:27 -08:00
Kenneth Hsu 93bc478d37 Issue warning when backup is cancelled by user.
Previously, a yellow warning icon would be displayed but the logs did
not contain any details regarding the cause of the warning.

This concerns issue #3982.
2019-11-10 11:20:11 -08:00
Fish 3cf01b7297 Advance the progress bar when files are skipped. Fixes #3407.
According to the current implementation, the progress bar does not advance
when files are skipped by FilePreFilterProcess. This causes users'
confusion since the web frontend will get stuck at a certain stage for a
long time. This commit addresses this issue.
2019-11-03 21:34:21 -07:00
Kenneth SkovhedeandGitHub 99d0cb3c57 Merge pull request #3953 from warwickmm/make_fields_readonly
Mark fields that don't need to be reassigned as readonly
2019-10-21 08:36:17 +02:00
Kenneth Hsu 2aa76881a5 Mark fields that don't need to be reassigned as readonly.
This makes it explicit at compile-time that these fields should not be
reassigned outside the constructor.
2019-10-19 13:59:22 -07:00
Kenneth Hsu afab61a05b Use pattern matching to simplify casts. 2019-10-19 10:15:38 -07:00
Kenneth SkovhedeandGitHub 4bb0c507a2 Merge pull request #3930 from warwickmm/dispose_volume_writers
Ensure that instances of VolumeWriterBase are disposed
2019-10-19 14:24:55 +02:00
Kenneth SkovhedeandGitHub 579f9911d5 Merge pull request #3938 from warwickmm/bugfix/wrong_dblock_in_dindex
Ensure that dindex references correct dblock file after renames
2019-10-19 14:19:11 +02:00
Kenneth SkovhedeandGitHub 880459d1b7 Merge pull request #3925 from warwickmm/bugfix/missing_filelist
Ensure that filelist is always included in dlist files
2019-10-19 14:08:27 +02:00
Kenneth Hsu 1c492647ae Rename method parameter for consistency. 2019-10-05 11:25:22 -07:00
Kenneth Hsu 0cdc5b9159 Ensure that dindex contains correct dblock file after renames.
When support for parallel uploads was implemented, we overlooked a case
where a failed put of a dblock file is retried with a different
filename.  In this case, an instance of TemporaryIndexVolume was created
in the DataBlockProcessor or SpillCollectorProcess prior to the
attempted put.  The put would fail, and then retried with a different
filename.  While the Remotevolume table in the database would reflect
the new filename, the TemporaryIndexVolume still contained a reference
to the old dblock filename.  This would cause issues in direct restores,
etc., when the referenced dblock file could not be found.

Now, the TemporaryIndexVolume is only created after the dblock put has
completed.

This addresses issue #3932.
2019-10-05 10:46:39 -07:00
Kenneth Hsu 614ccaf79d Convert duplicated static methods into instance method. 2019-10-04 21:37:33 -07:00
warwickmmandGitHub 3b0525e2f8 Merge pull request #3928 from drwtsn32x/improve-purge-logging
Add progress logging for purge operation.
2019-09-29 13:24:13 -07:00
drwtsn32x 64a3c16030 Add X of Y logging for purge operation 2019-09-29 09:42:47 -07:00
Kenneth Hsu 54992d5beb Ensure that BlockVolumeWriter is disposed. 2019-09-28 10:31:37 -07:00
Kenneth Hsu bc975dd090 Ensure that IndexVolumeWriter is disposed. 2019-09-28 10:30:13 -07:00
Kenneth Hsu 8d7c6c6e21 Ensure that filelist is always written to dlist files.
This fixes a regression introduced around revisions e0899a2a91 ("add
method to add the filelist file") and 3b5af1cf01 ("add method to add
filelist file"), where the filelist was not written by all usages of the
FilesetVolumeWriter.  Previously, one would have to invoke
AddFilelistFile with each usage.  Now, we simply do so when the
FilesetVolumeWriter is closed.

We also modified the UploadSyntheticFilelist so that the usage of the
FilesetVolumeWriter is contained in a using statement, which will ensure
that it is disposed.

This fixes issue #3924.
2019-09-27 20:35:06 -07:00
Kenneth Hsu 5e9dd9a7b8 Expose BackupType to test classes. 2019-09-17 12:46:23 -07:00
Kenneth SkovhedeandGitHub 153a972853 Merge branch 'master' into fix-stop-after-current-file 2019-09-17 10:06:36 +02:00
Kenneth SkovhedeandGitHub dc470b5734 Merge pull request #3894 from BlueBlock/add-purge-of-deleted-remotevolumes
Add purging of deleted remote volumes from database
2019-09-17 09:50:11 +02:00
drwtsn32x 4df61495c2 change wording 2019-09-11 17:52:57 -07:00
drwtsn32x 76c61699eb Improve logging during database recreation 2019-09-11 03:43:54 -07:00
BlueBlock 3b5af1cf01 add method to add filelist file
This is part of correcting the way the dlist zip file is created. We now have a method to take the memorystream and put the file into dlist.
2019-09-10 13:12:21 -04:00
BlueBlock f1895acff5 add the fileset file to dlist
we also jsut set PartialBackup=false just to be clear and not assume the value
2019-09-10 13:05:45 -04:00
BlueBlock 0685e61285 method refactored to include actual IsFullBackup state 2019-09-10 12:56:04 -04:00
BlueBlock 605efac4e7 retrieve filesetData to get IsFullBackup state 2019-09-10 12:51:42 -04:00
BlueBlock 7f73616614 add purging of deleted remote volumes 2019-09-07 17:16:34 -04:00
BlueBlock 962dd41e90 enforce order for 'versions' and 'filesets' 2019-09-02 18:38:51 -04:00
BlueBlock 8f93e446b2 re-created filesets are set to full backups 2019-09-02 18:20:21 -04:00
BlueBlock f6075a26d7 carry isFullBackup value over to new replacement filesets created by purge 2019-09-01 13:13:45 -04:00
BlueBlock fc5297f151 clarify comment 2019-08-31 16:35:57 -04:00
BlueBlock 9a4c120958 remove 1 line of commented code 2019-08-31 16:32:23 -04:00
BlueBlock f3d31a840a rename variable to clarify it relates to full backups 2019-08-31 16:32:05 -04:00
BlueBlock 5c11ad4beb use reference 2019-08-31 14:44:12 -04:00
BlueBlock efb24d085e Merge remote-tracking branch 'upstream/master' into fix-stop-after-current-file 2019-08-31 14:12:14 -04:00
BlueBlock 8b42e247a5 license update 2019-08-30 12:38:54 -04:00
BlueBlock 3285699965 remove unused using 2019-08-30 12:38:14 -04:00
BlueBlock a918529413 GetFilesetsToDelete() to enforce sorting
it expects it to be sorted so it should sort it
2019-08-30 12:37:55 -04:00
BlueBlock 86bb9c81d3 replace int with const reference 2019-08-30 11:26:23 -04:00
BlueBlock 1bd71ba8ab remove unused variable
a using not needed also
2019-08-30 11:18:49 -04:00
BlueBlock 42342f30be move new stream to Utility 2019-08-27 23:48:07 -04:00
BlueBlock c07411acb7 resolve codacy issues 2019-08-27 14:34:34 -04:00
BlueBlock 146b98ae4c initial fix for issue1400 2019-08-27 14:09:43 -04:00
BlueBlock b444d4bdf7 remove unused variable 2019-08-23 10:53:26 -04:00
BlueBlock 5614c3ef81 change where gui backup version count gets the count
get the count from the db so we can filter on isFullBackup
2019-08-18 14:42:39 -04:00
BlueBlock 9ae3f88dd5 Merge remote-tracking branch 'upstream/master' into fix-stop-after-current-file 2019-08-16 23:46:55 -04:00
BlueBlock 08e2c18185 add handling of a partial backup
- add backup state to DB table 'fileset' (job database upgrade to version 10)
- modify the Restore page dropdown to display if a backup is "partial"
- modify retention logic to remove partial backups only when the next recent full-backup has been removed
2019-08-05 20:14:05 -04:00
BlueBlock e52cef304b codacy fixes applied 2 2019-08-02 13:54:30 -04:00
BlueBlock 4407d24f5d codacy fixes applied 2019-08-02 13:48:50 -04:00
BlueBlock ca736c74de update the backups stats also when a bcakup is cancelled
PostBackupVerification() was being skipped when a bcakup was cancelled. PostBackupVerification() will now be called.
2019-08-02 13:40:57 -04:00