Commit Graph
194 Commits
Author SHA1 Message Date
Rune HenriksenandGitHub 11ab3f5bc5 Merge pull request #3623 from warwickmm/remove_optional_parameters
Remove optional parameters from Controller.List overloads
2019-01-25 23:30:11 +01:00
Kenneth Hsu 5e0b44b32c Remove unused method. 2019-01-22 21:13:07 -08:00
Kenneth Hsu b75b439772 Make optional parameter required.
There is only one usage of this method that did not provide value for
the filter parameter.  By making this parameter required, we can avoid
the many issues that arise with optional parameters (default values
being embedded at the call sites, ambiguous overload resolution, etc.).
2019-01-22 17:53:25 -08:00
Kenneth Hsu 8abce38215 Remove unnecessary optional parameter.
No current usages of this method provide an argument for this parameter.
2019-01-22 17:44:55 -08:00
Kenneth Hsu b5d9451b33 Remove redundant casts. 2019-01-21 19:30:52 -08:00
Kenneth Hsu a179a535c8 Rename local variables to better indicate that they are unused. 2018-12-31 14:59:47 -08:00
Mikael Mello 965bd6d761 result-classes: rename properties of RestoreResults to be consistent with BackupResults 2018-12-12 12:14:11 -02:00
verhoek 8bb406cd15 Migrated to use the platform class. 2018-11-02 22:17:16 +01:00
verhoek b2cc18426c Renamed Library.IO to Library.Common.IO.
Moved basic Platform functions to Library.Common.Platform.
Turned IO_OS into property within Library.Common.
2018-11-02 21:34:07 +01:00
verhoek 1275f14405 Replaced DirectorySeparatorChar.ToString() calls. 2018-11-02 17:45:00 +01:00
verhoek bc053df294 Moved basic IO helper functions to Library.IO. 2018-10-27 12:17:07 +02:00
Rune HenriksenandGitHub be7edb580d Merge pull request #3410 from warwickmm/simplify_enumerating_collections
Simplify enumeration of collections
2018-10-07 19:06:28 +02:00
Kenneth Hsu b824c86c7e Avoid unnecessary enumeration of collections.
This improves performance by using Any() to avoid unnecessary
enumeration of collections.
2018-10-06 16:20:18 -07:00
Kenneth Hsu d72128ec83 Remove unused method parameters. 2018-10-06 15:09:43 -07:00
Kenneth Hsu 0d23302220 Use ordinal case-insensitive comparison instead of ToLower. 2018-09-19 15:21:59 -07:00
Kenneth Skovhede 494fccd931 Added support for multiple exit codes, and added a unittest to verify that the exit codes are handled correctly 2018-08-14 11:09:16 +02:00
Kenneth Skovhede 07815c1751 Added warning to unqualified size options 2018-08-08 11:58:35 +02:00
Kenneth Skovhede 9bfcab73bc Added some future work 2018-06-30 18:48:20 +02:00
Kenneth SkovhedeandGitHub 6e2d4a9071 Merge pull request #3266 from verhoek/refactoring/tempdir_var
Clean up tempdir environment vars
2018-06-28 10:06:28 +02:00
verhoek e94382194c Removed reset keys since we do not store in environment vars anymore. 2018-06-11 09:24:25 +02:00
verhoek 20a7af1cb1 Renamed to unauthorized to be consisten with .NET api. 2018-06-11 09:07:32 +02:00
verhoek 12293b77b2 Moved from public to private. 2018-06-11 08:55:31 +02:00
verhoek d0bfcf224f Added case fail on unauthorized. 2018-06-11 08:51:50 +02:00
Kenneth Hsu f12858e6a5 Mark fields that shouldn't be reassigned as readonly.
This makes it explicit at compile-time that these fields should not be
reassigned outside the constructor.
2018-05-25 10:04:52 -07:00
verhoek 30cd41585b Corrected spelling function name. 2018-05-16 20:08:40 +02:00
Kenneth Skovhede 79f7b22e0f Merge branch 'master' into concurrent_processing
Changed a few things on the way, removing the log process

# Conflicts:
#	Duplicati/Library/Main/Controller.cs
#	Duplicati/Library/Main/Database/ExtensionMethods.cs
#	Duplicati/Library/Main/Database/LocalBackupDatabase.cs
#	Duplicati/Library/Main/Duplicati.Library.Main.csproj
#	Duplicati/Library/Main/Operation/BackupHandler.cs
#	Duplicati/Library/Main/Operation/FilelistProcessor.cs
#	Duplicati/Library/Main/Operation/PurgeBrokenFilesHandler.cs
#	Duplicati/Library/Main/Operation/TestFilterHandler.cs
#	Duplicati/Library/Main/Options.cs
#	Duplicati/Library/Main/ResultClasses.cs
#	Duplicati/UnitTest/BasicSetupHelper.cs
2018-04-11 23:02:47 +02:00
Kenneth Skovhede b1615bceef Removed the repeating log scope for now 2018-04-10 13:08:17 +02:00
Kenneth Skovhede 682159623c Split out the Tag and FilterTag properties to allow re-entering a log message without adding chaining strings to the message 2018-04-09 14:28:30 +02:00
Kenneth Skovhede 20e2dcafb3 Moved the process control stuff into another class, so it can be disposed easily and contain its own state 2018-03-16 10:33:26 +01:00
Kenneth Skovhede 3ec6b88ac8 Added a repeating log-scope that writes out a message, if no activity produced a log message for 10 seconds 2018-03-15 23:30:24 +01:00
Kenneth Skovhede 842fd96543 Implemented a new logging system that is more transparent and allows a more granular way of picking log messages.
Added ID's to each log message and each exception to allow later introduction of a Knowledgebase service that explains each error in more detail.
2018-03-15 09:12:34 +01:00
Kenneth SkovhedeandGitHub 9ea9176ce0 Merge pull request #3059 from TekkiWuff/feature/retention-policy-unlimited-option
Easier syntax for unlimited timeframes and intervals
2018-02-26 09:32:30 +01:00
Kenneth Skovhede fe7f9cf67a Added warnings to discourage people from using 7z in the current state 2018-02-22 17:11:07 +01:00
Daniel Radünz 6da001cbe9 Easier syntax for unlimited timeframes and intervals
Also refactored retention policy option to use a list of custom objects instead of a dictionary to reduce confusion when working with the values of the retention policy
2018-02-21 21:30:17 +01:00
Daniel Radünz f8cbc91152 Disallow using multiple rentention options (keep-time, keep-versions, rentention-policy) 2018-02-11 17:18:30 +01:00
Kenneth Skovhede 75bf6857c1 Merge branch 'master' into concurrent_processing
# Conflicts:
#	.travis.yml
#	Duplicati/Library/Main/Database/LocalBackupDatabase.cs
#	Duplicati/Library/Main/Operation/BackupHandler.cs
#	Duplicati/Library/Main/ResultClasses.cs
#	Duplicati/Library/Main/Volumes/VolumeWriterBase.cs
#	Duplicati/Library/Utility/TempFile.cs
2018-01-20 15:02:41 +01:00
Brian Lakstins ba8dddc7fe Move RunScript module to be configured first so that any configuration changes can be used by other modules 2018-01-12 09:43:07 -05:00
Kenneth Hsu 8810e0130d Make string comparisons use ordinal (binary) sort rules.
These string comparisons should not be culture-aware.
2017-11-26 11:19:54 -08:00
Kenneth Skovhede efc06b7210 Refactored the source path expansion/filtering into its own method.
Changed the check for subfolders to only work if the shortest path is a folder itself.
Changed the backup and test-filters method to use the same expansion logic so the filter test is more reliable.
This fixes #2778
2017-10-30 15:30:43 +01:00
Kenneth Skovhede f03965eb65 Fixed compile error after refactor 2017-10-11 08:58:58 +02:00
Kenneth Skovhede 451c71ccb1 Changed remote-file delete logic to only delete files that look like Duplicati files and have the correct prefix.
This fixes #2678
2017-10-10 16:44:06 +02:00
Kenneth SkovhedeandGitHub 38a8d11266 Merge pull request #2781 from TekkiWuff/retention-policy
Retention Policy
2017-10-04 15:12:19 +02:00
Daniel Radünz 0a4a6edca1 Renamed all occurrences of "staggered version" to "retention policy" 2017-09-30 22:05:30 +02:00
Daniel Radünz 7b176e4dc2 Check validity of keep-staggered-versions option value 2017-09-30 22:05:30 +02:00
Kenneth Hsu 146f4aaa5b Use helper method to get unique items and duplicates. 2017-09-28 21:48:38 -07:00
Kenneth Skovhede 0dd56f1650 Merge branch 'master' into concurrent_processing
# Conflicts:
#	Duplicati/Library/Main/Options.cs
2017-09-19 12:51:40 +02:00
Tyler Gill 83a1dcfb64 Replace all instances of InvariantCultureIgnoreCase with OrdinalIgnoreCase in string comparisons.
InvariantCulture is useful when comparing / sorting human language strings in a culturely correct way. It handles things like accented letters in a way that makes sense to humans (e.g., 'a' should be sorted next to 'á', rather than after 'z').
Ordinal looks just at the raw code points of the characters. As such, it is recommended for use in cases when comparing system strings (file paths, command line parameters, config settings, etc.). Since it doesn't need to use the culture specific sorting rules, this method can often be faster.

For more information, see https://stackoverflow.com/questions/492799/difference-between-invariantculture-and-ordinal-string-comparison (and other related questions)
2017-09-18 23:55:08 -06:00
Kenneth Skovhede c9af99016a Merge branch 'master' into concurrent_processing 2017-09-18 15:28:43 +02:00
Kenneth Skovhede d57c789f4f Merge branch 'master' into concurrent_processing
# Conflicts:
#	Duplicati/Library/Main/Duplicati.Library.Main.csproj
#	Duplicati/Library/Main/Options.cs
2017-09-18 11:56:35 +02:00
Tyler Gill f9618b9587 Add support for specifying backup paths by volume guid.
These volume guids can be found via the 'mountvol' command, and are reported by the built in help.
This also includes some updates to the documentation and logging when using wildcard drives in source paths.
2017-09-14 23:16:07 -07:00