Rune Henriksen and GitHub
777876556e
Merge pull request #3666 from warwickmm/avoid_null_reference
...
Avoid potential null reference exception
2019-02-20 17:28:08 +01:00
Kenneth Hsu
224a895975
Fix spelling error in log message id.
2019-02-19 20:23:07 -08:00
Rune Henriksen and GitHub
59732d5f49
Merge pull request #3663 from warwickmm/remove_unused_option_collections
...
Remove unused Options properties
2019-02-19 23:54:32 +01:00
Kenneth Hsu
8a31eac5c0
Avoid potential null reference exception.
2019-02-18 12:50:46 -08:00
Kenneth Hsu
1dc7d70b6e
Fix spelling error in log message.
2019-02-18 12:12:32 -08:00
Kenneth Hsu
ffc2997b0f
Remove unused Options properties.
...
These collection of options are not being used, and have not been
maintained.
2019-02-17 18:43:31 -08:00
Kenneth Hsu
e82c11b39b
Avoid possible null reference exception.
2019-02-16 20:43:05 -08:00
Kenneth Hsu
daf0311bf8
Allow removal of VolumeWriterBase temp files.
...
This reverts a change made in revision 31ac40083a ("Prevent temp files
in VolumeWriterBase from being deleted prematurely" in pull request #2637 ).
It's unclear what issue was being worked around by preventing the
removal of the temporary files (based on comments in pull request #2637 ,
it appears to be related to tests that failed only on Travis). However,
this workaround prevented the removal of temporary files created during
compact operations, which caused several users' temporary directories to
be filled up with files that should have been removed.
This concerns issue #3652 .
2019-02-16 19:53:06 -08:00
Kenneth Hsu
3fc9276cdd
Remove temp files when compact operation is not performed.
...
This concerns issue #3652 .
2019-02-16 19:53:06 -08:00
Kenneth Hsu
c27ea24826
Ensure that FilesetVolumeWriter removes temp file upon disposal.
...
This ensures the removal of the temporary file containing the
filelist.json that remained regardless if files needed to be uploaded or
not.
This concerns issue #3652 .
2019-02-16 19:53:06 -08:00
Kenneth Skovhede
c01ab02712
Added support for "splitting" a root path.
...
This is a potential fix for #3637
2019-02-04 17:32:56 +01:00
Kenneth Skovhede
8b3dfcace8
Fixed the database upgrade script to copy over file IDs to avoid breaking databases on upgrade
2019-01-30 11:03:44 +01:00
Rune Henriksen and GitHub
c1578c6c0e
Merge pull request #3631 from warwickmm/remove_optional_parameters
...
Make parameters to Controller.ListControlFiles method required
2019-01-26 09:11:36 +01:00
Kenneth Hsu
df32525a47
Make parameters to Controller.ListControlFiles method required.
...
There is only one usage of this method, and it provides both parameters.
2019-01-25 20:19:33 -08:00
Rune Henriksen and GitHub
f5f353fe19
Merge branch 'master' into feature/fix_path_storage2
2019-01-25 23:37:57 +01:00
Rune Henriksen and GitHub
11ab3f5bc5
Merge pull request #3623 from warwickmm/remove_optional_parameters
...
Remove optional parameters from Controller.List overloads
2019-01-25 23:30:11 +01:00
Kenneth Hsu
5e0b44b32c
Remove unused method.
2019-01-22 21:13:07 -08:00
Kenneth Hsu
b75b439772
Make optional parameter required.
...
There is only one usage of this method that did not provide value for
the filter parameter. By making this parameter required, we can avoid
the many issues that arise with optional parameters (default values
being embedded at the call sites, ambiguous overload resolution, etc.).
2019-01-22 17:53:25 -08:00
Kenneth Hsu
8abce38215
Remove unnecessary optional parameter.
...
No current usages of this method provide an argument for this parameter.
2019-01-22 17:44:55 -08:00
Kenneth Hsu
b5d9451b33
Remove redundant casts.
2019-01-21 19:30:52 -08:00
Kenneth Skovhede and GitHub
b961fbd744
Merge pull request #3584 from Pectojin/remove_build_lookup_table_method
...
Remove unsed method and call
2019-01-13 10:31:24 +01:00
Max and Rune Henriksen
65e79a276b
fix for unc paths in prefixes ( #3599 )
2019-01-12 01:12:51 +01:00
Rune Henriksen
639edc1e36
removed reference to deleted method
2019-01-11 20:16:59 +01:00
Rune Henriksen
f43d094a23
set argument as disabled and remove flag toggle method
2019-01-11 20:11:30 +01:00
Kenneth Hsu
02e1a02100
Further clarify that remote files are used for verification.
2019-01-05 10:22:58 -08:00
Kenneth Hsu
8bf9c73dbc
Clarify help text for verification options.
...
This will hopefully make it clearer that the files being selected for
verification are those on the remote backend, and not user files that
are being backed up.
2019-01-05 10:00:39 -08:00
Hendrik and GitHub
c34c66bd34
Merge pull request #3582 from warwickmm/backup_test_percentage
...
Add option to specify percentage of samples for verification
2019-01-05 18:52:27 +01:00
Rune Henriksen
f696842877
remove unsed method and call
2019-01-05 00:30:43 +01:00
Rune Henriksen and GitHub
a951987dcd
Merge pull request #3577 from warwickmm/remove_unused_local_variables
...
Remove unused local variables
2019-01-05 00:13:55 +01:00
Kenneth Hsu
b4232ce1bf
Provide more meaningful exception message.
2019-01-04 13:02:58 -08:00
Kenneth Hsu
52790cc7a9
Throw exception if backup-test-percentage is out of range.
2019-01-04 12:21:37 -08:00
Kenneth Hsu
edfa7096f6
Add option to specify percentage of samples for verification.
...
This addresses issue #3296 .
2019-01-02 15:51:19 -08:00
Hendrik and GitHub
0c53219958
Merge pull request #3573 from warwickmm/remove_empty_finally
...
Remove empty finally blocks
2019-01-02 22:12:36 +01:00
Kenneth Hsu
a179a535c8
Rename local variables to better indicate that they are unused.
2018-12-31 14:59:47 -08:00
Kenneth Hsu
fcf89764c3
Remove unnecessary calls to ToString.
2018-12-31 14:29:44 -08:00
Kenneth Hsu
e65bf19221
Remove unused String.Format arguments.
...
We also make use of string interpolation to improve readability.
2018-12-31 14:24:14 -08:00
Kenneth Hsu
b7f28aa9f9
Remove empty finally blocks.
...
Empty finally blocks serve no purpose. In cases where no exceptions are
caught, we removed the try as well.
2018-12-31 14:00:43 -08:00
JonMikelV and Rune Henriksen
fff5145e2f
Fix typo in QuotaWarningThresholdLong ( #3549 )
...
"quota is less that this" -> "quota is less than this"
2018-12-20 22:07:34 +01:00
Kenneth Skovhede and GitHub
8d3ed27ac9
Merge pull request #3538 from LacunaSoftware/improve-backup-logs-ui
...
New improvements on Backup Logs UI
2018-12-13 15:01:16 +01:00
Mikael Mello
965bd6d761
result-classes: rename properties of RestoreResults to be consistent with BackupResults
2018-12-12 12:14:11 -02:00
Kenneth Hsu
8dd3aeaf26
Use invariant culture in calls to ToLower and ToUpper.
2018-12-11 21:21:07 -08:00
Kenneth Skovhede
49e54ab0b7
Merge branch 'feature/timestamp_clash_fix'
2018-12-11 10:33:57 +01:00
Kenneth Skovhede and GitHub
9f0ceb9a4c
Merge pull request #3534 from warwickmm/convert_write_only_properties
...
Replace write-only properties
2018-12-11 10:31:35 +01:00
Kenneth Skovhede and GitHub
ac606d887f
Merge pull request #3510 from LacunaSoftware/improve-backup-logs-ui
...
Improve UI for backup logs
2018-12-11 10:28:05 +01:00
Kenneth Hsu
5daf35d4f5
Use interface inheritance to remove write-only properites.
...
The one class that implements these interfaces, BasicResults, requires
both read and write access to these properties. As such, we might as
well declare the getter and setter in the interface.
2018-12-09 21:42:40 -08:00
Kenneth Hsu
8b6cf0c6d9
Make ISetCommonOptions.MessageSink property readable.
...
Since the only implementation, BasicResults, specifies a getter for this
property, we might as well declare this in the interface.
2018-12-09 21:42:36 -08:00
Kenneth Hsu
a44bc7542f
Make ISetCommonOptions.BeginTime property readable.
...
Since the only implementation, BasicResults, specifies a getter for this
property, we might as well declare this in the interface.
2018-12-09 21:42:33 -08:00
Kenneth Hsu
7e6fa8a202
Convert write-only IMessageSink.OperationProgress property to method.
...
Write-only properties are confusing and the behavior is better
implemented as a method, which more clearly conveys the write-only
semantics.
2018-12-09 20:23:05 -08:00
Kenneth Hsu
1764b9ad4e
Convert write-only IMessageSink.BackendProgress property to method.
...
Write-only properties are confusing and the behavior is better
implemented as a method, which more clearly conveys the write-only
semantics.
2018-12-09 20:23:05 -08:00
Mikael Mello
3dbfac93c6
basic-results: Increase limit of enumerable elements that are serialized
2018-12-07 16:45:44 -02:00