Commit Graph
4937 Commits
Author SHA1 Message Date
Kenneth Hsu 83ac03843d Fix spelling errors in comments.
In doing so, we also normalized some line endings.
2019-12-14 09:52:55 -08:00
Kenneth Hsu 60b4c8479c Fix bug where filesets considered for deletion had wrong version.
The ID in the Fileset table is the auto-incremented integer.  When
considering filesets for deletion (in particular, when deleting specific
versions), we need to reference the backup version number that is
exposed to the user (integers where the newest backup version is 0).
2019-12-12 18:38:17 -08:00
verhoek 72b6c7b780 Esthetical changes to SSH2 backend code.
Mostly auto suggested from IDE.
2019-12-12 21:57:27 +01:00
Kenneth SkovhedeandGitHub 2667db678b Merge branch 'master' into issue_3979 2019-12-12 11:50:35 +01:00
Kenneth Hsu 9cb602b171 Reorder classes to simplify diff. 2019-12-11 20:43:34 -08:00
Kenneth Hsu 68ffd86594 Refactor fileset deletion code.
This extracts the logic for various fileset deletion strategies into
separate classes.  This simplifies the code and makes it easier to test
the individual functionalities.
2019-12-11 17:59:20 -08:00
Kenneth Hsu 48444782c2 Fix regression with SharePoint backend.
In pull request #3989, we set the conflict resolution behavior for
creating new items to be "Replace".  While this worked for OneDrive,
SharePoint apparently is case-sensitive and expects "replace".  Since
the default behavior is to replace, we will simply remove the
specification to avoid possible conflicts.

See the forum discussion below:

https://forum.duplicati.com/t/bad-request-error-from-request-nameconflictbehavior-must-be-fail-replace-or-rename/8578
2019-12-07 12:19:21 -08:00
warwickmmandGitHub 514fc90bd1 Merge pull request #3992 from warwickmm/unhide_partial_filesets
Fix various issues related to partial backups
2019-12-07 10:36:13 -08:00
User 74b0811061 add comment 2019-12-03 19:33:45 -08:00
User b1b45228c2 fix long path test 2019-12-03 18:07:23 -08:00
Kenneth Hsu 53a35e6e06 Remove support for Amazon Cloud Drive.
Amazon discontinued access to the Cloud Drive API.

See https://forum.duplicati.com/t/amazon-cloud-drive-discontinued/7391.
2019-12-01 10:36:36 -08:00
verhoek 3f3de17d1c Fix codacy complaints. 2019-11-30 23:14:17 +01:00
Kenneth Hsu 0f30604046 Add comment clarifying partial fileset in synthetic filelist. 2019-11-30 13:38:04 -08:00
Kenneth Hsu 20eb785f09 Simplify implementation of keep-versions logic. 2019-11-29 19:45:40 -08:00
Kenneth Hsu 39ba32c383 Remove redundant conditional expression. 2019-11-29 09:10:27 -08:00
Kenneth Hsu b4bef4bea0 Clarify comment. 2019-11-29 09:10:27 -08:00
Kenneth Hsu a47175a945 Fix bug in keep-versions logic where dangling partials were removed.
If the most recent backups were partials (and not followed by a full
backup), they should not be removed.  A partial backup should only be
removed if it is followed by a full backup.

This concerns issue #3982.
2019-11-29 09:10:27 -08:00
Kenneth Hsu fa3ffb7540 Add comment to explain download of dlist files during direct restore. 2019-11-28 20:16:57 -08:00
verhoek 274bcfc437 Removed forgotten m_options. 2019-11-27 21:49:45 +01:00
HendrikandGitHub 057a012277 Merge pull request #3998 from drwtsn32x/fix-attribute-masking
Disable file attribute masking on Windows 10
2019-11-27 11:38:27 +01:00
drwtsn32x 942d8b820d removed getter 2019-11-26 19:27:46 -08:00
verhoek 8d782bd0c8 Make codacy happier. 2019-11-26 22:19:11 +01:00
verhoek 707ee587af Use same exception handling cases for Minio as for the AWS client. 2019-11-26 21:59:53 +01:00
verhoek f93562931d Adjusted static command line doc for s3-client. 2019-11-25 23:46:50 +01:00
verhoek 0ff63913ed Implemented remaining methods.
Add remove object method.
Add dns host.
Added rename method.
2019-11-25 22:44:16 +01:00
verhoek 8f0002465e Add get object to minio client. 2019-11-24 22:53:37 +01:00
verhoek 201a3a27a7 Removal of obsolete method. 2019-11-24 22:53:21 +01:00
verhoek 2243c7d609 Added put object to minio s3 client. 2019-11-24 11:21:00 +01:00
verhoek fee7ad02a9 Remove unused functions from aws sdk wrapper. 2019-11-24 11:11:17 +01:00
Kenneth Hsu 861f0ffa1b Ensure that one full backup is kept when processing keep-time.
this concerns issue #3982.
2019-11-23 12:20:56 -08:00
verhoek 0cc79c5a6e Implemented addbucket for minio. 2019-11-23 09:45:06 +01:00
verhoek 259dd75953 Added listbucket for minio client 2019-11-22 22:37:23 +01:00
drwtsn32x f599336bf0 tweak for codacity 2019-11-22 08:26:38 -08:00
drwtsn32x 77a1e3b88a disable attribute masking 2019-11-22 08:00:58 -08:00
Kenneth Hsu cd08ca919a Include fileset file in synthetic filelist.
We declare this to be a partial backup, with the presumption being that
a synthetic filelist is only created when a backup is interrupted.

This concerns issue #3982.
2019-11-21 19:14:48 -08:00
Kenneth Hsu 51b4ecfb28 Include fileset file in dlist files after purge operation.
This concerns issue #3982.
2019-11-21 19:08:55 -08:00
HendrikandGitHub c37eb1680d Merge pull request #3995 from drwtsn32x/fix-issue-3971
Fix issue 3971 - Don't store USN journal data for partial backups
2019-11-21 22:46:51 +01:00
verhoek a0b20bfd92 Created s3 client interface. 2019-11-21 22:37:32 +01:00
verhoek 7b859792fe Start writing MinioWrapper using Minio. 2019-11-21 22:37:09 +01:00
Kenneth Hsu 0cfce6be39 Include fileset file when repairing missing dlist file.
This concerns issue #3982.
2019-11-20 22:19:03 -08:00
User 8755390dc8 don't store journal data for partial backups 2019-11-20 20:46:27 -08:00
Kenneth Hsu 8ab64071f0 Display correct backup type when using direct restore.
Previously, all filesets would be displayed as partial.  Now, we obtain
the partial/full type from the fileset file (not the fileset.json) file
in the dlist file.  If this file does not exist, the backup type
defaults fo full.

Note that this requires downloading and uncompressing the dlist file, so
performance of populating the restore list may be impacted
significantly.

This concerns issue #3982.
2019-11-20 20:23:48 -08:00
drwtsn32x 8f9ec70680 only warn if delete failure is confirmed 2019-11-19 20:28:14 -08:00
Kenneth Hsu 17d72be7ff Remove intermediate partial backups in delete handler.
If surrounded by full backups, partial backups are assumed to be no
longer necessary.

This concerns issue #3982.
2019-11-19 19:48:40 -08:00
Kenneth Hsu 4950e7c225 Unhide partial filesets from Sets property getter.
This concerns issue #3982.
2019-11-19 19:30:01 -08:00
Kenneth Hsu c395e77bc2 Unhide partial filesets from QuickSets property getter.
This concerns issue #3982.
2019-11-19 19:29:59 -08:00
Kenneth Hsu d60248e26a Unhide partial filesets from FilesetTimes property getter.
This concerns issue #3982.
2019-11-19 19:29:52 -08:00
HendrikandGitHub 2f6a1e2ba4 Merge pull request #3984 from warwickmm/cancelled_backup_warning
Issue warning when backup is cancelled by user
2019-11-15 21:49:36 +01:00
Tyler Gill 5364345edd Add ConfigureAwait(false) to MSGraph backends' awaits. 2019-11-14 07:51:49 -07:00
Tyler Gill e9543142f2 Explicitly dispose request messages, request contents, and response messages 2019-11-13 12:18:19 -07:00