Kenneth Hsu
8bf9c73dbc
Clarify help text for verification options.
...
This will hopefully make it clearer that the files being selected for
verification are those on the remote backend, and not user files that
are being backed up.
2019-01-05 10:00:39 -08:00
Hendrik and GitHub
c34c66bd34
Merge pull request #3582 from warwickmm/backup_test_percentage
...
Add option to specify percentage of samples for verification
2019-01-05 18:52:27 +01:00
Hendrik and GitHub
da64b4447f
Merge pull request #3581 from warwickmm/avoid_redundant_path_separator
...
Avoid redundant calls to Util.AppendDirSeparator
2019-01-05 16:47:00 +01:00
Rune Henriksen
f696842877
remove unsed method and call
2019-01-05 00:30:43 +01:00
Rune Henriksen and GitHub
a951987dcd
Merge pull request #3577 from warwickmm/remove_unused_local_variables
...
Remove unused local variables
2019-01-05 00:13:55 +01:00
Kenneth Hsu
b4232ce1bf
Provide more meaningful exception message.
2019-01-04 13:02:58 -08:00
Kenneth Hsu
52790cc7a9
Throw exception if backup-test-percentage is out of range.
2019-01-04 12:21:37 -08:00
Kenneth Hsu
edfa7096f6
Add option to specify percentage of samples for verification.
...
This addresses issue #3296 .
2019-01-02 15:51:19 -08:00
Kenneth Hsu
9c7f71a63d
Remove unnecessary newline.
2019-01-02 15:45:53 -08:00
Kenneth Hsu
ca6bbdc37a
Remove unnecessary line breaks.
2019-01-02 15:45:53 -08:00
Kenneth Hsu
16da136a6a
Avoid redundant addition of trailing slashes to folder names.
...
The trailing slash is added when the folder name is pushed onto the
stack.
2019-01-02 15:45:53 -08:00
Kenneth Hsu
7dc240d447
Avoid redundant addition of trailing slashes to folder names.
...
The Utility.EnumerateFilesAndFolders method will append the trailing
slash as needed.
2019-01-02 15:45:53 -08:00
Hendrik and GitHub
0c53219958
Merge pull request #3573 from warwickmm/remove_empty_finally
...
Remove empty finally blocks
2019-01-02 22:12:36 +01:00
Kenneth Hsu
577154df00
Remove unused local variables.
2018-12-31 15:02:59 -08:00
Kenneth Hsu
a179a535c8
Rename local variables to better indicate that they are unused.
2018-12-31 14:59:47 -08:00
Kenneth Hsu
fcf89764c3
Remove unnecessary calls to ToString.
2018-12-31 14:29:44 -08:00
Kenneth Hsu
e65bf19221
Remove unused String.Format arguments.
...
We also make use of string interpolation to improve readability.
2018-12-31 14:24:14 -08:00
Kenneth Hsu
b7f28aa9f9
Remove empty finally blocks.
...
Empty finally blocks serve no purpose. In cases where no exceptions are
caught, we removed the try as well.
2018-12-31 14:00:43 -08:00
Kenneth Skovhede and GitHub
f8cbd206e0
Merge pull request #3568 from warwickmm/default_excludes_performance
...
Improve performance of default excludes filters
2018-12-29 09:11:45 +01:00
Kenneth Hsu
7a106df094
Improve performance of default excludes filters.
...
Previously, the FilterExpression.Expand method would forward the filter
group name to the FilterEntry constructor, which would combine the
group's patterns into one large regex filter. This would result in a
significant decrease in performance, as the regex filters are much
slower than the wildcard filters.
Instead, we can first expand the filter group into its constituent
patterns before presenting them to the FilterEntry constructor. This
preserves their wildcard nature and allows us to take advantage of
faster filtering matching algorithms.
This addresses issue #3395 .
2018-12-28 22:07:59 -08:00
Kenneth Hsu
139420a664
Improve performance of wildcard filters.
...
The mono profiler indicated that a large percentage of the time was
spent allocating the inputPosStack and patternPosStack arrays. By
replacing these with Stacks, we can avoid this unnecessary overhead.
2018-12-28 17:33:46 -08:00
verhoek
14133457c6
Merge remote-tracking branch 'origin/master' into auto_updater/allow_for_new_key
2018-12-23 20:36:53 +01:00
verhoek
ae5d6ffcc7
Added option to generate new priv/pub key pair without verifying the manifest.
2018-12-23 20:32:21 +01:00
Rune Henriksen and GitHub
cc447de28a
Merge pull request #3545 from warwickmm/slow_default_excludes_workaround
...
Convert regex pattern to wildcard in default excludes group
2018-12-21 07:04:11 +01:00
Kenneth Hsu
faf2b0df47
Remove helper method that creates regex filter.
...
This will discourage the creation of default regex filters, which
exhibit poor performance.
2018-12-20 19:37:36 -08:00
JonMikelV and Rune Henriksen
fff5145e2f
Fix typo in QuotaWarningThresholdLong ( #3549 )
...
"quota is less that this" -> "quota is less than this"
2018-12-20 22:07:34 +01:00
Kenneth Hsu
340d7803cb
Convert regex pattern to wildcard in default excludes group.
...
This provides a workaround for the poor performance of the default
excludes group exhibited by regex filters. While this wildcard pattern
will potentially exclude more files than the previous regex pattern, in
practice this should not often be the case.
This does not resolve the performance issue of the regex filters.
However, I think in general we should try to avoid expensive
application-specific filters since these will affect the performance for
all users that use the default excludes group, whether the application
is present or not.
This concerns issue #3395 .
2018-12-17 18:14:43 -08:00
Kenneth Hsu
0a37b9075d
Remove condition that always evaluates to true.
2018-12-15 14:23:02 -08:00
Kenneth Skovhede and GitHub
8d3ed27ac9
Merge pull request #3538 from LacunaSoftware/improve-backup-logs-ui
...
New improvements on Backup Logs UI
2018-12-13 15:01:16 +01:00
Mikael Mello
965bd6d761
result-classes: rename properties of RestoreResults to be consistent with BackupResults
2018-12-12 12:14:11 -02:00
Kenneth Hsu
8dd3aeaf26
Use invariant culture in calls to ToLower and ToUpper.
2018-12-11 21:21:07 -08:00
Kenneth Skovhede
49e54ab0b7
Merge branch 'feature/timestamp_clash_fix'
2018-12-11 10:33:57 +01:00
Kenneth Skovhede and GitHub
9f0ceb9a4c
Merge pull request #3534 from warwickmm/convert_write_only_properties
...
Replace write-only properties
2018-12-11 10:31:35 +01:00
Kenneth Skovhede and GitHub
ac606d887f
Merge pull request #3510 from LacunaSoftware/improve-backup-logs-ui
...
Improve UI for backup logs
2018-12-11 10:28:05 +01:00
Kenneth Hsu
5daf35d4f5
Use interface inheritance to remove write-only properites.
...
The one class that implements these interfaces, BasicResults, requires
both read and write access to these properties. As such, we might as
well declare the getter and setter in the interface.
2018-12-09 21:42:40 -08:00
Kenneth Hsu
308410650b
Remove write-only LinkedSubStream.Position implementation.
...
The LinkedSubStream class is abstract, and all derived classes implement
a getter and a setter.
2018-12-09 21:42:40 -08:00
Kenneth Hsu
8b6cf0c6d9
Make ISetCommonOptions.MessageSink property readable.
...
Since the only implementation, BasicResults, specifies a getter for this
property, we might as well declare this in the interface.
2018-12-09 21:42:36 -08:00
Kenneth Hsu
a44bc7542f
Make ISetCommonOptions.BeginTime property readable.
...
Since the only implementation, BasicResults, specifies a getter for this
property, we might as well declare this in the interface.
2018-12-09 21:42:33 -08:00
Kenneth Hsu
7e6fa8a202
Convert write-only IMessageSink.OperationProgress property to method.
...
Write-only properties are confusing and the behavior is better
implemented as a method, which more clearly conveys the write-only
semantics.
2018-12-09 20:23:05 -08:00
Kenneth Hsu
1764b9ad4e
Convert write-only IMessageSink.BackendProgress property to method.
...
Write-only properties are confusing and the behavior is better
implemented as a method, which more clearly conveys the write-only
semantics.
2018-12-09 20:23:05 -08:00
Mikael Mello
3dbfac93c6
basic-results: Increase limit of enumerable elements that are serialized
2018-12-07 16:45:44 -02:00
Kenneth Skovhede
040655b579
Possible fix for #2857
2018-12-07 09:46:10 +01:00
Mikael Mello
aa71b888c3
basic-results: Serialize full length of enumerable properties that are limited
...
Useful to display the know the actual number of errors/warnings/etc when debugging without
having to store all of the errors.
2018-12-05 17:10:08 -02:00
Mikael Mello
ec5fee9f9a
basic-results: Serialize enumerable properties up to a certain number of elements
2018-12-04 12:14:08 -02:00
Mikael Mello and GitHub
172b0284ab
localDatabase: Remove trailing exclamation mark on exception text
2018-12-03 08:13:58 -02:00
Mikael Mello
c2c2718082
resultClasses: Fix ParsedResult of RepairResults
...
RepairResults could have warning/error in its child and not report correct result
2018-11-29 10:57:30 -02:00
verhoek
e2c2bc1a79
Moved method to bottom to let the PathTooLong* methods group together.
2018-11-29 09:37:10 +01:00
verhoek
9ce8471bde
Cache serializer.
2018-11-29 09:32:42 +01:00
verhoek
bb7062d34b
Regrouped methods.
2018-11-29 09:13:13 +01:00
verhoek
57c96da914
Reducing duplicate code.
2018-11-29 09:00:48 +01:00
Kenneth Hsu