Commit Graph
93 Commits
Author SHA1 Message Date
Kenneth Hsu 183ae4ede2 Remove additional unused variables. 2018-09-29 12:49:22 -07:00
Kenneth Hsu f4f676a1de Remove unnecessary variable assignment.
These variables are assigned values that are never read by any
subsequent instruction.
2018-09-28 20:13:45 -07:00
Rune HenriksenandGitHub 0901d3f62f Merge pull request #3387 from warwickmm/ordinal_case_insensitive_comparison
Use ordinal case-insensitive comparison instead of ToLower and ToUpper
2018-09-20 23:33:21 +02:00
Kenneth Hsu df5f8e16b9 Use ordinal case-insensitive comparison instead of ToUpper. 2018-09-19 15:21:59 -07:00
Kenneth Hsu 588363d6fb Remove unnecessary call to String.Format. 2018-09-18 21:37:12 -07:00
Kenneth Skovhede c4b564358c Spelling fixes 2018-08-12 22:33:21 +02:00
Kenneth Hsu 54c4f9224d Allow tasks to complete on any thread when context is irrelevant.
When the code following the await can be executed on any thread, it's
recommended to use ConfigureAwait(false) to avoid unnecessary context
switching and potential deadlocks.
2018-06-21 19:28:27 -07:00
Kenneth SkovhedeandGitHub 061bc38f1c Merge pull request #3256 from warwickmm/use_stream_read_helper
Use helper method to read from Streams and add unit tests
2018-06-07 13:42:54 +02:00
Kenneth Hsu 1605dc8ede Use utility method to read from stream. 2018-06-06 19:54:45 -07:00
Kenneth Hsu 08a897d7b0 Remove redundant calls to ToString. 2018-06-04 20:15:34 -07:00
Kenneth Hsu afdae80716 Fix line ending issues. 2018-06-02 13:19:49 -07:00
Kenneth Hsu f12858e6a5 Mark fields that shouldn't be reassigned as readonly.
This makes it explicit at compile-time that these fields should not be
reassigned outside the constructor.
2018-05-25 10:04:52 -07:00
Kenneth Skovhede d97484dfc2 Fixed a few minor issues with importing backup configurations 2018-04-23 09:15:43 +02:00
Kenneth Hsu c00c6fd19b Make fields containing lock objects readonly.
If one of these fields is accidentally reassigned, it's possible for
threads to be oblivious to an existing lock.  By making the fields
readonly, we will be notified at compile-time if we inadvertently
redefine one of these fields.
2018-03-17 19:59:23 -07:00
Rune Henriksen f414b2fdf2 added 'UserName' and 'StartedBy' variables to the system info page to help troubleshooting 2018-03-09 21:24:57 +01:00
Kenneth Hsu 1f8b542604 Use nameof operator when constructing ArgumentNullException.
This will make rename refactorings easier in the future.
2018-03-07 17:53:08 -08:00
Rune Henriksen 8c6cfdff97 updated http status codes on many ReportClientError calls to explicitly state what is wrong 2018-02-25 15:05:23 +01:00
Rune Henriksen 843b3e4eb2 Made the LogData poll API respect pagesize. Defaults to 100 if no pagesize is provided 2018-02-20 21:55:06 +01:00
Rune Henriksen 7975a9ad8c delete on unknown backup id should return 404 2018-02-18 03:29:27 +01:00
Tyler Gill 42a06ce4fd Merge branch 'master' of https://github.com/duplicati/duplicati into fix/reparse-points-arent-symlinks 2018-02-07 10:00:09 -07:00
Tyler Gill 08e0708a95 Change Duplicati's handling of reparse points, so that not all reparse points are treated as symlinks.
This is inspired largely by the new (/ returning) feature of OneDrive in Windows 10 Fall Creator's Update, which downloads files on-demand.
A side effect of that change is that the OneDrive folder (and subfolders of it) are marked as reparse points, even though they are not technically standard symlinks.
With this change, a new extension method IsSymlink is added for ISnapshotService and ISystemIO, which checks both the file attributes (for reparse point) and the symlink target path (if null, the path is not treated as a symlink).
All places that previously checked only the file attributes have been updated to use either this method (or at least the same logic, in the case of the core BackupHandler file check).
One side effect of this change is that '--symlink-policy=store' no longer ignores empty symlinks - they are now treated as regular files.
If there are empty symlinks, they will now be backed up as if they were regular files, but I don't know what the conditions are that create symlinks like that, so this might not effect anything in practice.
2018-02-06 13:24:49 -07:00
Pectojin f6242e3774 Added an overloaded AddTask method that allows tasks to skip the queue and updated the api call backup/<id>/run to skip the queue to correspond with the expectation of the 'Run now' button in the UI 2018-02-03 04:17:10 +01:00
Pectojin fcedd9746d added backend code to support stripping metadata from imported backup configs 2018-01-28 01:41:15 +01:00
Kenneth SkovhedeandGitHub 36aadc4ad1 Merge pull request #2910 from warwickmm/refactor/remove_redundant_tostring
Remove redundant calls to ToString
2017-11-27 08:50:00 +01:00
Kenneth Hsu 5fb1958ceb Remove redundant calls to ToString. 2017-11-26 15:44:34 -08:00
Kenneth Hsu 8810e0130d Make string comparisons use ordinal (binary) sort rules.
These string comparisons should not be culture-aware.
2017-11-26 11:19:54 -08:00
Tyler Gill 83a1dcfb64 Replace all instances of InvariantCultureIgnoreCase with OrdinalIgnoreCase in string comparisons.
InvariantCulture is useful when comparing / sorting human language strings in a culturely correct way. It handles things like accented letters in a way that makes sense to humans (e.g., 'a' should be sorted next to 'á', rather than after 'z').
Ordinal looks just at the raw code points of the characters. As such, it is recommended for use in cases when comparing system strings (file paths, command line parameters, config settings, etc.). Since it doesn't need to use the culture specific sorting rules, this method can often be faster.

For more information, see https://stackoverflow.com/questions/492799/difference-between-invariantculture-and-ordinal-string-comparison (and other related questions)
2017-09-18 23:55:08 -06:00
Kenneth Skovhede da0de9983b Implemented the live throttle control.
This fixes #1730
This fixes #1261
2017-06-20 13:00:52 +02:00
Kenneth Skovhede 1de5582cf2 If the server used an SSL certificate, the server settings would leak the certificate to all users that were logged in. 2017-06-07 10:05:05 +02:00
Kenneth Skovhede ded920178d Fixed a few issues with storing and reading UI settings 2017-05-31 22:44:16 +02:00
Kenneth Skovhede 62dc8e2178 Updated the UI commandline interface to work correctly with the status bar 2017-04-06 10:10:22 +02:00
Kenneth Skovhede e4f1d4106a Implemented a basic UI for running commandline from the WebUI 2017-04-04 16:58:29 +02:00
Kenneth Skovhede 8e9acddab8 Work on commandline 2017-03-29 09:53:28 +02:00
Kenneth Skovhede 8ed8919379 Fixed importing config files with AllowedDays set.
This fixes #2380.
2017-03-22 23:27:24 +01:00
Kenneth Skovhede e333c14236 Changed the import functionality to load the imported backup into the "Add" view, such that it can be changed before being imported.
Also added support for restoring from an exported configuration file, by loading the values into the restore-direct view.
This adds support for importing a configuration file stored on a remote destination as mentioned in #2282.
This fixes #2321
This fixes #1311
2017-02-27 00:03:46 +01:00
Kenneth Skovhede 7f4c9383c3 Merge branch 'feature/set_tempdir_for_sqlite' 2017-01-25 21:16:45 +01:00
Kenneth Skovhede cba12b9d28 Added support for server modules, that is modules that expose options to the user interface 2017-01-25 12:01:01 +01:00
Kenneth Skovhede 1424be05f9 Fixed a bunch of typos.
This fixes #2278.
2017-01-23 22:12:24 +01:00
Kenneth Skovhede 3b4cd3c9c2 Experiment to set the SQLite temp folder, both through the environment variable and the deprecated pragma statement 2017-01-15 23:09:47 +01:00
Kenneth Skovhede 9a849a2b58 Improved support for cross-os restores.
This fixes #1302
This fixes #1983
2017-01-06 23:01:54 +01:00
Max 0e7abf2390 added additional checks 2016-12-04 16:12:57 +01:00
Kenneth Skovhede 59ab08ca9f Merge branch 'feature/fix_delete_backup_files_not_working' 2016-12-03 15:01:33 +01:00
Kenneth Skovhede bff1fbc48b Fixed an issue where the "delete remote files" option was not honored.
This fixes #2147
2016-12-01 23:05:53 +01:00
Kenneth Skovhede 792a8bc834 Added explicit output for the HyperV request and MSSQL requests to return explicitly empty responses on unsupported systems.
This should fix #2136
2016-11-28 13:44:05 +01:00
Kenneth Skovhede aed97d5b4c Fixed an issue with Windows reporting an error if there are no MSSQL instances on the machine 2016-11-09 12:57:35 +01:00
Max 29f9694cf2 fix for 2077 2016-11-02 00:17:49 +01:00
Max a0ee607bf1 REST API for MSSQL backup and changes in Hyper-V 2016-11-02 00:02:34 +01:00
Max 5c7dfcada7 Refactor of hyper-v backup 2016-10-22 23:08:27 +02:00
Max 252497d9fd upstream 2016-10-22 14:51:54 +02:00
Kenneth Skovhede 3880df7e6d Merge branch 'hyperv_ui' of https://github.com/mnaiman/duplicati into mnaiman-hyperv_ui
# Conflicts:
#	Duplicati/Library/Main/Operation/BackupHandler.cs
2016-10-18 13:31:22 +02:00