Commit Graph
6 Commits
Author SHA1 Message Date
JamBalaya56562andClaude Opus 4.8 819a03c09c Harden macOS disk-image eject to fix flaky DiskImage tests
The macOS DiskImage unit tests intermittently failed in CI with:
  System.InvalidOperationException : Process diskutil with arguments
  eject /dev/rdiskN exited with code 1: Volume failed to eject

ReAttach() and CleanupDisk() called `diskutil eject` directly while a
volume could still be busy right after writing, so the eject transiently
failed (e.g. Test_GPT_FAT32_FAT32_FAT32_Async). This is test-infrastructure
only; no product code is affected.

Add a shared EjectDisk() helper that flushes buffers (sync), force-unmounts
all volumes first, then ejects with exponential backoff (reusing
Utility.GetRetryDelay), falling back to a forced `hdiutil detach` of the
image-backed device. Also make Unmount() force-unmount and return on success.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-07-09 22:48:40 +09:00
Carl Johnsen 9a7e6d2c1e Merge branch 'master' into feature/full-disk-ntfs 2026-04-29 14:05:20 +02:00
Kenneth Skovhede c0f40e19ca Updated copyright year to 2026 across the project 2026-04-16 15:21:24 +02:00
Carl Johnsen 8bf92fe57c Made the full round trip tests file be shorter, by having the shared method call operating system specific helpers for whether or not a test should be skipped. 2026-03-25 07:56:33 +01:00
Carl Johnsen 2b5db218ad Post restructure namespace fixes 2026-03-16 11:10:20 +01:00
Carl Johnsen 20ff1c73b1 Restructured Disk Image related files 2026-03-16 11:10:20 +01:00