Commit Graph
2675 Commits
Author SHA1 Message Date
Mikael Mello 1c94decf6c Serialize backup results in JSON format 2018-11-14 08:47:01 -02:00
Rune HenriksenandGitHub e33a145688 Merge pull request #3459 from mnaiman/hyper_v_win_detection
Improved detection Win10 & Win2019Server
2018-10-29 09:03:10 +01:00
Max123456 ec02dbca28 added parentheses 2018-10-29 08:33:53 +01:00
Rune HenriksenandGitHub d42b9938d0 Merge pull request #3462 from warwickmm/bugfix/microsoft_graph_url
Fix URLs in Microsoft Graph backends
2018-10-28 10:50:46 +01:00
Kenneth Hsu a567b467dc Fix slashes in Microsoft Graph URLs.
This fixes an issue introduced in revision f9022fec ("Avoid referencing
virtual members in constructor").

This addresses issue #3460.
2018-10-27 13:03:25 -07:00
Kenneth Hsu 2d7566e909 Fix typo in regex filter pattern.
The extension for these Firefox files should be .sqlite (with one 'l').
2018-10-26 20:00:07 -07:00
MaxandGitHub 0f5fe3ab0f Merge pull request #47 from duplicati/master
upstream
2018-10-27 00:14:17 +02:00
Max123456 8139514366 Improve detection Win10 & Win2019Server 2018-10-26 10:06:53 +02:00
verhoek d932069b99 Fixed incorrect download files string. 2018-10-24 09:40:16 +02:00
verhoek 0752e0af0d Moved content api strings to webapi. 2018-10-23 16:21:36 +02:00
verhoek 1db6504dea Replaced paths in formatted strings to inner class. 2018-10-23 16:02:14 +02:00
verhoek 630f810cdd Added listfiles url to dropbox's webapi. 2018-10-23 15:46:35 +02:00
verhoek ab86df2ebb Merge branch 'master' into webapi/dropbox 2018-10-23 15:34:00 +02:00
Kenneth Hsu 18cb3ade80 Seal method to avoid potential reference to uninitialized members.
The constructor calls the Position property's setter.  To avoid
potential references to uninitialized members, we disallow a subclass
from overriding the implementation.
2018-10-18 21:11:50 -07:00
Rune HenriksenandGitHub 0b3efc5dbb Merge pull request #3439 from warwickmm/constructor_virtual_members
Avoid referencing virtual members in Basiclist constructor
2018-10-18 17:02:29 +02:00
Kenneth Hsu 6f231f9190 Avoid referencing virtual members in Basiclist constructor.
When referencing virtual members in a constructor, the behavior may be
ill-defined as the overridden implementation may depend on uninitialized
instance members.

Since the TABLE_PREFIX, TABLEFORMAT, INSERTCOMMAND, and INSERTARGUMENTS
properties were only referenced in the Basiclist constructor, we can
remove the abstract keyword and provide the values as constructor
parameters.
2018-10-17 20:11:06 -07:00
Kenneth Skovhede 68d2f10475 Merge branch 'master' of github.com:duplicati/duplicati 2018-10-17 14:37:52 +02:00
Kenneth Skovhede 2826dbe6f0 Improved error message for faults in database filelists 2018-10-17 14:37:23 +02:00
Kenneth Skovhede d03a8a759f Spelling fix 2018-10-17 14:36:54 +02:00
Rune HenriksenandGitHub 6c47c39f2b Merge pull request #3431 from warwickmm/remove_unused_members
Remove unused class members
2018-10-17 00:40:11 +02:00
Rune HenriksenandGitHub a00d2ad624 Merge pull request #3435 from gzzengwei/issue_3430_add_us_west_for_wasabi
#3430 add US-West support for wasabi
2018-10-17 00:39:14 +02:00
Kenneth Hsu 9e0b031fee Remove unused members. 2018-10-15 21:20:30 -07:00
Kenneth Hsu e16ab43d86 Fix typo in log message id. 2018-10-15 21:14:59 -07:00
Wei Zeng 0abc0dad99 #3430 add US-West support for wasabi 2018-10-16 15:09:43 +11:00
Rune HenriksenandGitHub d86c6cce61 Merge pull request #3424 from warwickmm/flatten_aggregate_exceptions
Flatten AggregateExceptions before referencing InnerException
2018-10-14 12:21:12 +02:00
Rune HenriksenandGitHub a485730bf8 Merge pull request #3425 from warwickmm/remove_partial_keyword
Remove unnecessary use of partial keyword
2018-10-14 12:19:34 +02:00
Kenneth Hsu 9374d6b208 Move comments and remove invalid XML tags.
The comment was not placed before a valid language element.
2018-10-13 20:52:30 -07:00
Kenneth Hsu 914b35e342 Escape characters in XML documentation. 2018-10-13 20:52:15 -07:00
Kenneth Hsu 6b8dc6e8b8 Rename parameter to match XML documentation.
The use of camel case is also more consistent with the surrounding
style.
2018-10-13 20:45:13 -07:00
Kenneth Hsu 22d5328e75 Remove extra XML documentation tag. 2018-10-13 20:43:38 -07:00
Kenneth Hsu 1d57ddd5a6 Flatten AggregateExceptions before referencing InnerException.
The InnerException property of an AggregateException can be another
AggregateException.  By calling Flatten(), we remove inner
AggregateExceptions so that the InnerExceptions property contains all
the original exceptions.  The InnerException property is the first
element of InnerExceptions.
2018-10-13 19:07:49 -07:00
Kenneth Hsu beb552fa9e Remove unnecessary use of partial keyword.
These classes are defined in a single location.
2018-10-13 16:53:28 -07:00
Kenneth Hsu 05d8fd425e Add comments to explain empty methods. 2018-10-10 21:28:00 -07:00
Kenneth Hsu 07c1d85b4a Remove empty statements. 2018-10-10 21:22:31 -07:00
Kenneth Hsu 731a8b1644 Remove unused empty methods. 2018-10-10 21:20:40 -07:00
Kenneth Hsu 8bb770964d Constrain generic type to be a class to allow for null comparison.
The SendRequest method performs a comparison between an object of type T
and null.  While there are no use cases currently where the generic type
is a value type, we should constrain the generic type to be a class so
that the comparison remains meaningful.
2018-10-08 19:13:23 -07:00
Kenneth Hsu 6c08f44394 Revert "Avoid potential comparison of value type with null."
This reverts commit ecb670a2d9.

While there aren't any cases where the generic type is a struct, the
comparison with default(T) is incorrect.  If T is int, we wouldn't want
the behavior to differ based on whether the value was zero or nonzero.
2018-10-08 18:54:36 -07:00
Rune HenriksenandGitHub aa1f99628c Merge pull request #3414 from warwickmm/avoid_value_null_comparison
Avoid potential comparison of value type with null
2018-10-07 22:35:25 +02:00
Rune HenriksenandGitHub 6c662a0d8b Merge pull request #3412 from mnaiman/normalize_path
all drives letter uppercase
2018-10-07 19:07:52 +02:00
Rune HenriksenandGitHub be7edb580d Merge pull request #3410 from warwickmm/simplify_enumerating_collections
Simplify enumeration of collections
2018-10-07 19:06:28 +02:00
Kenneth Hsu ecb670a2d9 Avoid potential comparison of value type with null.
While there aren't currently any cases where the generic type is a value
type, this will make the code slightly more robust to future
implementations.
2018-10-07 09:59:13 -07:00
Rune HenriksenandGitHub dc5a0dbc94 Merge pull request #3409 from warwickmm/remove_unused_parameters
Remove unused method parameters
2018-10-07 18:56:43 +02:00
Max123456 73d7aaffdc Invariant Upper 2018-10-07 11:47:48 +02:00
Max123456 0c71f0af2c all drives letter uppercase 2018-10-07 11:32:25 +02:00
Kenneth Hsu b824c86c7e Avoid unnecessary enumeration of collections.
This improves performance by using Any() to avoid unnecessary
enumeration of collections.
2018-10-06 16:20:18 -07:00
Kenneth Hsu 0c1ac9c489 Replace chained LINQ calls with call to overload with predicate.
This simplifies the code by reducing the number of enumerators created
while also making the code slightly more readable.
2018-10-06 16:20:18 -07:00
Kenneth Hsu d72128ec83 Remove unused method parameters. 2018-10-06 15:09:43 -07:00
Rune Henriksen 306ccabfef updated MegaApiClient from 1.6.0 to 1.6.3 2018-10-04 00:34:49 +02:00
Kenneth Hsu e2bc85c7e4 Merge remote-tracking branch 'upstream/master' into constructor_virtual_members
Resolved Conflicts:
	Duplicati/Library/Backend/OneDrive/MicrosoftGraphBackend.cs
2018-10-01 17:15:58 -07:00
Rune HenriksenandGitHub 5f4236cbc2 Merge pull request #3399 from duplicati/remove_unused_variables_assignments
Remove unused variables, fields, and unnecessary assignments
2018-10-01 23:19:37 +02:00