haeaeae/duplicati
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
5,897 Commits 140 Branches 416 Tags
73f2aa00a2a235a76238cdd7c43fb0f5091c78cf
Commit Graph
651 Commits
Author SHA1 Message Date
Kenneth Hsu a567b467dc Fix slashes in Microsoft Graph URLs. 
This fixes an issue introduced in revision f9022fec ("Avoid referencing
virtual members in constructor").

This addresses issue #3460.
 2018-10-27 13:03:25 -07:00
verhoek d932069b99 Fixed incorrect download files string. 2018-10-24 09:40:16 +02:00
verhoek 0752e0af0d Moved content api strings to webapi. 2018-10-23 16:21:36 +02:00
verhoek 1db6504dea Replaced paths in formatted strings to inner class. 2018-10-23 16:02:14 +02:00
verhoek 630f810cdd Added listfiles url to dropbox's webapi. 2018-10-23 15:46:35 +02:00
verhoek ab86df2ebb Merge branch 'master' into webapi/dropbox 2018-10-23 15:34:00 +02:00
Rune HenriksenandGitHub 6c47c39f2b Merge pull request #3431 from warwickmm/remove_unused_members 
Remove unused class members
 2018-10-17 00:40:11 +02:00
Kenneth Hsu 9e0b031fee Remove unused members. 2018-10-15 21:20:30 -07:00
Wei Zeng 0abc0dad99 #3430 add US-West support for wasabi 2018-10-16 15:09:43 +11:00
Kenneth Hsu 9374d6b208 Move comments and remove invalid XML tags. 
The comment was not placed before a valid language element.
 2018-10-13 20:52:30 -07:00
Kenneth Hsu 914b35e342 Escape characters in XML documentation. 2018-10-13 20:52:15 -07:00
Kenneth Hsu 07c1d85b4a Remove empty statements. 2018-10-10 21:22:31 -07:00
Kenneth Hsu 8bb770964d Constrain generic type to be a class to allow for null comparison. 
The SendRequest method performs a comparison between an object of type T
and null.  While there are no use cases currently where the generic type
is a value type, we should constrain the generic type to be a class so
that the comparison remains meaningful.
 2018-10-08 19:13:23 -07:00
Kenneth Hsu 6c08f44394 Revert "Avoid potential comparison of value type with null." 
This reverts commit ecb670a2d9.

While there aren't any cases where the generic type is a struct, the
comparison with default(T) is incorrect.  If T is int, we wouldn't want
the behavior to differ based on whether the value was zero or nonzero.
 2018-10-08 18:54:36 -07:00
Rune HenriksenandGitHub aa1f99628c Merge pull request #3414 from warwickmm/avoid_value_null_comparison 
Avoid potential comparison of value type with null
 2018-10-07 22:35:25 +02:00
Rune HenriksenandGitHub be7edb580d Merge pull request #3410 from warwickmm/simplify_enumerating_collections 
Simplify enumeration of collections
 2018-10-07 19:06:28 +02:00
Kenneth Hsu ecb670a2d9 Avoid potential comparison of value type with null. 
While there aren't currently any cases where the generic type is a value
type, this will make the code slightly more robust to future
implementations.
 2018-10-07 09:59:13 -07:00
Kenneth Hsu 0c1ac9c489 Replace chained LINQ calls with call to overload with predicate. 
This simplifies the code by reducing the number of enumerators created
while also making the code slightly more readable.
 2018-10-06 16:20:18 -07:00
Rune Henriksen 306ccabfef updated MegaApiClient from 1.6.0 to 1.6.3 2018-10-04 00:34:49 +02:00
Kenneth Hsu e2bc85c7e4 Merge remote-tracking branch 'upstream/master' into constructor_virtual_members 
Resolved Conflicts:
	Duplicati/Library/Backend/OneDrive/MicrosoftGraphBackend.cs
 2018-10-01 17:15:58 -07:00
Rune HenriksenandGitHub 5f4236cbc2 Merge pull request #3399 from duplicati/remove_unused_variables_assignments 
Remove unused variables, fields, and unnecessary assignments
 2018-10-01 23:19:37 +02:00
Kenneth Hsu 024bc5bea2 Mark immutable field as readonly. 2018-09-30 15:45:42 -07:00
Kenneth Hsu ee14862db5 Add comment to clarify use of Lazy. 2018-09-30 15:06:55 -07:00
Kenneth Hsu f59607d94d Rename property. 2018-09-30 15:06:55 -07:00
Kenneth Hsu f9022fec66 Avoid referencing virtual members in constructor. 
Since the call to GetRootPathFromUrl may be expensive, we cache the
value using a lazy initializer.
 2018-09-30 15:06:49 -07:00
Kenneth Hsu 7cf830cad7 Provide protocol key to MicrosoftGraphBackend constructor. 
This will help us avoid referencing virtual members in the constructor.
 2018-09-30 10:59:26 -07:00
Kenneth Hsu 6215fe1ac5 Extract string to private constant. 
This will allow us to provide the string as a parameter to the parent
class constructor to avoid referencing virtual members in the
constructor.
 2018-09-30 10:56:59 -07:00
Kenneth Hsu 183ae4ede2 Remove additional unused variables. 2018-09-29 12:49:22 -07:00
Kenneth Hsu 9ce1e807c7 Remove unused variables and fields. 2018-09-29 10:41:27 -07:00
Kenneth Hsu 44b7c29489 Rename local variable to avoid hiding class field. 2018-09-28 20:57:44 -07:00
Kenneth SkovhedeandGitHub 0ec49d3a87 Merge pull request #3393 from warwickmm/fix_append_dir_separator 
Fix behavior of AppendDirSeparator utility method
 2018-09-28 22:24:11 +02:00
Kenneth SkovhedeandGitHub f24bce8e14 Merge pull request #3392 from warwickmm/simplify_method_resolution 
Simplify method resolution by removing default parameters
 2018-09-28 22:21:29 +02:00
Kenneth Hsu d4d1945faf Use utility method to append trailing slash. 
This removes some duplicated code.
 2018-09-22 10:19:45 -07:00
Kenneth Hsu 18aae7a5c4 Simplify method resolution by removing default parameters. 
The previous implementations resulted in an overload being hidden by one
without a default parameter, making it unclear which method was being
called.  For example, consider the following signatures:

public MultipartItem(string content, string contenttype = null, string name = null, string filename = null)
public MultipartItem(string contenttype, string name = null, string filename = null)

From https://docs.microsoft.com/en-us/dotnet/csharp/programming-guide/classes-and-structs/named-and-optional-arguments,

> If two candidates are judged to be equally good, preference goes to a
> candidate that does not have optional parameters for which arguments
> were omitted in the call. This is a consequence of a general preference
> in overload resolution for candidates that have fewer parameters.
 2018-09-20 19:30:49 -07:00
Kenneth Hsu 0d23302220 Use ordinal case-insensitive comparison instead of ToLower. 2018-09-19 15:21:59 -07:00
Kenneth Hsu eea479e056 Fix URL for Google Cloud Storage backend. 
This fixes an issue where Google Cloud Storage users encountered the
following exception:

System.Net.WebException: The remote server returned an error: (404) Not Found.

The refactoring in revision 18de687530 ("Updated Put and Createfolder
using WebApi") omitted the "/o" in the endpoint for object uploads.

This addresses issue #3328.
 2018-08-24 22:31:05 -07:00
Kenneth Skovhede c4b564358c Spelling fixes 2018-08-12 22:33:21 +02:00
Kenneth SkovhedeandGitHub d96043007c Merge pull request #3317 from verhoek/refactoring/ftp 
Refactoring/ftp
 2018-08-02 09:55:38 +02:00
verhoek dafee2b455 Removed unwanted character in setting passive mode. 2018-07-17 21:35:55 +02:00
verhoek 2e4a395402 Braces. 2018-06-28 23:18:18 +02:00
verhoek 470b83c416 Remove lambda. 2018-06-28 23:16:28 +02:00
verhoek 2bcc372d0a Simplified passivemode setting. 2018-06-28 23:10:35 +02:00
verhoek 65b3df52f2 Tidying up. 2018-06-28 21:07:23 +02:00
Kenneth Skovhede 31656b4eb3 Merge branch 'feature/repair_console_output' 2018-06-28 12:18:48 +02:00
Kenneth SkovhedeandGitHub 4b9c0ab9a2 Merge pull request #3289 from warwickmm/configure_await_false 
Allow tasks to complete on any thread when context is irrelevant
 2018-06-26 12:05:27 +02:00
Kenneth SkovhedeandGitHub 497daa5450 Merge pull request #3285 from snamds/VerifyRemoteList 
Amazon cloud drive delay problems (amzcd-consistency-delay)
 2018-06-26 12:01:55 +02:00
fgonzalez 74cd646fa6 Codacy changes 2018-06-25 09:08:15 +02:00
verhoek f1088b8080 Factored out createfolder. 2018-06-23 19:58:56 +02:00
verhoek d114b26ade Fix name issue. 2018-06-23 19:45:11 +02:00
verhoek ad5ae922f7 Unnecessary imports removed. 2018-06-23 19:44:16 +02:00