Mikael Mello
1c94decf6c
Serialize backup results in JSON format
2018-11-14 08:47:01 -02:00
Rune Henriksen and GitHub
0b3efc5dbb
Merge pull request #3439 from warwickmm/constructor_virtual_members
...
Avoid referencing virtual members in Basiclist constructor
2018-10-18 17:02:29 +02:00
Kenneth Hsu
6f231f9190
Avoid referencing virtual members in Basiclist constructor.
...
When referencing virtual members in a constructor, the behavior may be
ill-defined as the overridden implementation may depend on uninitialized
instance members.
Since the TABLE_PREFIX, TABLEFORMAT, INSERTCOMMAND, and INSERTARGUMENTS
properties were only referenced in the Basiclist constructor, we can
remove the abstract keyword and provide the values as constructor
parameters.
2018-10-17 20:11:06 -07:00
Kenneth Skovhede
68d2f10475
Merge branch 'master' of github.com:duplicati/duplicati
2018-10-17 14:37:52 +02:00
Kenneth Skovhede
2826dbe6f0
Improved error message for faults in database filelists
2018-10-17 14:37:23 +02:00
Kenneth Skovhede
d03a8a759f
Spelling fix
2018-10-17 14:36:54 +02:00
Rune Henriksen and GitHub
6c47c39f2b
Merge pull request #3431 from warwickmm/remove_unused_members
...
Remove unused class members
2018-10-17 00:40:11 +02:00
Kenneth Hsu
9e0b031fee
Remove unused members.
2018-10-15 21:20:30 -07:00
Kenneth Hsu
e16ab43d86
Fix typo in log message id.
2018-10-15 21:14:59 -07:00
Rune Henriksen and GitHub
d86c6cce61
Merge pull request #3424 from warwickmm/flatten_aggregate_exceptions
...
Flatten AggregateExceptions before referencing InnerException
2018-10-14 12:21:12 +02:00
Kenneth Hsu
1d57ddd5a6
Flatten AggregateExceptions before referencing InnerException.
...
The InnerException property of an AggregateException can be another
AggregateException. By calling Flatten(), we remove inner
AggregateExceptions so that the InnerExceptions property contains all
the original exceptions. The InnerException property is the first
element of InnerExceptions.
2018-10-13 19:07:49 -07:00
Kenneth Hsu
beb552fa9e
Remove unnecessary use of partial keyword.
...
These classes are defined in a single location.
2018-10-13 16:53:28 -07:00
Kenneth Hsu
07c1d85b4a
Remove empty statements.
2018-10-10 21:22:31 -07:00
Kenneth Hsu
731a8b1644
Remove unused empty methods.
2018-10-10 21:20:40 -07:00
Rune Henriksen and GitHub
be7edb580d
Merge pull request #3410 from warwickmm/simplify_enumerating_collections
...
Simplify enumeration of collections
2018-10-07 19:06:28 +02:00
Kenneth Hsu
b824c86c7e
Avoid unnecessary enumeration of collections.
...
This improves performance by using Any() to avoid unnecessary
enumeration of collections.
2018-10-06 16:20:18 -07:00
Kenneth Hsu
0c1ac9c489
Replace chained LINQ calls with call to overload with predicate.
...
This simplifies the code by reducing the number of enumerators created
while also making the code slightly more readable.
2018-10-06 16:20:18 -07:00
Kenneth Hsu
d72128ec83
Remove unused method parameters.
2018-10-06 15:09:43 -07:00
Kenneth Hsu
183ae4ede2
Remove additional unused variables.
2018-09-29 12:49:22 -07:00
Kenneth Hsu
8902da39f2
Undo removal of method parameters.
...
This should be done on a separate branch for a different pull request.
2018-09-29 10:44:05 -07:00
Kenneth Hsu
93304f0506
Add comment regarding removed code.
2018-09-29 10:44:05 -07:00
Kenneth Hsu
9ce1e807c7
Remove unused variables and fields.
2018-09-29 10:41:27 -07:00
Kenneth Hsu
f4f676a1de
Remove unnecessary variable assignment.
...
These variables are assigned values that are never read by any
subsequent instruction.
2018-09-28 20:13:45 -07:00
Kenneth Skovhede and GitHub
772d15bfd7
Merge pull request #3390 from warwickmm/configure_await_false
...
Allow tasks to complete on any thread when context is irrelevant
2018-09-28 22:15:51 +02:00
Kenneth Hsu
1c8bb276b4
Allow tasks to complete on any thread when context is irrelevant.
...
When the code following the await can be executed on any thread, it's
recommended to use ConfigureAwait(false) to avoid unnecessary context
switching and potential deadlocks.
2018-09-19 16:57:17 -07:00
Kenneth Hsu
0d23302220
Use ordinal case-insensitive comparison instead of ToLower.
2018-09-19 15:21:59 -07:00
Kenneth Skovhede and GitHub
01c3e52f68
Merge pull request #3368 from LacunaSoftware/progressBar
...
Fix progress bar not updating size and number of files processed
2018-09-15 00:27:05 +02:00
Mikael Mello and GitHub
072f98ffe8
Fix wrong file size being added to the total
2018-09-08 11:21:46 -03:00
Kenneth Skovhede
b4a031f6a8
Added consistency check to the test/verify command
2018-09-08 11:54:29 +02:00
Mikael Mello
d9445f7aaf
Fix progress bar not updating size and number of files processed
2018-09-05 17:18:44 -03:00
Kenneth Skovhede
e0eaf33514
Merge branch 'master' of github.com:duplicati/duplicati
2018-09-05 11:21:08 +02:00
Kenneth Skovhede
809ba9a856
Changed the default query to be v==2, as multiple users reported this to be fastest.
...
The previous default query is now v==4.
Added an additional v==3, and a `LIMIT 1` clause to v==4 as suggested here:
https://forum.duplicati.com/t/release-2-0-3-10-canary-2018-08-30/4497/25
2018-09-05 10:12:28 +02:00
Kenneth Hsu
51cfb3d4c5
Fix reference to renamed method.
...
This was renamed in revision 6c38651f ("Rename methods to clarify their
synchronous behavior").
2018-09-04 17:39:03 -07:00
Rune Henriksen and GitHub
b8e53cc839
Merge branch 'master' into remove_unnecessary_async
2018-09-04 21:27:11 +02:00
Rune Henriksen and GitHub
866b72ac8b
Merge pull request #3355 from ravisorg/patch-1
...
Added some missing image formats
2018-09-04 21:21:37 +02:00
Rune Henriksen and GitHub
ce618ea888
Added comment to clarify odd naming convention
...
Added a comment to clarify that the Canon RAW image format is actually not RAW since it's basically just TIFF and lossless Jpeg compression in a different wrapper.
https://github.com/lclevy/libcraw2/blob/master/docs/cr2_lossless.pdf
https://github.com/lclevy/libcraw2/blob/master/docs/cr2_poster.pdf
2018-09-04 20:25:29 +02:00
ravisorg and GitHub
b8f9041764
Added some missing image formats
...
NEF, ARW, and HEIC
2018-08-31 12:49:44 -04:00
Kenneth Skovhede
22ab344e67
Merge branch 'feature/improved-exit-code-handling'
2018-08-15 12:11:21 +02:00
Kenneth Skovhede
416ab41ee6
Merge branch 'feature/disable-filelist-consistency-checks'
2018-08-15 08:17:23 +02:00
Kenneth Skovhede
ca1872ce57
Added an option to disable filelist consistency checks as it was reported to slow backups with a large number of filesets.
...
This addresses #3194
2018-08-14 15:21:54 +02:00
Kenneth Skovhede
5e130fa4b7
Converted exceptions while adding an unmodified file to the database to a log message to avoid stopping the backup when this errors out.
2018-08-14 11:42:38 +02:00
Kenneth Skovhede
494fccd931
Added support for multiple exit codes, and added a unittest to verify that the exit codes are handled correctly
2018-08-14 11:09:16 +02:00
Kenneth Skovhede
d0026d8028
Reworked the file-path query, and enabled experimentally changing it by setting the environment variable TEST_QUERY_VERSION=1 or TEST_QUERY_VERSION=2.
...
Added check to the unittests to catch cases where it scans too many files.
2018-08-13 13:23:59 +02:00
Kenneth Skovhede
4d1bea86a6
Attempt at making a leaner version of getting the previous file's information
2018-08-11 14:39:03 +02:00
Kenneth Skovhede
5507496352
Fixed the query to correctly extract metadata for a file, using the Metadataset indirection
2018-08-11 14:37:23 +02:00
Kenneth Skovhede
52cb9fb1f9
Removed the deprecated --store-metadata option.
...
Rewrote the logic for pre-filtering files based on timestamps/metadata to be more verbose and well documented.
Fixed an issue where `--check-filetime-only` also checked the file size, which was not present due to the reduced query used to grab only the lastmodified information.
Fixed a problem where the check for existing metadata was wrong and produced a warning.
This fixes #3204
This handles some of #3194
2018-08-11 11:48:19 +02:00
Kenneth Skovhede
1de08c1917
Merge branch 'feature/improve_size_multiplier_handling'
2018-08-09 09:14:49 +02:00
Kenneth Skovhede
07815c1751
Added warning to unqualified size options
2018-08-08 11:58:35 +02:00
Kenneth Skovhede and GitHub
64201ae706
Merge pull request #3314 from mnaiman/log_sql_variables
...
Log sql variables
2018-08-07 23:32:27 +02:00
Kenneth Skovhede
5a3adc390c
Merge branch 'feature/fix_file_counter'
2018-08-07 23:31:19 +02:00