Commit Graph
394 Commits
Author SHA1 Message Date
Kenneth Hsu 2d7566e909 Fix typo in regex filter pattern.
The extension for these Firefox files should be .sqlite (with one 'l').
2018-10-26 20:00:07 -07:00
Kenneth Hsu 9e0b031fee Remove unused members. 2018-10-15 21:20:30 -07:00
Kenneth Hsu 6b8dc6e8b8 Rename parameter to match XML documentation.
The use of camel case is also more consistent with the surrounding
style.
2018-10-13 20:45:13 -07:00
Kenneth Hsu d72128ec83 Remove unused method parameters. 2018-10-06 15:09:43 -07:00
Kenneth Hsu 8902da39f2 Undo removal of method parameters.
This should be done on a separate branch for a different pull request.
2018-09-29 10:44:05 -07:00
Kenneth Hsu 9ce1e807c7 Remove unused variables and fields. 2018-09-29 10:41:27 -07:00
Kenneth SkovhedeandGitHub 7330aebaeb Merge pull request #3394 from warwickmm/remove_unnecessary_indirection
Use built-in method to expand environment variables
2018-09-28 22:25:46 +02:00
Kenneth Hsu d4692e2d35 Use built-in method to expand environment variables.
After we removed the tilde expansion in revision c9aa6cf5fb ("Avoid
performing tilde expansion"), the Utility.ExpandEnvironmentVariables
method simply called System.Environment.ExpandEnvironmentVariables.  We
can simplify the code by just referencing the built-in method directly.
2018-09-22 19:59:46 -07:00
Kenneth Hsu a325a8e0e7 Fix XML documentation to more accurately reflect behavior. 2018-09-22 10:19:45 -07:00
Kenneth Hsu 67871a76ed Fix bug. Append separator when string ends with same separator.
Previously, the replacement would occur if the provided string did not
end with the platform-dependent directory separator.  However, this
utility method is often used to append a trailing slash to URL
specifiers.
2018-09-22 10:19:45 -07:00
Kenneth Hsu 0d23302220 Use ordinal case-insensitive comparison instead of ToLower. 2018-09-19 15:21:59 -07:00
Kenneth Hsu b45c41026e Use ordinal file path comparisons.
This addresses issue #3342.
2018-08-30 21:52:02 -07:00
Kenneth SkovhedeandGitHub 05059e3859 Merge pull request #3329 from warwickmm/refactor/remove_unused_utilities
Remove unused members from Utility class
2018-08-29 11:27:33 +02:00
Kenneth Skovhede 2ec203cabe Removed Task types and the TaskReader property from serialized results, as they have no usable serialized format 2018-08-08 11:59:20 +02:00
Kenneth Hsu 6b521691ce Remove unused ENVIRONMENT_VARIABLE_MATCHER_LINUX property.
This was added in revision 0b442ecdc6, but no usages could be found.  A
potential use-case is mentioned in a comment, so the implementation was
moved to the comment.
2018-08-02 21:40:51 -07:00
Kenneth Hsu 79f143e84a Remove unused ToUnixTimestamp utility method.
This was added in revision 6255572c25 ("Added a timestamp value to the
end of dates in the report output for easier parsing"), but no usages
could be found.
2018-08-02 21:36:32 -07:00
Kenneth Hsu f2b682e94f Remove unused Base64UrlDecode utility method.
This was added in revision aca4ed95cc ("More work on the block hash"),
but no usages could be found.
2018-08-02 21:36:32 -07:00
Kenneth Hsu a1a4bd8b90 Remove unused ReplaceFile utility method.
This was added in revision a0521da54d ("Initial version of the new
block-based storage format"), but no usages could be found.
2018-08-02 21:36:29 -07:00
Kenneth Hsu da3cf6d2b3 Remove unused DefaultCulture utility property.
Usages were removed in revision 2264c07f3b ("Removed unused files").
2018-08-02 21:36:25 -07:00
Kenneth Hsu 70b0d093fe Remove unused CalculateHash utility method.
Usages were removed in revision 3ff2f1eb98.
2018-08-02 21:36:20 -07:00
Kenneth Hsu c3cda5dc58 Remove unused IsValidHostname utility method.
Usages were removed in revision 62c75d9af9 ("Removed all informs code
(no more 1.3.x UI)").
2018-08-02 21:29:09 -07:00
Kenneth Hsu c7f4bcd0d3 Remove unused LocateFileInSystemPath utility method.
Usages were removed in revision 62c75d9af9 ("Removed all informs code
(no more 1.3.x UI)").
2018-08-02 21:27:25 -07:00
Kenneth Hsu 54c4f9224d Allow tasks to complete on any thread when context is irrelevant.
When the code following the await can be executed on any thread, it's
recommended to use ConfigureAwait(false) to avoid unnecessary context
switching and potential deadlocks.
2018-06-21 19:28:27 -07:00
Kenneth SkovhedeandGitHub db1bf986be Merge pull request #3267 from verhoek/fix/subprocess_readkey
Fix - Console.ReadKey for encryption passphrase
2018-06-15 09:10:54 +02:00
Kenneth SkovhedeandGitHub dceb5bfb43 Merge pull request #3263 from verhoek/webapi/googlecloudstorage
Webapi refactoring - google cloud storage
2018-06-14 10:23:36 +02:00
verhoek 07ae90f325 Simplified plus made defaults explicit. 2018-06-12 09:41:40 +02:00
verhoek a850ed8f26 Removed inheritance in favor of separation of googledrive / cloud storage api. 2018-06-11 10:19:03 +02:00
verhoek 441d893a49 Changes to make codacy happier. 2018-06-09 14:19:18 +02:00
verhoek 7b5779ca5d Merge remote-tracking branch 'origin' into webapi/googlecloudstorage
# Conflicts:
#	Duplicati/Library/Backend/GoogleServices/GCSConfig.cs (line endings)
#	Duplicati/Library/Backend/GoogleServices/GoogleCloudStorage.cs (readonly)
2018-06-09 08:49:23 +02:00
Kenneth Skovhede d01e8f19c4 Fixed an issue after the merge conflict ... 2018-06-08 11:21:43 +02:00
Kenneth Skovhede 9485339659 Fixed an issue after the merge conflict 2018-06-08 11:20:03 +02:00
Kenneth Skovhede bce1db123a Merge branch 'master' into feature/speedup_backup_index_files
# Conflicts:
#	Duplicati/Library/Utility/Utility.cs
2018-06-08 10:31:27 +02:00
verhoek 3fb7175931 Merge remote-tracking branch 'origin/master' into feature/tempdir
# Conflicts:
#	Duplicati/Server/Runner.cs (copied readonly prop)
2018-06-07 16:37:40 +02:00
Kenneth Hsu 1605dc8ede Use utility method to read from stream. 2018-06-06 19:54:45 -07:00
verhoek 4a0d6a2f5b Inline var declaration. 2018-05-27 13:12:59 +02:00
verhoek 6287d369b1 Reverted accidental removing of static for SystemContextSettings. 2018-05-27 13:12:06 +02:00
verhoek 625db54f14 Throw proper exception. Removed unused imports. 2018-05-27 13:10:01 +02:00
verhoek a9b88ab2ab Return default settings in case no startcontext was previously called
by returning a null contextid.
2018-05-27 10:23:22 +02:00
verhoek a108e328b6 Fix codacy issues. 2018-05-26 23:27:39 +02:00
verhoek e80f30f8a9 Added multiple context setting keys to callcontextsettings, exploiting
reflection. Contextsettings don't destroy each other anymore.
2018-05-26 21:56:15 +02:00
Kenneth Hsu f12858e6a5 Mark fields that shouldn't be reassigned as readonly.
This makes it explicit at compile-time that these fields should not be
reassigned outside the constructor.
2018-05-25 10:04:52 -07:00
verhoek bbf5d71782 Merge branch 'master' into webapi/googlecloudstorage 2018-05-23 20:14:06 +02:00
verhoek 7556c3fa63 Merge branch 'master' into feature/tempdir 2018-05-23 20:13:48 +02:00
Kenneth SkovhedeandGitHub 19851c88f0 Merge pull request #3227 from warwickmm/use_string_builder
Replace string concatenation with StringBuilder
2018-05-23 11:10:36 +02:00
verhoek 7bf1768f80 Implemented default tempdir for backend server. 2018-05-22 21:51:29 +02:00
Kenneth Hsu 0b016cea2c Replace string concatenation with StringBuilder.
When appending to a string in a loop, using a StringBuilder should in
general yield better performance.
2018-05-19 15:36:00 -07:00
verhoek 41234a314d Introduced UrlPath wrapper for stringbuilder to ease concatenation of multiple paths.
Started cleaning googlecloud services API.
2018-05-18 22:55:09 +02:00
verhoek 2f41e02ca9 Merge branch 'master' into refactored 2018-05-18 08:05:19 +02:00
verhoek 8a4031f66b Added skipped file in comparison spelling correction commit. 2018-05-16 20:24:31 +02:00
verhoek 143725c0b9 Removed some duplication. 2018-05-16 20:10:06 +02:00