Commit Graph
10149 Commits
Author SHA1 Message Date
Kenneth Hsu 780f53b89a Add test for purging broken files with dry-run.
This concerns #4379.
2020-11-30 19:56:08 -08:00
Kenneth Hsu 9952babf0b Commit or rollback transaction before beginning new ones.
The PurgeFilesHandler begins new transactions using the same database
connection.  During a dry-run, these transactions are rolled back, and a
subsequent attempt to rollback in the PurgeBrokenFilesHandler then
resulted in an exception.

To avoid this, we perform the rollback in the PurgeBrokenFilesHandler as
soon as we can.

I'm not entirely confident that this is the correct fix, but it appears
to resolve issue #4379.

This fixes #4379.
2020-11-30 19:55:20 -08:00
warwickmmandGitHub 7d958adb8a Merge pull request #4372 from apreiml/master
Improve wording of the remote volume size description
2020-11-26 09:17:23 -08:00
warwickmmandGitHub 1c3065aa81 Merge pull request #4336 from barfoo4711/master
Add logging statements for issues encountered when restoring empty files.
2020-11-22 10:23:06 -08:00
Kenneth Hsu 47270d1979 Change log level for entry regarding restoring empty files.
Restoring empty files is expected to be quick, so profiling is not
necessary.
2020-11-22 09:05:25 -08:00
Kenneth Hsu 8b010888e2 Make log entries for restore errors consistent.
This concerns #4315.
2020-11-22 09:05:25 -08:00
Kenneth Hsu 31a4eab7e7 Fix casing in log entry. 2020-11-22 09:05:25 -08:00
Kenneth Hsu 5951047ff1 Fix incorrect or misleading indentations.
This also adds braces to clarify scope where beneficial.
2020-11-21 13:58:16 -08:00
Kenneth Hsu 6876d765b0 Remove unreachable code. 2020-11-21 13:41:57 -08:00
Armin Preiml 3953c635ab better description fo the Remote Volume Size description 2020-11-20 13:57:07 +01:00
Armin Preiml cc23ed2c4b remove executable flag from addoredit.html 2020-11-20 13:54:36 +01:00
Kenneth Hsu 1e2e0f8763 Improve notification title message to indicate warning or error. 2020-11-15 15:44:26 -08:00
Kenneth Hsu 560c995763 Improve some error and warning notification messages.
While this is more verbose and contains some elements that aren't
relevant to the user (e.g., class namespaces), it is arguably more
useful than just seeing "Got 1 warning(s)".
2020-11-15 15:30:14 -08:00
Kenneth Hsu 61056dd14c Clean up indentation and formatting. 2020-11-15 15:11:01 -08:00
Kenneth Hsu 20e599586a Fix typo in variable name. 2020-11-15 12:23:46 -08:00
Kenneth Hsu 14de767738 Fix misleading error message about missing source path.
The source path can be a file, so the error message should not assume
that the path represents a folder.  This also provides the user with
some hints on what steps should be taken to address the issue.

This fixes #3522.
2020-11-15 12:21:05 -08:00
warwickmmandGitHub 7d1d256315 Merge pull request #4360 from martikyan/telegram-double-account-fix
Fix issue with Telegram backend and multiple accounts.
2020-11-12 16:25:09 -08:00
Karen Martikyan 0f138a1cfb default literal fix for build check pass 2020-11-09 22:11:10 +04:00
Karen Martikyan 74ec1e078f Fixed problems while using few different accounts for storing files. 2020-11-09 22:05:43 +04:00
Karen Martikyan 39fb3bdbae Merge branch 'master' of https://github.com/martikyan/duplicati 2020-11-09 20:42:59 +04:00
warwickmmandGitHub c7f9f8f556 Merge pull request #4324 from martikyan/feature/telegram_backend
Add support for Telegram channels as a backend destination.
2020-11-08 17:59:37 -08:00
Karen Martikyan 812d698aba Removed SystemExtensions.cs, using Utility.Utility 2020-11-09 00:28:10 +04:00
Karen Martikyan 1feb75002d Fixed bug connected with finding minimal element in an empty list 2020-11-09 00:16:00 +04:00
Karen Martikyan e1b2a190ad Retrieval of epoch moved to extensions 2020-11-08 23:27:29 +04:00
Karen Martikyan 1bc6e20a57 Fixed possible bug connected with retrieval more than 100 messages from a channel 2020-11-08 23:14:39 +04:00
Karen Martikyan 1d106e8163 PR comments fixed: minor changes 2020-11-08 16:50:29 +04:00
Karen Martikyan 8187f66c60 Removed redundant package dependency 2020-11-07 18:45:45 +04:00
Karen Martikyan a9ac5ff12a Small intend fix v2 2020-11-07 18:32:22 +04:00
Karen Martikyan 1332940f73 Small intend fix 2020-11-07 18:26:50 +04:00
Karen Martikyan 035e34f1de Improvements made, bugfixes made 2020-11-07 18:03:58 +04:00
Karen Martikyan 9017878a3c Small fixes, redundant extension removed 2020-11-07 14:54:33 +04:00
Karen Martikyan 64ccc60fd2 Undone changes to Log.cs 2020-11-07 14:32:03 +04:00
Karen Martikyan b4286bda10 Working state 2020-11-07 14:30:09 +04:00
warwickmmandGitHub 85139f86f2 Merge pull request #4359 from achims311/master
Fix use-background-io-priority warnings.
2020-11-05 16:53:06 -08:00
Karen Martikyan 1f55b1854e Urgent commit 2020-11-05 23:32:11 +04:00
Achim Schaefer 5fa8e58f8d Bugfix issue #3920
only "best-effort" and "realtime" allow a priotity level
"none" and "idle" have no prioity level
2020-11-05 15:49:48 +01:00
Kenneth Hsu 6570cd954c Add test for specifying remote URL using run-script-before.
This concerns issue #3651.
2020-11-01 14:19:09 -08:00
Kenneth Hsu ca5aad9ccb Allow custom commands to be provided to CreateScript test helper. 2020-11-01 13:14:00 -08:00
Kenneth Hsu 49e026ee92 Fix issue where remote URL defined using run-script-before was ignored.
Previously, we were declaring that the m_remoteurl field be passed by
reference to the Execute method.  However, the OnStart method declared
that the remoteurl variable was to be passed by reference.  As a result,
the caller (Controller.SetupCommonOptions) method never received the
updated value.

Now, the variables being passed by reference are made consistent.

This fixes #3651.
2020-11-01 13:13:54 -08:00
warwickmmandGitHub b6e1618947 Merge pull request #4354 from seantempleton/uploadFilesetsLast
Upload filesets last to avoid missing blocks error.
2020-10-30 07:51:19 -07:00
Sean Templeton a9c16fcefa Upload filesets last during a backup
If parallel uploads are enabled it is possible for the fileset to be uploaded before all dblocks are uploaded.
When the fileset is placed in the queue to be uploaded place it in a separate list and only upload it after all dblocks have been uploaded.

Fixes #4341
2020-10-29 21:19:15 -05:00
Kenneth SkovhedeandGitHub 40416560e6 Merge pull request #4352 from duplicati/feature/new_unittest_datahost
Changed unittes datahost to reduce S3 transfer charges
2020-10-27 11:28:50 +01:00
Kenneth SkovhedeandGitHub 840b969fbd Merge pull request #4346 from warwickmm/fix_synology_administrator_check
Fix check for administrator group on Synology devices
2020-10-27 10:39:21 +01:00
Kenneth Skovhede 5fd1c883e3 Changed to using a proxied host to reduce S3 transfer charges from unittests 2020-10-19 00:44:10 +02:00
Kenneth Hsu ee061a7d30 Fix check for administrator group on Synology devices.
The id command prints a newline character after printing the group ids.
This needs to be removed before checking for the administrator group
(101).

This fixes #2610.
2020-10-18 13:34:36 -07:00
Karen Martikyan b4923216b4 Urgent commit 2020-10-17 22:24:13 +04:00
Kenneth SkovhedeandGitHub a80d50687e Merge pull request #4329 from warwickmm/fix_sia_null_reference
Avoid null reference exception when building Sia error messages
2020-10-09 12:21:38 +02:00
Kenneth Hsu 0d991d5712 Refine check for null web exception response. 2020-10-05 07:38:13 -07:00
Kenneth SkovhedeandGitHub cda96257dc Merge pull request #4327 from warwickmm/fix_rclone_paths
Fix construction of paths for rclone
2020-10-05 12:14:32 +02:00
Kenneth SkovhedeandGitHub f23a6b2774 Merge pull request #4331 from warwickmm/use_method_to_compare_directories
Use helper method to compare directories in RecoveryTool tests
2020-10-05 12:08:54 +02:00