haeaeae/duplicati
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
10,149 Commits 140 Branches 416 Tags
992a0fd90cd9ca93647d052d55c05fdb110ac1ce
Commit Graph
10149 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Kenneth Hsu 6f231f9190 Avoid referencing virtual members in Basiclist constructor. 
When referencing virtual members in a constructor, the behavior may be
ill-defined as the overridden implementation may depend on uninitialized
instance members.

Since the TABLE_PREFIX, TABLEFORMAT, INSERTCOMMAND, and INSERTARGUMENTS
properties were only referenced in the Basiclist constructor, we can
remove the abstract keyword and provide the values as constructor
parameters.
 2018-10-17 20:11:06 -07:00
Mikael Mello 9eb9ec004d Target Windows 8.1 and 10 in order to display correct version in UI 2018-10-17 10:37:44 -03:00
Rune HenriksenandGitHub 23578f0d26 Merge pull request #3436 from LacunaSoftware/fix-description-mismatch 
Make description an optional field for backups
 2018-10-17 15:22:37 +02:00
Kenneth Skovhede 68d2f10475 Merge branch 'master' of github.com:duplicati/duplicati 2018-10-17 14:37:52 +02:00
Kenneth Skovhede 975baf2579 Reporting the error id to the WebUI 2018-10-17 14:37:43 +02:00
Kenneth Skovhede 2826dbe6f0 Improved error message for faults in database filelists 2018-10-17 14:37:23 +02:00
Kenneth Skovhede d03a8a759f Spelling fix 2018-10-17 14:36:54 +02:00
Mikael Mello 91bdf4be63 Make description an optional field for backups 
Checks whether it has been set and acts accordingly to avoid exceptions

Update migration to initialize all existent rows to Description=''.

Note that after some research, default values for TEXT columns were not
supported by MySQL a few years ago, however Duplicati uses SQLite
which seems to fully support this feature. If not, a workaround is to use:

ALTER TABLE "Backup" ADD COLUMN "Description" TEXT NULL;
UPDATE "Backup" SET "Description"='' WHERE "Description" IS NULL;
ALTER TABLE "Backup" ALTER COLUMN "Description" TEXT NOT NULL;
 2018-10-17 09:02:39 -03:00
Rune HenriksenandGitHub 6c47c39f2b Merge pull request #3431 from warwickmm/remove_unused_members 
Remove unused class members
 2018-10-17 00:40:11 +02:00
Rune HenriksenandGitHub a00d2ad624 Merge pull request #3435 from gzzengwei/issue_3430_add_us_west_for_wasabi 
#3430 add US-West support for wasabi
 2018-10-17 00:39:14 +02:00
Rune HenriksenandGitHub e1fb6d43c3 Merge pull request #3432 from warwickmm/fix_log_message_typo 
Fix typo in log message id
 2018-10-16 08:19:07 +02:00
Kenneth Hsu 9e0b031fee Remove unused members. 2018-10-15 21:20:30 -07:00
Kenneth Hsu e16ab43d86 Fix typo in log message id. 2018-10-15 21:14:59 -07:00
Wei Zeng 0abc0dad99 #3430 add US-West support for wasabi 2018-10-16 15:09:43 +11:00
Rune HenriksenandGitHub d86c6cce61 Merge pull request #3424 from warwickmm/flatten_aggregate_exceptions 
Flatten AggregateExceptions before referencing InnerException
 2018-10-14 12:21:12 +02:00
Rune HenriksenandGitHub a485730bf8 Merge pull request #3425 from warwickmm/remove_partial_keyword 
Remove unnecessary use of partial keyword
 2018-10-14 12:19:34 +02:00
Rune HenriksenandGitHub 9bb6564657 Merge pull request #3426 from warwickmm/fix_xml_documentation 
Fix issues with XML documentation
 2018-10-14 12:19:15 +02:00
Kenneth Hsu 9374d6b208 Move comments and remove invalid XML tags. 
The comment was not placed before a valid language element.
 2018-10-13 20:52:30 -07:00
Kenneth Hsu 914b35e342 Escape characters in XML documentation. 2018-10-13 20:52:15 -07:00
Kenneth Hsu 6b8dc6e8b8 Rename parameter to match XML documentation. 
The use of camel case is also more consistent with the surrounding
style.
 2018-10-13 20:45:13 -07:00
Kenneth Hsu 22d5328e75 Remove extra XML documentation tag. 2018-10-13 20:43:38 -07:00
Kenneth Hsu 1d57ddd5a6 Flatten AggregateExceptions before referencing InnerException. 
The InnerException property of an AggregateException can be another
AggregateException.  By calling Flatten(), we remove inner
AggregateExceptions so that the InnerExceptions property contains all
the original exceptions.  The InnerException property is the first
element of InnerExceptions.
 2018-10-13 19:07:49 -07:00
Kenneth Hsu beb552fa9e Remove unnecessary use of partial keyword. 
These classes are defined in a single location.
 2018-10-13 16:53:28 -07:00
Rune HenriksenandGitHub 6550a69909 Merge pull request #3420 from warwickmm/remove_empty_methods_statements 
Remove unused empty methods and empty statements
 2018-10-11 22:54:52 +02:00
Rune HenriksenandGitHub 2165a52168 Merge pull request #3422 from LacunaSoftware/fix-httpinput-empty 
Fix error in POST requests with empty form
 2018-10-11 22:53:15 +02:00
Rune HenriksenandGitHub 681f4ee33b Merge pull request #3423 from LacunaSoftware/fix-logscope 
Revert hunk from 9ce1e80. Log redirect needs to be setup
 2018-10-11 22:51:39 +02:00
Mikael Mello c72d5ce236 Revert hunk from 9ce1e80. Log redirect needs to be setup 2018-10-11 11:09:06 -03:00
Mikael Mello 608e4e7972 Fix error when trying to add items to empty HttpForm (that is an empty HttpInput) 2018-10-11 09:30:28 -03:00
Kenneth Hsu 05d8fd425e Add comments to explain empty methods. 2018-10-10 21:28:00 -07:00
Kenneth Hsu 07c1d85b4a Remove empty statements. 2018-10-10 21:22:31 -07:00
Kenneth Hsu 731a8b1644 Remove unused empty methods. 2018-10-10 21:20:40 -07:00
Rune HenriksenandGitHub b4241f3096 Merge pull request #3417 from warwickmm/fix_default_value_comparison 
Constrain generic type to be a class to allow for null comparison
 2018-10-09 07:49:23 +02:00
Kenneth Hsu 8bb770964d Constrain generic type to be a class to allow for null comparison. 
The SendRequest method performs a comparison between an object of type T
and null.  While there are no use cases currently where the generic type
is a value type, we should constrain the generic type to be a class so
that the comparison remains meaningful.
 2018-10-08 19:13:23 -07:00
Kenneth Hsu 6c08f44394 Revert "Avoid potential comparison of value type with null." 
This reverts commit ecb670a2d9.

While there aren't any cases where the generic type is a struct, the
comparison with default(T) is incorrect.  If T is int, we wouldn't want
the behavior to differ based on whether the value was zero or nonzero.
 2018-10-08 18:54:36 -07:00
Rune HenriksenandGitHub aa1f99628c Merge pull request #3414 from warwickmm/avoid_value_null_comparison 
Avoid potential comparison of value type with null
 2018-10-07 22:35:25 +02:00
Rune HenriksenandGitHub fbab37d138 Merge pull request #3413 from warwickmm/avoid_null_reference 
Avoid potential null reference exception
 2018-10-07 19:14:34 +02:00
Rune HenriksenandGitHub 6b6faebea3 Merge pull request #3404 from lucascosti/server_stat_string_cleanup 
Fix server status strings grammar and consistency
 2018-10-07 19:13:22 +02:00
Rune HenriksenandGitHub 6c662a0d8b Merge pull request #3412 from mnaiman/normalize_path 
all drives letter uppercase
 2018-10-07 19:07:52 +02:00
Rune HenriksenandGitHub be7edb580d Merge pull request #3410 from warwickmm/simplify_enumerating_collections 
Simplify enumeration of collections
 2018-10-07 19:06:28 +02:00
Kenneth Hsu ecb670a2d9 Avoid potential comparison of value type with null. 
While there aren't currently any cases where the generic type is a value
type, this will make the code slightly more robust to future
implementations.
 2018-10-07 09:59:13 -07:00
Rune HenriksenandGitHub dc5a0dbc94 Merge pull request #3409 from warwickmm/remove_unused_parameters 
Remove unused method parameters
 2018-10-07 18:56:43 +02:00
Rune HenriksenandGitHub 9dac0c3b7b Merge pull request #3406 from Pectojin/upgrade_mega_api_client 
updated MegaApiClient from 1.6.0 to 1.6.3
 2018-10-07 18:56:15 +02:00
Max123456 73d7aaffdc Invariant Upper 2018-10-07 11:47:48 +02:00
Max123456 0c71f0af2c all drives letter uppercase 2018-10-07 11:32:25 +02:00
Kenneth Hsu b6e1e3e3f4 Avoid potential null reference exception. 2018-10-06 20:42:25 -07:00
Kenneth Hsu b824c86c7e Avoid unnecessary enumeration of collections. 
This improves performance by using Any() to avoid unnecessary
enumeration of collections.
 2018-10-06 16:20:18 -07:00
Kenneth Hsu 0c1ac9c489 Replace chained LINQ calls with call to overload with predicate. 
This simplifies the code by reducing the number of enumerators created
while also making the code slightly more readable.
 2018-10-06 16:20:18 -07:00
Kenneth Hsu d72128ec83 Remove unused method parameters. 2018-10-06 15:09:43 -07:00
Rune Henriksen 306ccabfef updated MegaApiClient from 1.6.0 to 1.6.3 2018-10-04 00:34:49 +02:00
Rune HenriksenandGitHub 439e319061 Merge pull request #3391 from sffetlio/description_field 
Add Description field to backups
 2018-10-04 00:13:05 +02:00