Commit Graph
6059 Commits
Author SHA1 Message Date
Dean Ferreyra aa50b1dfbf Fix typo in comment 2020-08-30 20:04:07 -07:00
Dean Ferreyra 5f94cc19a7 Fix restore GUI handling of folders with * or ?
Add new filter syntax, prefixing with an "at sign"; i.e., `@...`, that
disables glob expansion, treating `*` and `?` wildcard characters as
literal characters.

In the GUI, change the restore file picker to prefix paths with `@`
when expanding a node to avoid mistaking literal `*` or `?` characters
for wildcards characters and triggering the following error:
```
Filter for list-folder-contents must be a path prefix with no wildcards Parameter name: filter
```

This fixes #4300.
2020-08-30 17:07:04 -07:00
Honoré Vasconcelos 71494826f9 Improve query performence used in GetFilesAndSourceBlocksFast
Tree changes in query
* Move inner selection S to a temporary table
* Reorder join field in outer query
* Remove intersection with File view in outer selection
File view is already intersected with in selection S

With the above-mentioned changes, on a specific testset, query took 9s instead of 6min.
2020-08-26 10:10:54 +01:00
warwickmmandGitHub bcaedebecd Merge pull request #4287 from dgehri/feature/improve_usn_2
Improve USN performance.
2020-08-22 09:28:05 -07:00
warwickmmandGitHub 83318877a1 Merge pull request #4285 from dferreyra/source_path_with_unc_prefix_3
Handle Windows source paths starting with "\\?\"
2020-08-21 07:38:12 -07:00
Daniel Gehriger 31bb24d605 USN: moving exclusion filter earlier in the enumeration process to improve performance 2020-08-18 16:07:01 +02:00
Daniel Gehriger bb1853085d USN: only considering events relevant to backup 2020-08-18 12:21:59 +02:00
Daniel Gehriger b6752bead3 USN: excluding non-relevant events 2020-08-18 11:43:52 +02:00
Daniel Gehriger d143f8b3f9 Improved speed of AppendFilesFromPreviousSetWithPredicate, making USN backups usable when there are large file sets 2020-08-18 11:43:23 +02:00
Daniel Gehriger 420c23cf05 USN: corrected exclusion criteria 2020-08-17 23:03:51 +02:00
Daniel Gehriger 82c54dde31 Fixing AppendFilesFromPreviousSetWithPredicate 2020-08-17 23:01:20 +02:00
Daniel Gehriger c5bef5c2e0 Improved Improved speed of AppendFilesFromPreviousSetWithPredicate, making USN backups usable when there are large file sets 2020-08-17 18:06:38 +02:00
Daniel Gehriger 8e8c758c65 Improved speed of AppendFilesFromPreviousSetWithPredicate, making USN backups usable when there are large file sets 2020-08-17 17:27:45 +02:00
Daniel Gehriger 7d2c6befb0 Using USN journal in CountFilesHandler 2020-08-17 15:08:15 +02:00
Daniel Gehriger 245046e8e5 USN: adding verbose message 2020-08-17 14:41:41 +02:00
Daniel Gehriger 0caf724982 USN journal: removing create & delete sequences between two backups from list of files 2020-08-17 14:41:23 +02:00
Dean Ferreyra b8eecba62c Handle Windows source paths starting with "\\?\"
Under Windows, strip paths of any `\\?\` prefix to prevent Duplicati
from storing paths prefixed with `\\?\`.

This fixes an inconsistency in the stored data where, if the user
provided a prefixed path to back up (e.g., `\\?\C:\Temp`), Duplicati
would store an entry with the prefixed path (e.g., `\\?\C:\Temp`)
along with entries with paths stripped of their prefix (e.g.,
`C:\Temp\file.txt`).  By only storing non-prefixed paths, this also
avoids an error reported by the GUI when it would encounter a prefixed
path:
```
Filter for list-folder-contents must be a path prefix with no wildcards Parameter name: filter
```
2020-08-15 20:09:54 -07:00
Dean Ferreyra ecd62e8cea Fix snapshots broken by #4256
Add comment in `WindowsSnapshot.ConvertToSnapshotPath()` warning how
replacing some manual path construction code with Path.Combine() alone
can lead to invalid snapshot paths.
2020-08-08 15:32:54 -07:00
Dean Ferreyra 1198c10d43 Fix snapshots broken by #4256
Revert the change made to `WindowsSnapshot.ConvertToSnapshotPath()`
by pull request #4256.

The change in #4256 replaced some existing manual path construction
code with a call to `SystemIO.IO_WIN.PathCombine()`, but calling
`SystemIO.IO_WIN.PathCombine()` this way did not always result in
valid VSS paths.  For example, trying to back up a root volume like
"C:\" would result in the following error:
```
The filename, directory name, or volume label syntax is incorrect.
```
2020-08-07 21:51:11 -07:00
Kenneth SkovhedeandGitHub 648d199427 Merge pull request #4277 from dgehri/feature/USN-deleted-files-fix
Enabled support for \$Extend\$Deleted special MTF folder when using USN
2020-08-07 12:07:44 +02:00
Kenneth SkovhedeandGitHub ec1975b5a7 Merge pull request #4269 from warwickmm/target_net_471
Target .NET Framework 4.7.1
2020-08-07 10:50:35 +02:00
Kenneth SkovhedeandGitHub 04dd510be0 Merge pull request #4261 from warwickmm/avoid_deleting_unrelated_files
Avoid deleting unrelated files when removing backup configuration
2020-08-07 10:33:31 +02:00
Kenneth SkovhedeandGitHub e5b0ac2749 Merge pull request #4260 from warwickmm/remove_unnecessary_path_combine
Remove unnecessary call to Path.Combine
2020-08-07 10:31:47 +02:00
Kenneth SkovhedeandGitHub 2d628053fa Merge pull request #4259 from warwickmm/test_check_warnings_and_errors
Check for errors and warnings in unit tests
2020-08-07 10:30:21 +02:00
Kenneth SkovhedeandGitHub ac5dda8be7 Merge pull request #4257 from warwickmm/test_invalid_windows_paths
Add tests for invalid Windows paths
2020-08-07 10:29:54 +02:00
Daniel Gehriger fcf44d595d Restoring original scheduling of CountFilesHandler 2020-08-06 18:14:07 +02:00
Daniel Gehriger 279d8d2d2c Fixed usn reason comparison (was too severe) 2020-08-06 17:58:19 +02:00
Daniel Gehriger 51ce673831 Removed debug assert 2020-08-06 16:56:52 +02:00
Daniel Gehriger b25d4b47ca Enabled support for \$Extend\$Deleted special MTF folder when using USN 2020-08-06 16:37:48 +02:00
warwickmmandGitHub 8f631a99f0 Merge pull request #4274 from dferreyra/CommandLineOperationsTests_setup
Fix setup/teardown for CommandLineOperationsTests
2020-07-31 16:55:26 -07:00
Kenneth Hsu d99d40717d Merge remote-tracking branch 'upstream/master' into test_invalid_windows_paths
This allows us to simplify the ProblematicPathTests because the test
teardown methods can now handle deleting directories containing
problematic paths.
2020-07-31 16:29:28 -07:00
Dean Ferreyra c70508b96e Fix setup/teardown for CommandLineOperationsTests
Change Duplicati.UnitTest.CommandLineOperationsTests to use `Setup()`
instead of `OneTimeSetUp()` to make sure the test files are in place
for each test.

This fixes #4273.
2020-07-31 07:47:09 -07:00
Dean Ferreyra 2e777b2711 Change tests to work with long paths in Windows
Change SystemIOWindows.PathGetFullPath() to convert forward
slashes to backslashes.

Change Duplicati.UnitTest.BasicSetupHelper.ZipFileExtractToDirectory()
to rely on slash fix-ups.
2020-07-30 05:08:18 -07:00
Dean Ferreyra 73e31a79a1 Change tests to work with long paths in Windows
Even in .NET 4.6.2
`System.IO.Compression.ZipFile.ExtractToDirectory()` cannot handle
long paths.  Replace call to
`System.IO.Compression.ZipFile.ExtractToDirectory()` with an
equivalent that extracts files to a temporary location and uses I/O
functions that support long paths to move them to their final
location.

In CommandLineOperationsTests.cs, use ISystemIO functions to handle
potentially long paths.

Add a fix to RecoveryTool for long paths that was missed by #4258.

This fixes #3863.
2020-07-28 05:51:53 -07:00
Kenneth Hsu e964072690 Target .NET Framework 4.7.1.
This updates all projects to target .NET Framework 4.7.1.  The
TencentCOS and Tardigrade backends depend on .NET Standard 2.0.  When a
.NET Framework prior to 4.7.1 is targeted, the system cannot be sure
that all the dependencies exist, so it copies all dependent assemblies
to the output directory.  This causes many assemblies from the System
namespace to become bundled in the release.

https://stackoverflow.com/a/48875007

We had previously attempted to make individual projects target 4.7.1
(see pull request #4242), but this can cause compatibility issues when
4.6.2 projects depend on 4.7.1. projects.

This will require Mono 5.10.0 or greater (previously, we required 5.0.0
or greater).

https://www.mono-project.com/docs/about-mono/releases/5.10.0/#class-libraries

This fixes issue #4234.
2020-07-26 19:46:01 -07:00
Kenneth Hsu 568fadbcec Merge remote-tracking branch 'upstream/master' into test_invalid_windows_paths 2020-07-25 17:52:09 -07:00
warwickmmandGitHub e7daffcb31 Merge pull request #4256 from dferreyra/support_problematic_windows_paths
Support problematic Windows paths that end with spaces or periods.
2020-07-25 17:48:50 -07:00
Kenneth Hsu ef8209bc21 Add test to verify number of included paths. 2020-07-23 19:46:23 -07:00
Kenneth Hsu 443514dabd Rename test method. 2020-07-23 19:44:10 -07:00
Kenneth Hsu 466bc3786b Extract creation of problematic file to method. 2020-07-23 19:43:24 -07:00
Kenneth Hsu 1b7d1533ee Add test for excluding problematic paths. 2020-07-23 19:40:00 -07:00
TopperDEL fde7e84afc fix: Resovle codacy-issue 2020-07-22 14:31:03 +02:00
TopperDEL c451724520 build: Switch to uplink.NET v2.3.4 fixing one download-issue 2020-07-22 12:40:37 +02:00
TopperDEL 6a8a029c70 cleanup: Reduce one line 2020-07-22 12:40:21 +02:00
Kenneth Hsu 0314c388ef Rename test method. 2020-07-21 13:49:41 -07:00
Kenneth Hsu 00cd10062b Add test to check that only backend files with correct prefix are deleted.
This concerns issue #2678.
2020-07-21 13:20:42 -07:00
Kenneth Hsu 77a4918f36 Add test to check that only relevant backend files are deleted.
This concerns issues #3845, and #4244.
2020-07-21 13:20:42 -07:00
Kenneth Hsu fea55b9981 Avoid removing files unrelated to backup being deleted.
This fixes issues #3845 and #4244.
2020-07-21 12:59:28 -07:00
Kenneth Hsu f47299d7a1 Remove unnecessary call to Path.Combine. 2020-07-20 20:08:14 -07:00
warwickmmandGitHub 512aa9b979 Merge pull request #4258 from dferreyra/fix_recovery_tool_path_with_dashes
Fix Recovery Tool handling of paths with dashes
2020-07-20 09:48:30 -07:00