Commit Graph
32 Commits
Author SHA1 Message Date
Dean Ferreyra 2e777b2711 Change tests to work with long paths in Windows
Change SystemIOWindows.PathGetFullPath() to convert forward
slashes to backslashes.

Change Duplicati.UnitTest.BasicSetupHelper.ZipFileExtractToDirectory()
to rely on slash fix-ups.
2020-07-30 05:08:18 -07:00
Dean Ferreyra 73e31a79a1 Change tests to work with long paths in Windows
Even in .NET 4.6.2
`System.IO.Compression.ZipFile.ExtractToDirectory()` cannot handle
long paths.  Replace call to
`System.IO.Compression.ZipFile.ExtractToDirectory()` with an
equivalent that extracts files to a temporary location and uses I/O
functions that support long paths to move them to their final
location.

In CommandLineOperationsTests.cs, use ISystemIO functions to handle
potentially long paths.

Add a fix to RecoveryTool for long paths that was missed by #4258.

This fixes #3863.
2020-07-28 05:51:53 -07:00
Dean Ferreyra d154702020 Support problematic Windows paths
Fix pull request string comparisons in SystemIOWindows.cs to use
StringComparison.Ordinal.

Fix pull request to use SystemIO.IO_WIN.PathCombine() in
WindowsSnapshot.cs.
2020-07-19 16:24:51 -07:00
Dean Ferreyra 6acbbf2136 Support problematic Windows paths
Allow historically problematic Windows paths (i.e., files or
directories that end in a dot or a space) to be backed up with
Duplicati in Windows.

This fixes #3839.
2020-07-17 21:50:29 -07:00
Kenneth Hsu 1249267f6e Remove unused members from Duplicati.Library.Common. 2020-04-05 14:36:28 -07:00
Rod Savard c247d01c6e remove spaces 2020-03-18 04:57:25 -07:00
Rod Savard b30fdfe34d add comment and simplify key value assignment 2020-03-17 21:35:19 -07:00
Rod Savard 4c41fd691a only store inheritance breaks in metadata when true 2020-03-17 06:48:00 -07:00
warwickmmandGitHub e32d14fa12 Merge pull request #4031 from drwtsn32x/fix-broken-inheritance
Fix issue restoring permissions with inheritance breaks.
2020-01-01 11:42:52 -08:00
drwtsn32x e0c940fb45 variable name change 2019-12-28 20:37:23 -08:00
drwtsn32x ab23d646b6 remove serializer since we only store single bool 2019-12-26 08:32:31 -08:00
drwtsn32x ddce687b14 don't read rules unless we are restoring permissions 2019-12-26 08:03:06 -08:00
drwtsn32x aa7d4150b3 clean up if block 2019-12-26 07:51:30 -08:00
drwtsn32x 9bca37f29f tweak 2019-12-25 21:17:02 -08:00
drwtsn32x e76be20e34 back up and restore inheritance breaks 2019-12-25 20:56:28 -08:00
warwickmmandGitHub 578faba5bc Merge pull request #4030 from drwtsn32x/fix-issue-4028
Fix bug in restoring file permissions on Windows.
2019-12-24 18:35:32 -08:00
User 5f06b4ac0c Add JsonProperty 2019-12-24 07:21:25 -08:00
Kenneth Hsu 83ac03843d Fix spelling errors in comments.
In doing so, we also normalized some line endings.
2019-12-14 09:52:55 -08:00
User 74b0811061 add comment 2019-12-03 19:33:45 -08:00
User b1b45228c2 fix long path test 2019-12-03 18:07:23 -08:00
Kenneth Hsu 2aa76881a5 Mark fields that don't need to be reassigned as readonly.
This makes it explicit at compile-time that these fields should not be
reassigned outside the constructor.
2019-10-19 13:59:22 -07:00
Kenneth Hsu 772cd5aaef Use dedicated method to create symbolic links to directories.
The methods that accepted a SymbolicLinkTarget parameter have been
deprecated.
2019-09-14 10:44:12 -07:00
Kenneth Hsu b5d9451b33 Remove redundant casts. 2019-01-21 19:30:52 -08:00
verhoek e2c2bc1a79 Moved method to bottom to let the PathTooLong* methods group together. 2018-11-29 09:37:10 +01:00
verhoek 9ce8471bde Cache serializer. 2018-11-29 09:32:42 +01:00
verhoek bb7062d34b Regrouped methods. 2018-11-29 09:13:13 +01:00
verhoek 57c96da914 Reducing duplicate code. 2018-11-29 09:00:48 +01:00
verhoek 94f34ce5a1 Removal of boiler plate code put into static helper. 2018-11-26 18:37:05 +01:00
verhoek 7128544a96 Fix bug that accidentally also handles directories besides files in file backend. 2018-11-26 18:34:52 +01:00
verhoek 2051e0b272 Added null check for writers to include in vss (issue 3494).
Improved exception logging.
2018-11-13 21:04:34 +01:00
verhoek 742efe3a5e Simplified SystemIO class. 2018-11-03 09:06:24 +01:00
verhoek 317198816f Moving from IO to Common dir. 2018-11-02 22:25:44 +01:00