Kenneth Skovhede
8224d84f57
Reverted to use the shorter name --asynchronous-upload-limit and then added an alias for --asynchronous-concurrent-upload-limit.
2025-10-16 13:25:34 +02:00
Kenneth Skovhede
55c19c8752
Removed more references to the unused option
2025-10-16 13:21:40 +02:00
Kenneth Skovhede
d3b15f136e
Removed unused option
...
The option `asynchronous-upload-limit` was not used, and has been removed.
2025-10-14 21:30:02 +02:00
Kenneth Skovhede and GitHub
9507b57f1c
Merge pull request #6534 from carljohnsen/performance/restore-lock-reduce
...
Performance/restore lock reduce
2025-10-03 11:46:00 +02:00
Carl Johnsen
91fc698314
The block manager only adds a block to the cache, if it's needed at a later point.
2025-10-03 09:50:08 +02:00
Carl Johnsen
2aa2103f33
Changed BlockManager to only use the cache if the max size is > 0
2025-10-03 09:26:38 +02:00
Carl Johnsen
aafe192766
Added docstring
2025-10-03 09:26:08 +02:00
Carl Johnsen
a1e1afce28
Changed the default volume cache hint to be volumesize * 100
2025-10-03 08:50:35 +02:00
Carl Johnsen
842cc00979
Added profiling stopwatch for DataBlock instantiation in volume decompressor
2025-10-03 08:32:29 +02:00
Carl Johnsen
dff4b52066
Moved instantiation of the block wrapper to the volume decompressor
2025-10-03 08:32:20 +02:00
Carl Johnsen
8f056d5db9
Added profiling stopwatch for volume wrapper in the volume decryptor
2025-10-03 08:25:56 +02:00
Carl Johnsen
cd4e23efc4
Moved instantiation of the volume wrapper to the volume decryptor
2025-10-03 08:25:46 +02:00
Carl Johnsen
2ad6e088ac
Added another profiling stopwatch to blockmanager
2025-10-03 08:21:42 +02:00
Carl Johnsen
0c1643568e
Volume cache now counts the size of the volumes, not just the count of the volumes
2025-10-03 08:11:04 +02:00
Carl Johnsen
48e5a57654
Adapted volume cache eviction to only evict on a download response
2025-10-03 07:51:24 +02:00
Carl Johnsen
42cba24bd9
Removed old decompress in flight code
2025-10-03 07:50:48 +02:00
Carl Johnsen
1f0a4617a6
The reader has to be disposed before disposing the file
2025-10-03 07:50:19 +02:00
Carl Johnsen
34cfd47ceb
Added docstrings
2025-10-03 07:50:03 +02:00
Carl Johnsen
1f44b5e01b
Removed old ack profiling from the block manager
2025-10-03 07:49:06 +02:00
Carl Johnsen
d03259d687
Redacted the ack channel in the restore process network in favor of a referenced counted volume wrapper that'll dispose the reader and tempfile once safe.
2025-10-02 21:40:40 +02:00
Carl Johnsen
03db41e392
FileProcessor had an incorrect call to logging
2025-10-02 21:36:07 +02:00
Carl Johnsen
4f2bfe1fa0
Reduced very verbose logging on errors in BlockManager
2025-10-02 21:35:35 +02:00
Carl Johnsen
4951500db4
The BlockManager wouldn't always correctly retire its request channel
2025-10-02 21:34:44 +02:00
Carl Johnsen
91f783f80f
Handled compact being called multiple times due to eventual consistency of the cache count.
2025-10-02 16:53:30 +02:00
Carl Johnsen
12e5383f2f
Instead of exploiting the garbage collector to return the arrays from the pool, we use an internal reference counter for each datablock
2025-10-02 16:21:03 +02:00
Carl Johnsen
b475eeb387
Moved formatting of the explicit log messages to occur later to alleviate having to do that when that log level is disabled, which should decrease wasted processing.
2025-09-30 21:38:04 +02:00
Carl Johnsen
36ce099e6d
Added additional toggle-able debug prints to the restore flow
2025-09-30 21:18:28 +02:00
Carl Johnsen
90a54a177e
Added an internal timer to the VolumeDecryptor
2025-09-30 13:11:16 +02:00
Carl Johnsen
531471e3b5
Reordered the final checks in the SleepableDictionary and lifted some warnings to errors.
2025-09-30 13:06:20 +02:00
Carl Johnsen
6402e1b4a7
Fixed deadlock when the restore-channel-size option was set to 0
2025-09-30 13:00:52 +02:00
Carl Johnsen
2b4928cf46
Automatic formatting
2025-09-30 12:59:47 +02:00
Carl Johnsen
638b725e82
MemoryCache callback wasn't attached to the entries properly
2025-09-30 12:59:34 +02:00
Carl Johnsen
f3f2d93a6e
Renamed internal variable to reflect it's a private variable
2025-09-30 12:59:15 +02:00
Carl Johnsen
3b9f0c04a0
MemoryCache.Count is expensive and is used for diagnostics.
...
Instead we keep our own counter to check for when to compact the cache.
2025-09-30 12:58:39 +02:00
Carl Johnsen
4826b800a5
Instead of keeping track of how many that are actively accessing the arrays, we now have an object wrapping the array.
...
When this object is collected by the garbage collector, the array is returned to the array pool. This moves the responsibility to the garbage collector leading to a more thread-safe approach with less locks, at the cost of potentially using memory for a longer time until the garbage collector picks up the objects.
2025-09-30 12:55:13 +02:00
Carl Johnsen
e90013f41f
Added and handled nullable to all of the restore processes
2025-09-30 12:46:08 +02:00
Kenneth Skovhede
b0bd9c121f
Fixed reading the size of files in restore
...
This significantly speeds up the restore file listing speed.
2025-09-26 13:54:06 +02:00
Kenneth Skovhede
39cca5c24f
Simplified calling code to not rely on extension methods
2025-09-25 11:33:56 +02:00
Kenneth Skovhede
230d80642a
Fixed invariant formatting helpers
...
This fixes an issue with formatting for invariant values that was caused by incrorrect function overload selection.
To avoid future issues, the two similar functions have been renamed to clarify what they are working for.
2025-09-25 11:14:54 +02:00
Kenneth Skovhede and GitHub
cd263da4d6
Merge pull request #6517 from duplicati/feature/fix-incorrect-dindex-volumes
...
Include duplicated blocks in recreated index files
2025-09-23 13:03:15 +02:00
Kenneth Skovhede
d466ebd6ca
Bumped to 1.8.4
2025-09-23 11:53:09 +02:00
Kenneth Skovhede
f0d8677ef5
Include duplicated blocks in recreated index files
...
This fixes #6504
2025-09-23 11:12:36 +02:00
Kenneth Skovhede and GitHub
dc2200c608
Merge branch 'master' into feature/bump-cocol-183
2025-09-22 15:43:20 +02:00
Kenneth Skovhede
b2c6ef73c5
Improve logging of SQL statements
...
This updates the logging code to do invariant formatting of the SQL statements
2025-09-22 14:39:46 +02:00
Kenneth Skovhede
0ce519650c
Update CoCoL to 1.8.3
...
This addresses part of #6497
2025-09-20 13:17:37 +02:00
Kenneth Skovhede and GitHub
c95b868e18
Merge pull request #6492 from duplicati/feature/prevent-locale-issues-with-queries
...
Ensure that a query string is formatted with invariant string formatting
2025-09-10 14:54:45 +02:00
Carl Johnsen
7670ea9a58
Ensured that all values that are passed to interpolation strings have been passed through FormatInvariant to prevent SQLite errors related to string formatting cultures.
2025-09-05 14:11:05 +02:00
Carl Johnsen
1a5fef36d7
Removed whitespace
2025-09-05 14:07:58 +02:00
Carl Johnsen
b3fe276a13
Ensured that all temporary tables uset the same type of generated guid name
2025-09-05 14:06:55 +02:00
Kenneth Skovhede
a1fa2f8e1e
Fixed to use same helper method
2025-09-02 09:32:25 +02:00
Kenneth Skovhede