Commit Graph
79 Commits
Author SHA1 Message Date
Kenneth Skovhede 40dd3c6816 Updated all license mentions to MIT 2024-02-28 15:45:30 +01:00
Kenneth Hsu de2a651763 Fix bug in PutAsync implementations.
Without await, the using statement can dispose the Stream before the
call to PutAsync completes, resulting in an ObjectDisposedException.

This fixes #4556.
2021-06-12 15:12:13 -07:00
Kenneth Hsu afab61a05b Use pattern matching to simplify casts. 2019-10-19 10:15:38 -07:00
Sean Templeton b02b19e683 Change Put method name to PutAsync 2019-03-17 18:28:45 -05:00
Sean Templeton c05f304fd7 Update S3, Sharepoint, Tahoe, and WEBDAV backends for async Put 2019-03-05 21:25:35 -06:00
Sean Templeton 0c122ff550 Change IBackend and IStreamingBackend to return Task for Put() 2019-03-03 21:43:10 -06:00
verhoek b2cc18426c Renamed Library.IO to Library.Common.IO.
Moved basic Platform functions to Library.Common.Platform.
Turned IO_OS into property within Library.Common.
2018-11-02 21:34:07 +01:00
verhoek bc053df294 Moved basic IO helper functions to Library.IO. 2018-10-27 12:17:07 +02:00
Kenneth Hsu d4d1945faf Use utility method to append trailing slash.
This removes some duplicated code.
2018-09-22 10:19:45 -07:00
Kenneth Hsu f12858e6a5 Mark fields that shouldn't be reassigned as readonly.
This makes it explicit at compile-time that these fields should not be
reassigned outside the constructor.
2018-05-25 10:04:52 -07:00
Kenneth Hsu 0777d9c98a Fix indentation to improve readability.
The previous indentation could give the impression that it belongs to
the preceding if-statement.
2018-05-13 14:24:13 -07:00
Kenneth Skovhede 842fd96543 Implemented a new logging system that is more transparent and allows a more granular way of picking log messages.
Added ID's to each log message and each exception to allow later introduction of a Knowledgebase service that explains each error in more detail.
2018-03-15 09:12:34 +01:00
Kenneth Skovhede bd863016fa Added support for returning multiple DNS names for cache invalidation.
Updated most backends to return the actual DNS names for cache invalidation.
2018-02-26 11:37:10 +01:00
Rune Henriksen fc77b476fc changed from NYI to null returns. Added check to skip DNS check if no DNSName is provided 2018-02-21 22:38:01 +01:00
Rune Henriksen ecc586c0f8 added code to attempt to resolve DNS issues on connection failure and implemented DNSName method in WebDav backend handler 2018-02-18 01:30:05 +01:00
Rune Henriksen 00292953c3 added DNSName getter on Backend interface and added NotImplementedException methods on each backend class 2018-02-18 00:18:44 +01:00
inat3kandGitHub 9e632a71b7 Fix for #2970
Fix for Test Connection to WebDAV Server
2018-01-18 17:55:06 +01:00
Kenneth SkovhedeandGitHub 36aadc4ad1 Merge pull request #2910 from warwickmm/refactor/remove_redundant_tostring
Remove redundant calls to ToString
2017-11-27 08:50:00 +01:00
Kenneth Hsu 5fb1958ceb Remove redundant calls to ToString. 2017-11-26 15:44:34 -08:00
Kenneth Hsu 8810e0130d Make string comparisons use ordinal (binary) sort rules.
These string comparisons should not be culture-aware.
2017-11-26 11:19:54 -08:00
Tyler Gill 38883285ee Change IBackend.List() to return IEnumerable instead of List
By changing to IEnumerable, it is possible to iterate only a portion of the list, which is useful when not all entries are needed (e.g., when testing a connection).
All existing backends have been updated, and any which were able to be changed to yield return results in a straightforward way now do.
Many backends had a try/catch in the List() method. Due to the fact that yield returns can't be placed within a try/catch block, these have been refactored to either scope the try/catch to the parts that (should) be the only places throwing exceptions, so that exceptions are still caught and handled.
Note that lazy evaluation may cause some changes in behavior - exceptions that were previously thrown at the point of invokation of List() may now be thrown while it is being enumerated.
I believe this will not be problematic though, as the only well-known exception seems to be FolderMissingException, which should be thrown by Test(), but TestList() attempts to enumerate the list to force this exception.
Any places that require the legacy behavior can get it by simply converting the lazy enumerable to a List()
2017-09-25 23:17:45 -06:00
Tyler Gill 83a1dcfb64 Replace all instances of InvariantCultureIgnoreCase with OrdinalIgnoreCase in string comparisons.
InvariantCulture is useful when comparing / sorting human language strings in a culturely correct way. It handles things like accented letters in a way that makes sense to humans (e.g., 'a' should be sorted next to 'á', rather than after 'z').
Ordinal looks just at the raw code points of the characters. As such, it is recommended for use in cases when comparing system strings (file paths, command line parameters, config settings, etc.). Since it doesn't need to use the culture specific sorting rules, this method can often be faster.

For more information, see https://stackoverflow.com/questions/492799/difference-between-invariantculture-and-ordinal-string-comparison (and other related questions)
2017-09-18 23:55:08 -06:00
Kenneth Skovhede 45d8d6feeb Added an improved error message for WebDAV when the server returns 405 - Method not allowed in response to the PROPFIND request 2017-08-29 10:40:31 +02:00
Kenneth Skovhede 0c68daff6c Fixed all whitespace to be 4 spaces instead of tabs 2016-09-15 11:39:27 +02:00
Kenneth Skovhede 3005594b38 Merge branch 'master' into nuget_setup
# Conflicts:
#	Duplicati/GUI/Duplicati.GUI.TrayIcon/Duplicati.GUI.TrayIcon.csproj
#	Duplicati/Library/Backend/S3/Duplicati.Library.Backend.S3.csproj
#	Duplicati/Library/Backend/S3/S3Wrapper.cs
#	thirdparty/CoCoL/CoCoL.dll
#	thirdparty/SSH.NET/Renci.SshNet.dll
2016-06-27 15:25:52 +02:00
Kenneth Skovhede 6c2636f231 Added logic to check for backends with the +s convention for SSL support.
This fixes #1778
2016-06-24 14:20:12 +02:00
Kenneth Skovhede d0711011a2 Rewrote all WebRequest code to use AsyncHttpRequest, and normalized usage such that WebResponse objects are always correctly disposed. 2016-04-16 11:12:28 +02:00
Kenneth Skovhede 59cc0005a3 Removed unused references and updated most libraries to come from NuGet sources instead of being provided in the thirdparty library 2016-01-29 10:47:39 +01:00
Kenneth Skovhede da0535c824 Move the WebRequest inside the try/catch region to fix a 404 not being captured.
This fixes #992.
2015-07-02 21:43:21 +02:00
Kenneth Skovhede 3149064cde Merge branch 'no_more_resx' 2015-01-20 21:45:54 +01:00
Kenneth Skovhede 8d13e698eb Updated copyright notices 2015-01-20 21:44:52 +01:00
Kenneth Skovhede 16c791f0b5 Removed all resx files, now using Duplicati.Library.Localization exclusively 2015-01-20 21:07:24 +01:00
Kenneth Skovhede 738c111397 Added detection for throwing FileMissingException to all backends 2014-11-15 15:00:12 +01:00
Kenneth Skovhede 86abc7565a Added locally allocated buffers for copystream to reduce pressure on allocator 2014-11-10 18:38:18 +01:00
Kenneth Skovhede f935af9968 Reworked the ReadWriteTimeout usage to avoid premature timeouts on Mono 2014-07-11 01:07:48 +02:00
Kenneth Skovhede 7a5a18a4dc Fixed parsing bug with webdav after the URI update 2013-05-13 22:36:24 +02:00
Kenneth Skovhede d3f4058057 Fixed various minor issues with backends 2013-05-06 20:36:26 +02:00
Kenneth Skovhede e5b3f0ea93 Rewrote all backends to use the new Uri parser.
Updated the regex to be a little more forgiving.
Does not handle paths with @, like "ftp://server/@folder"
2013-05-05 23:46:00 +02:00
Kenneth Skovhede 62c75d9af9 Removed all informs code (no more 1.3.x UI) 2013-05-05 17:07:24 +02:00
Kenneth Skovhede 9d09cb473d Renamed ftp-password to auth-password and ftp-username to auth-username 2013-05-05 16:40:37 +02:00
kenneth@hexad.dk f8dc5bbafd Added the "Password" type to argument types for simplified handling of password masking.
git-svn-id: https://duplicati.googlecode.com/svn/trunk@1509 59da171f-624f-0410-aa54-27559c288bec
2013-01-22 09:28:43 +00:00
kenneth@hexad.dk 282fb41605 Update issue #671
Status: Fixed

Now setting PreAuthenticate to "true" for all requests, that should speed things up a bit.

git-svn-id: https://duplicati.googlecode.com/svn/trunk@1377 59da171f-624f-0410-aa54-27559c288bec
2012-07-28 10:03:33 +00:00
kenneth@hexad.dk c74092f8a9 Fixed some timeout/abort issues by implementing everything by hand, on top of the async methods.
Now the WebRequest.Timeout property ONLY affects the GetRequestStream() and GetResponse() methods as the documentation says it SHOULD.

git-svn-id: https://duplicati.googlecode.com/svn/trunk@1331 59da171f-624f-0410-aa54-27559c288bec
2012-06-06 12:55:48 +00:00
kenneth@hexad.dk 2d5e198056 Update issue #513
Another url compare trick

git-svn-id: https://duplicati.googlecode.com/svn/trunk@1045 59da171f-624f-0410-aa54-27559c288bec
2011-12-02 10:37:56 +00:00
kenneth@hexad.dk 0427c08cf4 Update issue #513
I have added an untested fix to trunk, can you please try it, and let me know if it works?

git-svn-id: https://duplicati.googlecode.com/svn/trunk@1042 59da171f-624f-0410-aa54-27559c288bec
2011-11-29 09:04:18 +00:00
kenneth.skovhede@gmail.com 1048994973 Removed some unused storage of options, this fixes a connection bug in FTP, and TahoeLAFS
git-svn-id: https://duplicati.googlecode.com/svn/trunk@938 59da171f-624f-0410-aa54-27559c288bec
2011-10-19 05:42:32 +00:00
kenneth.skovhede@gmail.com 0b8b0d44ea Update issue #392
Status: Fixed

There is now a more consistent parsing of boolean commandline parameters.

git-svn-id: https://duplicati.googlecode.com/svn/trunk@918 59da171f-624f-0410-aa54-27559c288bec
2011-09-27 05:35:49 +00:00
kenneth.skovhede@gmail.com f6932455a0 Minor fixes to WEBDAV, and a createFolder fix for FTP, WEBDAV and TahoeLAFS when using SSL.
git-svn-id: https://duplicati.googlecode.com/svn/trunk@819 59da171f-624f-0410-aa54-27559c288bec
2011-06-29 06:29:12 +00:00
kenneth.skovhede@gmail.com 9c8b07289a Added a debug option for the WEBDAV PROPFIND command.
git-svn-id: https://duplicati.googlecode.com/svn/trunk@805 59da171f-624f-0410-aa54-27559c288bec
2011-06-16 16:43:35 +00:00
kenneth.skovhede@gmail.com 44126105af Fixed default port for SSL connections over WebDAV
git-svn-id: https://duplicati.googlecode.com/svn/trunk@804 59da171f-624f-0410-aa54-27559c288bec
2011-06-16 16:27:54 +00:00