Commit Graph
1925 Commits
Author SHA1 Message Date
Kenneth Hsu b4bef4bea0 Clarify comment. 2019-11-29 09:10:27 -08:00
Kenneth Hsu a47175a945 Fix bug in keep-versions logic where dangling partials were removed.
If the most recent backups were partials (and not followed by a full
backup), they should not be removed.  A partial backup should only be
removed if it is followed by a full backup.

This concerns issue #3982.
2019-11-29 09:10:27 -08:00
Kenneth Hsu fa3ffb7540 Add comment to explain download of dlist files during direct restore. 2019-11-28 20:16:57 -08:00
HendrikandGitHub 057a012277 Merge pull request #3998 from drwtsn32x/fix-attribute-masking
Disable file attribute masking on Windows 10
2019-11-27 11:38:27 +01:00
drwtsn32x 942d8b820d removed getter 2019-11-26 19:27:46 -08:00
Kenneth Hsu 861f0ffa1b Ensure that one full backup is kept when processing keep-time.
this concerns issue #3982.
2019-11-23 12:20:56 -08:00
drwtsn32x f599336bf0 tweak for codacity 2019-11-22 08:26:38 -08:00
drwtsn32x 77a1e3b88a disable attribute masking 2019-11-22 08:00:58 -08:00
Kenneth Hsu cd08ca919a Include fileset file in synthetic filelist.
We declare this to be a partial backup, with the presumption being that
a synthetic filelist is only created when a backup is interrupted.

This concerns issue #3982.
2019-11-21 19:14:48 -08:00
Kenneth Hsu 51b4ecfb28 Include fileset file in dlist files after purge operation.
This concerns issue #3982.
2019-11-21 19:08:55 -08:00
HendrikandGitHub c37eb1680d Merge pull request #3995 from drwtsn32x/fix-issue-3971
Fix issue 3971 - Don't store USN journal data for partial backups
2019-11-21 22:46:51 +01:00
Kenneth Hsu 0cfce6be39 Include fileset file when repairing missing dlist file.
This concerns issue #3982.
2019-11-20 22:19:03 -08:00
User 8755390dc8 don't store journal data for partial backups 2019-11-20 20:46:27 -08:00
Kenneth Hsu 8ab64071f0 Display correct backup type when using direct restore.
Previously, all filesets would be displayed as partial.  Now, we obtain
the partial/full type from the fileset file (not the fileset.json) file
in the dlist file.  If this file does not exist, the backup type
defaults fo full.

Note that this requires downloading and uncompressing the dlist file, so
performance of populating the restore list may be impacted
significantly.

This concerns issue #3982.
2019-11-20 20:23:48 -08:00
drwtsn32x 8f9ec70680 only warn if delete failure is confirmed 2019-11-19 20:28:14 -08:00
Kenneth Hsu 17d72be7ff Remove intermediate partial backups in delete handler.
If surrounded by full backups, partial backups are assumed to be no
longer necessary.

This concerns issue #3982.
2019-11-19 19:48:40 -08:00
Kenneth Hsu 4950e7c225 Unhide partial filesets from Sets property getter.
This concerns issue #3982.
2019-11-19 19:30:01 -08:00
Kenneth Hsu c395e77bc2 Unhide partial filesets from QuickSets property getter.
This concerns issue #3982.
2019-11-19 19:29:59 -08:00
Kenneth Hsu d60248e26a Unhide partial filesets from FilesetTimes property getter.
This concerns issue #3982.
2019-11-19 19:29:52 -08:00
Kenneth Hsu 93bc478d37 Issue warning when backup is cancelled by user.
Previously, a yellow warning icon would be displayed but the logs did
not contain any details regarding the cause of the warning.

This concerns issue #3982.
2019-11-10 11:20:11 -08:00
Fish 3cf01b7297 Advance the progress bar when files are skipped. Fixes #3407.
According to the current implementation, the progress bar does not advance
when files are skipped by FilePreFilterProcess. This causes users'
confusion since the web frontend will get stuck at a certain stage for a
long time. This commit addresses this issue.
2019-11-03 21:34:21 -07:00
Tyler Gill e14be62c2b Make the temp file the default and only bevavior - fileset volume no longer uses memory stream 2019-11-01 19:27:49 -06:00
Tyler Gill bc0686794a Cache to disk 2019-10-30 17:30:47 -06:00
Kenneth SkovhedeandGitHub 99d0cb3c57 Merge pull request #3953 from warwickmm/make_fields_readonly
Mark fields that don't need to be reassigned as readonly
2019-10-21 08:36:17 +02:00
Kenneth Hsu 2aa76881a5 Mark fields that don't need to be reassigned as readonly.
This makes it explicit at compile-time that these fields should not be
reassigned outside the constructor.
2019-10-19 13:59:22 -07:00
Kenneth Hsu afab61a05b Use pattern matching to simplify casts. 2019-10-19 10:15:38 -07:00
Kenneth SkovhedeandGitHub e0d5a7d43e Merge pull request #3929 from warwickmm/bugfix/purge_with_simple_filter
Fix purge operation with simple filters and case-sensitive filesystems
2019-10-19 14:27:18 +02:00
Kenneth SkovhedeandGitHub 4bb0c507a2 Merge pull request #3930 from warwickmm/dispose_volume_writers
Ensure that instances of VolumeWriterBase are disposed
2019-10-19 14:24:55 +02:00
Kenneth SkovhedeandGitHub 579f9911d5 Merge pull request #3938 from warwickmm/bugfix/wrong_dblock_in_dindex
Ensure that dindex references correct dblock file after renames
2019-10-19 14:19:11 +02:00
Kenneth SkovhedeandGitHub 880459d1b7 Merge pull request #3925 from warwickmm/bugfix/missing_filelist
Ensure that filelist is always included in dlist files
2019-10-19 14:08:27 +02:00
Kenneth SkovhedeandGitHub fb0e6cb298 Merge pull request #3940 from warwickmm/fix_xml_documentation
Fix internal XML documentation for restore-symlink-metadata
2019-10-19 13:55:16 +02:00
Kenneth Hsu 7296b96f04 Fix internal XML documentation for restore-symlink-metadata.
The previous documentation appears to have been a copy/paste error.
2019-10-06 09:55:33 -07:00
warwickmmandGitHub 25b714561e Merge pull request #3939 from drwtsn32x/roll-back-pr3846
Fix restore from backup set containing only a single file
2019-10-05 13:49:07 -07:00
drwtsn32x dc87ca1873 remove namespace reference 2019-10-05 11:39:05 -07:00
drwtsn32x 176558d68d roll back pr 3846 2019-10-05 11:34:49 -07:00
Kenneth Hsu 1c492647ae Rename method parameter for consistency. 2019-10-05 11:25:22 -07:00
Kenneth Hsu 0cdc5b9159 Ensure that dindex contains correct dblock file after renames.
When support for parallel uploads was implemented, we overlooked a case
where a failed put of a dblock file is retried with a different
filename.  In this case, an instance of TemporaryIndexVolume was created
in the DataBlockProcessor or SpillCollectorProcess prior to the
attempted put.  The put would fail, and then retried with a different
filename.  While the Remotevolume table in the database would reflect
the new filename, the TemporaryIndexVolume still contained a reference
to the old dblock filename.  This would cause issues in direct restores,
etc., when the referenced dblock file could not be found.

Now, the TemporaryIndexVolume is only created after the dblock put has
completed.

This addresses issue #3932.
2019-10-05 10:46:39 -07:00
Kenneth Hsu 614ccaf79d Convert duplicated static methods into instance method. 2019-10-04 21:37:33 -07:00
warwickmmandGitHub 3b0525e2f8 Merge pull request #3928 from drwtsn32x/improve-purge-logging
Add progress logging for purge operation.
2019-09-29 13:24:13 -07:00
Kenneth Hsu 2f29df5c7e Fix incorrect comment. 2019-09-29 09:52:35 -07:00
Kenneth Hsu 9333517950 Fix query used by purge operation for case-sensitive fileystems.
The table we are inserting into should contain the files that are to be
deleted, not the files that are to be kept.

This fixes issue #3927.
2019-09-29 09:52:35 -07:00
drwtsn32x 64a3c16030 Add X of Y logging for purge operation 2019-09-29 09:42:47 -07:00
Kenneth Hsu b6123cc156 Ensure that IndexVolumeWriter is disposed. 2019-09-28 10:33:34 -07:00
Kenneth Hsu 54992d5beb Ensure that BlockVolumeWriter is disposed. 2019-09-28 10:31:37 -07:00
Kenneth Hsu bc975dd090 Ensure that IndexVolumeWriter is disposed. 2019-09-28 10:30:13 -07:00
Kenneth Hsu 8d7c6c6e21 Ensure that filelist is always written to dlist files.
This fixes a regression introduced around revisions e0899a2a91 ("add
method to add the filelist file") and 3b5af1cf01 ("add method to add
filelist file"), where the filelist was not written by all usages of the
FilesetVolumeWriter.  Previously, one would have to invoke
AddFilelistFile with each usage.  Now, we simply do so when the
FilesetVolumeWriter is closed.

We also modified the UploadSyntheticFilelist so that the usage of the
FilesetVolumeWriter is contained in a using statement, which will ensure
that it is disposed.

This fixes issue #3924.
2019-09-27 20:35:06 -07:00
warwickmmandGitHub 044412274b Merge pull request #3922 from BlueBlock/handle-remotevolume-delete-for-old-data
Remove deleted Remotevolume records stored in old tick format
2019-09-23 20:53:13 -07:00
BlueBlock cd4b653771 fix sql and comment 2019-09-23 05:22:06 -04:00
Kenneth SkovhedeandGitHub 025d4e8b4a Updated symlink text as suggested
https://forum.duplicati.com/t/symlink-follow/8082/3
2019-09-23 09:14:18 +02:00
BlueBlock 75335414d5 add comment 2019-09-21 10:31:07 -04:00