Commit Graph
3969 Commits
Author SHA1 Message Date
Kenneth Skovhede b534c5649e Fixed a shared buffer being re-used for multiple results. 2018-06-06 08:37:09 +02:00
Kenneth Hsu 08a897d7b0 Remove redundant calls to ToString. 2018-06-04 20:15:34 -07:00
Tyler Gill 5be38df560 Fix typo in OAuthHttpClient 2018-06-04 14:59:58 -06:00
Kenneth Skovhede d042e70ca2 Changed the returned IEnumerable values to be fully created, which avoids issues with locks and transactions being prematurely released.
This might help with #3202
2018-06-04 11:56:54 +02:00
Kenneth Skovhede e6535e2cfa Merge branch 'master' of github.com:duplicati/duplicati
# Conflicts:
#	Duplicati/Server/WebServer/RESTMethods/UISettings.cs
2018-06-04 10:48:11 +02:00
Kenneth SkovhedeandGitHub 448d37f7cb Merge pull request #3252 from warwickmm/remove_string_format
Remove unnecessary calls to String.Format
2018-06-04 10:42:02 +02:00
Kenneth SkovhedeandGitHub 66e5dfe722 Merge pull request #3237 from tygill/fix/msgraph-delete-error
(MS Graph) When the delete operation fails due to a 'file not found' error, we don't need to bubble up an exception
2018-06-04 10:41:16 +02:00
Kenneth SkovhedeandGitHub 3b6c2b61d5 Merge pull request #3242 from warwickmm/remove_ineffective_statements
Remove ineffective statements
2018-06-04 10:40:32 +02:00
verhoek 40b83fe2dc Moved out AboutInfoUrl and CreateFolderUrl. 2018-06-03 19:46:54 +02:00
Tyler Gill f2f5d4c0a6 Change from swallowing delete errors to wrapping DriveItemNotFoundException in FileMissingException.
This way, the regular backend manager logic can handle and log the delete of a non-existant file.
Also update some of the other operations to throw FileMissingException (rather than the backend specific DriveItemNotFoundException).
2018-06-02 15:52:20 -06:00
Kenneth Hsu afdae80716 Fix line ending issues. 2018-06-02 13:19:49 -07:00
Kenneth Hsu 20f2f37806 Remove unnecessary calls to String.Format. 2018-06-02 12:02:55 -07:00
Kenneth SkovhedeandGitHub e70f15287e Merge pull request #3233 from warwickmm/make_fields_readonly
Mark fields that shouldn't be reassigned as readonly
2018-06-02 10:13:06 +02:00
verhoek c063fde018 Moved ListUrl, PutUrl and DeleteUrl to WebApi. 2018-06-01 16:21:28 +02:00
verhoek 83679c0f12 Moved Rename and Get Url to Google WebAPI. 2018-05-30 08:22:00 +02:00
verhoek 3691d6dfdf Initiated basic unit tests to ensure correct url helper functions. 2018-05-29 22:13:09 +02:00
verhoek 1ba8814d76 Started moving url specific construction to webapi. 2018-05-28 08:29:23 +02:00
verhoek 4a0d6a2f5b Inline var declaration. 2018-05-27 13:12:59 +02:00
verhoek 6287d369b1 Reverted accidental removing of static for SystemContextSettings. 2018-05-27 13:12:06 +02:00
verhoek 625db54f14 Throw proper exception. Removed unused imports. 2018-05-27 13:10:01 +02:00
verhoek a9b88ab2ab Return default settings in case no startcontext was previously called
by returning a null contextid.
2018-05-27 10:23:22 +02:00
verhoek a108e328b6 Fix codacy issues. 2018-05-26 23:27:39 +02:00
verhoek 3fd6c3c602 Merge remote-tracking branch 'origin' into feature/tempdir 2018-05-26 22:55:29 +02:00
verhoek e80f30f8a9 Added multiple context setting keys to callcontextsettings, exploiting
reflection. Contextsettings don't destroy each other anymore.
2018-05-26 21:56:15 +02:00
Kenneth Hsu bbe65f9dfb Remove ineffective statements.
The removed code was introduced in revision ba58651e5a ("Fix for
CreateFolder with SSH"), presumably to fix an issue where some SSH
backends did not like the trailing slash when creating new folders.
However, since we are not using the output argument of the call to
Substring, these statements have no effect.
2018-05-26 10:36:50 -07:00
Kenneth Hsu f12858e6a5 Mark fields that shouldn't be reassigned as readonly.
This makes it explicit at compile-time that these fields should not be
reassigned outside the constructor.
2018-05-25 10:04:52 -07:00
Kenneth Hsu ee8788d08e Use Equals to compare CultureInfo instances.
Since the Equals method is overridden in the CultureInfo class, we
should use it instead of the == operator to compare two instances.
2018-05-25 10:04:28 -07:00
Tyler Gill 8131e85581 (MS Graph) When the delete operation fails due to a 'file not found' error, we don't need to bubble up an exception. 2018-05-25 09:18:20 -06:00
Tyler Gill 8acc9ba5c9 Blocksets with a length of 0 are not broken if the block they reference by hash is not listed. 2018-05-24 15:22:05 -06:00
Kenneth SkovhedeandGitHub a7575d6bda Merge pull request #3229 from verhoek/bugs/commandline
Bugfixes commandline
2018-05-24 11:28:40 +02:00
verhoek 4972c9c865 Merge branch 'webapi/googlecloudstorage' of https://github.com/verhoek/duplicati into webapi/googlecloudstorage 2018-05-23 21:20:31 +02:00
verhoek bbf5d71782 Merge branch 'master' into webapi/googlecloudstorage 2018-05-23 20:14:06 +02:00
verhoek 7556c3fa63 Merge branch 'master' into feature/tempdir 2018-05-23 20:13:48 +02:00
verhoek 67c8929759 wip 2018-05-23 19:37:49 +02:00
Kenneth SkovhedeandGitHub fd26732e1f Merge pull request #3228 from warwickmm/use_string_join
Simplify construction of query parameter string
2018-05-23 11:11:02 +02:00
Kenneth SkovhedeandGitHub 19851c88f0 Merge pull request #3227 from warwickmm/use_string_builder
Replace string concatenation with StringBuilder
2018-05-23 11:10:36 +02:00
verhoek 7bf1768f80 Implemented default tempdir for backend server. 2018-05-22 21:51:29 +02:00
Tyler Gill bbdf4c2747 Add more broken file detection:
Blocksets with either blockset entires or blocklist entries that refer to invalid / unreachable blocks are now treated as broken as well.
2018-05-21 10:16:51 -06:00
verhoek e4398d3b68 Fixed broken help output in commandline.
E.g. "help find" works again.
2018-05-20 16:51:53 +02:00
verhoek cac891d187 Added BucketObjectPath helper method. 2018-05-20 11:10:37 +02:00
verhoek 13ef221196 Updated Rename method. 2018-05-20 10:57:49 +02:00
verhoek 745b77da23 Renamed WebApi GoogleCloudServices to GoogleCloudStorage. Refactored Get. Fixed Layout. 2018-05-20 10:50:37 +02:00
Kenneth Hsu 2384e6eb30 Simplify construction of query parameter string. 2018-05-19 16:12:12 -07:00
Kenneth Hsu 0b016cea2c Replace string concatenation with StringBuilder.
When appending to a string in a loop, using a StringBuilder should in
general yield better performance.
2018-05-19 15:36:00 -07:00
verhoek 18de687530 Updated Put and Createfolder using WebApi. 2018-05-19 23:06:02 +02:00
verhoek d6a85ae497 Imports organized, bucket locations moved to google webapi. 2018-05-18 23:00:01 +02:00
verhoek 41234a314d Introduced UrlPath wrapper for stringbuilder to ease concatenation of multiple paths.
Started cleaning googlecloud services API.
2018-05-18 22:55:09 +02:00
verhoek 2f41e02ca9 Merge branch 'master' into refactored 2018-05-18 08:05:19 +02:00
Tyler Gill b5931b2771 Adds a check for BlocksetIDs that don't have any corresponding BlocksetEntrys to the broken fileset check.
Bug #3210 (and several other possibly related ones) had cases where a recreated database would have these invalid blockset IDs.
It seems like they were caused by filesets referring to a blockset by hash, but not having any index or block file actually containing the block for that hash.
Also fixes countMissingInformation query - it should join with missingBlocklistVolumes, rather than missingBlocklistEntries, as it is selecting the VolumeID.
2018-05-17 08:11:13 -06:00
Kenneth SkovhedeandGitHub b7b4fbe778 Merge pull request #3221 from verhoek/webapi/googledrive
Webapi/googledrive
2018-05-17 14:44:50 +02:00