Commit Graph
431 Commits
Author SHA1 Message Date
Max b008aed1f3 migrate to net5 + runnable 2020-06-03 00:00:38 +02:00
Max 3f2eb254c3 buildable again 2020-05-31 14:38:14 +02:00
Max c882953fdd upstream 2020-05-31 13:50:13 +02:00
Sean Templeton d5e064ae45 Fix a few more issues with stop now
When a backup is interrupted it will now show as a partial backup in the list of backups on the restore files page.

Temporary filelist volumes are protected from deletion in several places. All but the RestoreHandler
only protect the most recent filelist. The RestoreHandler protects all temporary filelist volumes as the user
might be restoring from one that would be deleted.

Prevent the CoCoL BackendRequests channel is retired exception from appearing when the backup is stopped by checking
if the channel is retired before trying to add the FlushRequest to the channel. Any exceptions from the BackendUploader
task will still be thrown.
2020-03-01 21:19:07 -06:00
Sean Templeton 446120ae3e A synthetic filelist could not be uploaded due to the logic in UploadSyntheticFilelist. The code passing in the fileset id to the class would get the id based on if the volume was in the Temporary or Uploading states. If the volume was in the Uploading state, present on the remote backend, and of the right size it would get changed to Uploaded.
One of the first things UploadSyntheticFilelist does is throw an exception if the volume is not in the Uploaded state. Or if it is in the Uploaded state, the next check would prevent a synthetic filelist from being created if the volume was not in the Uploading or Temporary states.

Removed the check for the volume not being in the Uploaded state as the warning in the second check handles that case.

Removed the using statement as it would dispose of the FilesetVolumeWriter after passing it to the UploadChannel. The UploadChannel could not use it since it had been disposed.

Fixed the GetRemoteVolumeFromIDAsync taking a fileset id and matching it up against a volume id. Now it will use fileset id to get the volume that matches the fileset.

Change the StopNow disruption test to not use a synthetic file list. The test was written with it not working and therefore fails a check on the number of filesets after stopping a backup.

Bonus fix for a possible null exception in Dispose for VolumeWriterBase.
2020-02-23 16:50:36 -06:00
Kenneth Hsu f0068456fd Disable warning about unused constructor.
This is used in the SVNCheckoutTests class.
2020-02-17 12:38:58 -08:00
Kenneth Hsu 89db40c211 Disable warning about unused constructor.
This is used in the SVNCheckoutTests class.
2020-02-17 12:38:38 -08:00
Kenneth Hsu 7cfed6a62b Remove unused LogHelper.Backupset property.
This property (and its backing field m_backupset) is only set and never
referenced.
2020-02-17 09:52:12 -08:00
Kenneth Hsu 917f749b0a Add RepairHandlerTests to solution.
This was accidentally removed via a bad merge in revision
a64671a0c6.
2020-01-25 18:59:44 -08:00
Kenneth Hsu 5ff5961019 Test RecoveryTool using file-based and in-memory index. 2020-01-23 20:45:49 -08:00
Kenneth SkovhedeandGitHub a64671a0c6 Merge pull request #4018 from warwickmm/refactor/fileset_removal
Refactor fileset deletion code and add tests
2020-01-23 13:52:43 +01:00
Kenneth Hsu 30ea3c05da Fix typo in comment. 2020-01-22 17:44:12 -08:00
Kenneth Hsu ec7d6dcc9f Merge remote-tracking branch 'upstream/master' into test/recovery_tool 2020-01-21 20:30:02 -08:00
Kenneth Hsu 35ea890f96 Merge remote-tracking branch 'upstream/master' into refactor/fileset_removal 2020-01-21 20:23:49 -08:00
warwickmmandGitHub 837a787cbf Merge pull request #4047 from warwickmm/bugfix/repair_missing_dindex
Fix bug when performing repair with missing dindex files
2020-01-21 19:46:36 -08:00
Kenneth Hsu 6a6224a10a Reset current directory before removing test files.
The RecoveryTool sets the currenty directory during its operation.  We
must reset the current directory so that the test teardown methods do
not complain that paths are being used by other processes.
2020-01-18 14:44:05 -08:00
Kenneth Hsu bfbae6fcaf Add test for restoring files using RecoveryTool. 2020-01-18 09:36:03 -08:00
Kenneth Hsu 1892ba8d0a Fix poorly named test file. 2020-01-10 20:12:01 -08:00
Kenneth Hsu adc3249b9f Assert that dindex files exist. 2020-01-09 21:32:33 -08:00
Kenneth Hsu 91db2466ec Add test for repairing with missing dindex files.
This concerns issue #4046.
2020-01-09 20:18:42 -08:00
Kenneth Hsu f63e703a66 Add test for interrupting backup with "stop now". 2020-01-06 10:00:35 -08:00
warwickmmandGitHub 1663148479 Merge pull request #4034 from warwickmm/test/no_local_db_list
Add test for listing filesets without local database
2020-01-06 09:20:40 -08:00
warwickmmandGitHub 29f785dfde Merge pull request #4033 from warwickmm/test/fileset_files
Add tests to verify fileset files after purge and repair operations
2020-01-06 09:20:19 -08:00
Kenneth Hsu 6345489398 Fix formatting issues. 2020-01-01 14:13:40 -08:00
Kenneth Hsu fdcef72a7c Merge remote-tracking branch 'upstream/master' into refactor/fileset_removal 2020-01-01 13:58:59 -08:00
Kenneth Hsu bde4812bff Add test for restoring permissions with inheritance breaks. 2020-01-01 12:47:01 -08:00
Kenneth Hsu d3bcd3fb4a Add test for listing filesets without local database.
This test would have failed prior to the changes in revision 8ab64071f0
("Display correct backup type when using direct restore").  Prior to
revision 8ab64071f0, all filesets would have been marked as partial when
performing a direct restore without the local database.

This concerns issue #3982.
2019-12-30 16:35:41 -08:00
Kenneth Hsu 7494abec63 Add test to verify that fileset file exists after repair.
This test would have failed prior to the changes in revision 0cfce6be39
("Include fileset file when repairing missing dlist file").

This concerns issue #3982.
2019-12-30 15:15:15 -08:00
Kenneth Hsu d3f752279f Add test to verify that fileset file exists after purge.
This test would have failed prior to the changes in revision 51b4ecfb28
("Include fileset file in dlist files after purge operation").

This concerns issue #3982.
2019-12-30 15:15:15 -08:00
Max 7e2218663e Add Compat Analyzers 2019-12-25 19:08:52 +01:00
Max 28793ef204 packages update 2019-12-25 18:21:24 +01:00
Max 41a5591532 upstream 2019-12-25 16:34:56 +01:00
Kenneth Hsu 55a42f1f33 Remove unused methods.
These were generated automatically, but are unnecessary since we only
compare equality with other Filesets.
2019-12-23 19:15:26 -08:00
Kenneth Hsu 83ac03843d Fix spelling errors in comments.
In doing so, we also normalized some line endings.
2019-12-14 09:52:55 -08:00
Kenneth Hsu 6d6be94efa Add tests for fileset deletion strategies. 2019-12-11 18:00:13 -08:00
Kenneth Hsu 7746ff1014 Fix derivation of seconds from TimeSpan.
Although the TimeSpan should be less than one minute, we should still
reference TotalSeconds to be safe.
2019-12-03 18:23:24 -08:00
Kenneth Hsu 30fddd4b91 Add test for retention-policy logic. 2019-11-29 22:18:02 -08:00
Kenneth Hsu 68e7844dae Add test for keep-versions logic where last backup was full.
This concerns issue #3982.
2019-11-29 14:13:15 -08:00
Kenneth Hsu 07df3d4d5e Verify backup times in addition to partial/full status. 2019-11-29 09:14:35 -08:00
Kenneth Hsu b0224194de Allow continutation after await to run in any context. 2019-11-29 09:12:15 -08:00
Kenneth Hsu 8c9512ac2c Add test for keep-versions retention logic. 2019-11-29 09:11:18 -08:00
Kenneth Hsu afecf891da Add test for keep-time retention logic.
We had to remove the keep-versions options since multiple retention
options are not allowed.

This concerns issue #3982.
2019-11-28 21:50:16 -08:00
Kenneth Hsu 9eedf757cd Extract creation of partial backup to helper method. 2019-11-28 21:47:54 -08:00
Kenneth Hsu 1d42c53319 Fix disruption test to expect partial backups in fileset listing.
This concerns issue #3982.
2019-11-19 19:30:03 -08:00
Kenneth Hsu 2aa76881a5 Mark fields that don't need to be reassigned as readonly.
This makes it explicit at compile-time that these fields should not be
reassigned outside the constructor.
2019-10-19 13:59:22 -07:00
Kenneth Hsu ee751f218a Test purge operation with simple filter expression.
This will test the situation described in issue #3927, where the
specified file was kept, and all other files were deleted.

Without the fix in 9333517950 ("Fix query used by purge operation for
case-sensitive fileystems"), this test would pass in AppVeyor (Windows),
but fail in Travis (Linux).
2019-09-29 09:54:25 -07:00
Kenneth Hsu bedecdef1d Allow execution to continue on any thread. 2019-09-17 14:16:58 -07:00
Kenneth Hsu a9ace40723 Increase dblock size to speed up testing. 2019-09-17 12:46:23 -07:00
Kenneth Hsu 2f58de4021 Remove unused using directive. 2019-09-17 12:46:23 -07:00
Kenneth Hsu e9e87a495c Disable warning. 2019-09-17 12:46:23 -07:00