Commit Graph
670 Commits
Author SHA1 Message Date
Kenneth Hsu 0a37b9075d Remove condition that always evaluates to true. 2018-12-15 14:23:02 -08:00
Kenneth Hsu 8dd3aeaf26 Use invariant culture in calls to ToLower and ToUpper. 2018-12-11 21:21:07 -08:00
verhoek 7128544a96 Fix bug that accidentally also handles directories besides files in file backend. 2018-11-26 18:34:52 +01:00
Kenneth Hsu 0143a848f5 Remove unnecessary local variable. 2018-11-21 21:21:38 -08:00
Kenneth Hsu de9750caba Use 'this' keyword to improve readability. 2018-11-21 21:03:09 -08:00
Kenneth Hsu 609c32feb2 Create parent directories as needed for SFTP backend.
If the user specifies a path with multiple directories that do not
exist, the SftpClient.CreateDirectory method does not create all the
missing parent directories.  As such, we have to do so ourselves.

This addresses issue #2080.
2018-11-21 20:38:36 -08:00
Kenneth Skovhede 968261056e Merge branch 'feature/remove_onedrive_v1'
# Conflicts:
#	Duplicati/Library/Backend/OneDrive/OneDrive.cs
2018-11-12 13:02:18 +01:00
Kenneth SkovhedeandGitHub 1b54cd6107 Merge pull request #3456 from verhoek/issue/3311
Refactor the way paths are handled.
This fixes #3311 PathTooLongException when using USNJournal
2018-11-08 12:50:09 +01:00
Kenneth Skovhede 4c1d53f283 Removed the OneDrive v1 backend as it no longer works 2018-11-08 12:46:29 +01:00
Rune Henriksen edefa17b58 updated AWSSDK to newest version 2018-11-04 14:59:38 +01:00
verhoek ab12be6bbd Renamed IsClientLinux to IsClientPosix . 2018-11-03 09:26:04 +01:00
verhoek 72b1f6b6f8 Updated project files. 2018-11-02 22:45:07 +01:00
verhoek 8bb406cd15 Migrated to use the platform class. 2018-11-02 22:17:16 +01:00
verhoek b2cc18426c Renamed Library.IO to Library.Common.IO.
Moved basic Platform functions to Library.Common.Platform.
Turned IO_OS into property within Library.Common.
2018-11-02 21:34:07 +01:00
verhoek 71c6aca8a7 Fixed IO calls in Filebackend.
Moved FileEntry to Library.IO due to AlphaFS not implementing
System.IO.FileInfo/DirectoryInfo.
2018-11-01 17:56:48 +01:00
verhoek 4d8155fa43 Merge remote-tracking branch 'origin/master' into issue/3311 2018-10-29 12:13:25 +01:00
verhoek 52916b935b Replaced System.IO.Path with wrapper call to Alphaleonis. 2018-10-28 12:08:09 +01:00
Kenneth Hsu a567b467dc Fix slashes in Microsoft Graph URLs.
This fixes an issue introduced in revision f9022fec ("Avoid referencing
virtual members in constructor").

This addresses issue #3460.
2018-10-27 13:03:25 -07:00
verhoek bc053df294 Moved basic IO helper functions to Library.IO. 2018-10-27 12:17:07 +02:00
verhoek 40dc6da81d Created separate package for io wrapper. 2018-10-25 20:01:55 +02:00
verhoek d932069b99 Fixed incorrect download files string. 2018-10-24 09:40:16 +02:00
verhoek 0752e0af0d Moved content api strings to webapi. 2018-10-23 16:21:36 +02:00
verhoek 1db6504dea Replaced paths in formatted strings to inner class. 2018-10-23 16:02:14 +02:00
verhoek 630f810cdd Added listfiles url to dropbox's webapi. 2018-10-23 15:46:35 +02:00
verhoek ab86df2ebb Merge branch 'master' into webapi/dropbox 2018-10-23 15:34:00 +02:00
Rune HenriksenandGitHub 6c47c39f2b Merge pull request #3431 from warwickmm/remove_unused_members
Remove unused class members
2018-10-17 00:40:11 +02:00
Kenneth Hsu 9e0b031fee Remove unused members. 2018-10-15 21:20:30 -07:00
Wei Zeng 0abc0dad99 #3430 add US-West support for wasabi 2018-10-16 15:09:43 +11:00
Kenneth Hsu 9374d6b208 Move comments and remove invalid XML tags.
The comment was not placed before a valid language element.
2018-10-13 20:52:30 -07:00
Kenneth Hsu 914b35e342 Escape characters in XML documentation. 2018-10-13 20:52:15 -07:00
Kenneth Hsu 07c1d85b4a Remove empty statements. 2018-10-10 21:22:31 -07:00
Kenneth Hsu 8bb770964d Constrain generic type to be a class to allow for null comparison.
The SendRequest method performs a comparison between an object of type T
and null.  While there are no use cases currently where the generic type
is a value type, we should constrain the generic type to be a class so
that the comparison remains meaningful.
2018-10-08 19:13:23 -07:00
Kenneth Hsu 6c08f44394 Revert "Avoid potential comparison of value type with null."
This reverts commit ecb670a2d9.

While there aren't any cases where the generic type is a struct, the
comparison with default(T) is incorrect.  If T is int, we wouldn't want
the behavior to differ based on whether the value was zero or nonzero.
2018-10-08 18:54:36 -07:00
Rune HenriksenandGitHub aa1f99628c Merge pull request #3414 from warwickmm/avoid_value_null_comparison
Avoid potential comparison of value type with null
2018-10-07 22:35:25 +02:00
Rune HenriksenandGitHub be7edb580d Merge pull request #3410 from warwickmm/simplify_enumerating_collections
Simplify enumeration of collections
2018-10-07 19:06:28 +02:00
Kenneth Hsu ecb670a2d9 Avoid potential comparison of value type with null.
While there aren't currently any cases where the generic type is a value
type, this will make the code slightly more robust to future
implementations.
2018-10-07 09:59:13 -07:00
Kenneth Hsu 0c1ac9c489 Replace chained LINQ calls with call to overload with predicate.
This simplifies the code by reducing the number of enumerators created
while also making the code slightly more readable.
2018-10-06 16:20:18 -07:00
Rune Henriksen 306ccabfef updated MegaApiClient from 1.6.0 to 1.6.3 2018-10-04 00:34:49 +02:00
Kenneth Hsu e2bc85c7e4 Merge remote-tracking branch 'upstream/master' into constructor_virtual_members
Resolved Conflicts:
	Duplicati/Library/Backend/OneDrive/MicrosoftGraphBackend.cs
2018-10-01 17:15:58 -07:00
Rune HenriksenandGitHub 5f4236cbc2 Merge pull request #3399 from duplicati/remove_unused_variables_assignments
Remove unused variables, fields, and unnecessary assignments
2018-10-01 23:19:37 +02:00
Kenneth Hsu 024bc5bea2 Mark immutable field as readonly. 2018-09-30 15:45:42 -07:00
Kenneth Hsu ee14862db5 Add comment to clarify use of Lazy. 2018-09-30 15:06:55 -07:00
Kenneth Hsu f59607d94d Rename property. 2018-09-30 15:06:55 -07:00
Kenneth Hsu f9022fec66 Avoid referencing virtual members in constructor.
Since the call to GetRootPathFromUrl may be expensive, we cache the
value using a lazy initializer.
2018-09-30 15:06:49 -07:00
Kenneth Hsu 7cf830cad7 Provide protocol key to MicrosoftGraphBackend constructor.
This will help us avoid referencing virtual members in the constructor.
2018-09-30 10:59:26 -07:00
Kenneth Hsu 6215fe1ac5 Extract string to private constant.
This will allow us to provide the string as a parameter to the parent
class constructor to avoid referencing virtual members in the
constructor.
2018-09-30 10:56:59 -07:00
Kenneth Hsu 183ae4ede2 Remove additional unused variables. 2018-09-29 12:49:22 -07:00
Kenneth Hsu 9ce1e807c7 Remove unused variables and fields. 2018-09-29 10:41:27 -07:00
Kenneth Hsu 44b7c29489 Rename local variable to avoid hiding class field. 2018-09-28 20:57:44 -07:00
Kenneth SkovhedeandGitHub 0ec49d3a87 Merge pull request #3393 from warwickmm/fix_append_dir_separator
Fix behavior of AppendDirSeparator utility method
2018-09-28 22:24:11 +02:00