Commit Graph
1454 Commits
Author SHA1 Message Date
Kenneth Hsu fcf89764c3 Remove unnecessary calls to ToString. 2018-12-31 14:29:44 -08:00
Kenneth Hsu e65bf19221 Remove unused String.Format arguments.
We also make use of string interpolation to improve readability.
2018-12-31 14:24:14 -08:00
JonMikelVandRune Henriksen fff5145e2f Fix typo in QuotaWarningThresholdLong (#3549)
"quota is less that this" -> "quota is less than this"
2018-12-20 22:07:34 +01:00
Kenneth SkovhedeandGitHub 8d3ed27ac9 Merge pull request #3538 from LacunaSoftware/improve-backup-logs-ui
New improvements on Backup Logs UI
2018-12-13 15:01:16 +01:00
Mikael Mello 965bd6d761 result-classes: rename properties of RestoreResults to be consistent with BackupResults 2018-12-12 12:14:11 -02:00
Kenneth Hsu 8dd3aeaf26 Use invariant culture in calls to ToLower and ToUpper. 2018-12-11 21:21:07 -08:00
Kenneth Skovhede 49e54ab0b7 Merge branch 'feature/timestamp_clash_fix' 2018-12-11 10:33:57 +01:00
Kenneth SkovhedeandGitHub 9f0ceb9a4c Merge pull request #3534 from warwickmm/convert_write_only_properties
Replace write-only properties
2018-12-11 10:31:35 +01:00
Kenneth SkovhedeandGitHub ac606d887f Merge pull request #3510 from LacunaSoftware/improve-backup-logs-ui
Improve UI for backup logs
2018-12-11 10:28:05 +01:00
Kenneth Hsu 5daf35d4f5 Use interface inheritance to remove write-only properites.
The one class that implements these interfaces, BasicResults, requires
both read and write access to these properties.  As such, we might as
well declare the getter and setter in the interface.
2018-12-09 21:42:40 -08:00
Kenneth Hsu 8b6cf0c6d9 Make ISetCommonOptions.MessageSink property readable.
Since the only implementation, BasicResults, specifies a getter for this
property, we might as well declare this in the interface.
2018-12-09 21:42:36 -08:00
Kenneth Hsu a44bc7542f Make ISetCommonOptions.BeginTime property readable.
Since the only implementation, BasicResults, specifies a getter for this
property, we might as well declare this in the interface.
2018-12-09 21:42:33 -08:00
Kenneth Hsu 7e6fa8a202 Convert write-only IMessageSink.OperationProgress property to method.
Write-only properties are confusing and the behavior is better
implemented as a method, which more clearly conveys the write-only
semantics.
2018-12-09 20:23:05 -08:00
Kenneth Hsu 1764b9ad4e Convert write-only IMessageSink.BackendProgress property to method.
Write-only properties are confusing and the behavior is better
implemented as a method, which more clearly conveys the write-only
semantics.
2018-12-09 20:23:05 -08:00
Mikael Mello 3dbfac93c6 basic-results: Increase limit of enumerable elements that are serialized 2018-12-07 16:45:44 -02:00
Kenneth Skovhede 040655b579 Possible fix for #2857 2018-12-07 09:46:10 +01:00
Mikael Mello aa71b888c3 basic-results: Serialize full length of enumerable properties that are limited
Useful to display the know the actual number of errors/warnings/etc when debugging without
having to store all of the errors.
2018-12-05 17:10:08 -02:00
Mikael Mello ec5fee9f9a basic-results: Serialize enumerable properties up to a certain number of elements 2018-12-04 12:14:08 -02:00
Mikael MelloandGitHub 172b0284ab localDatabase: Remove trailing exclamation mark on exception text 2018-12-03 08:13:58 -02:00
Mikael Mello c2c2718082 resultClasses: Fix ParsedResult of RepairResults
RepairResults could have warning/error in its child and not report correct result
2018-11-29 10:57:30 -02:00
Mikael Mello ff2f89f00b Merge branch 'master' of github.com:duplicati/duplicati into improve-backup-logs-ui
# Conflicts:
#	Duplicati/Library/Main/ResultClasses.cs
2018-11-27 10:50:12 -02:00
Mikael Mello 8d1077c901 Fix regression that stopped repairs from working 2018-11-27 10:41:53 -02:00
Mikael Mello 57bd9d1e41 Decouple BasicResults object properties from its children 2018-11-26 11:53:24 -02:00
Kenneth SkovhedeandGitHub f847691ba3 Merge pull request #3506 from verhoek/issue/3498
various GPG changes
2018-11-21 12:41:59 +01:00
verhoek 0ee90d3b4e In between auto refactoring. 2018-11-20 20:08:39 +01:00
Kenneth Hsu aab3afd4a7 Fix class reference in XML documentation. 2018-11-18 17:23:01 -08:00
Mikael Mello 1c94decf6c Serialize backup results in JSON format 2018-11-14 08:47:01 -02:00
Kenneth SkovhedeandGitHub 1b54cd6107 Merge pull request #3456 from verhoek/issue/3311
Refactor the way paths are handled.
This fixes #3311 PathTooLongException when using USNJournal
2018-11-08 12:50:09 +01:00
Mikael Mello f03e8f6c29 Create warning when no files are restored 2018-11-08 08:15:41 -02:00
verhoek ab12be6bbd Renamed IsClientLinux to IsClientPosix . 2018-11-03 09:26:04 +01:00
verhoek 72b1f6b6f8 Updated project files. 2018-11-02 22:45:07 +01:00
verhoek 8bb406cd15 Migrated to use the platform class. 2018-11-02 22:17:16 +01:00
verhoek b2cc18426c Renamed Library.IO to Library.Common.IO.
Moved basic Platform functions to Library.Common.Platform.
Turned IO_OS into property within Library.Common.
2018-11-02 21:34:07 +01:00
verhoek 9fb38ebe9a Continuation of Util.DirectorySeparatorString replacements. 2018-11-02 17:48:17 +01:00
verhoek 1275f14405 Replaced DirectorySeparatorChar.ToString() calls. 2018-11-02 17:45:00 +01:00
verhoek c398dec768 Fixed relevant code issues brought up by codacity. 2018-10-29 12:11:56 +01:00
verhoek bc053df294 Moved basic IO helper functions to Library.IO. 2018-10-27 12:17:07 +02:00
verhoek 40dc6da81d Created separate package for io wrapper. 2018-10-25 20:01:55 +02:00
Rune HenriksenandGitHub 0b3efc5dbb Merge pull request #3439 from warwickmm/constructor_virtual_members
Avoid referencing virtual members in Basiclist constructor
2018-10-18 17:02:29 +02:00
Kenneth Hsu 6f231f9190 Avoid referencing virtual members in Basiclist constructor.
When referencing virtual members in a constructor, the behavior may be
ill-defined as the overridden implementation may depend on uninitialized
instance members.

Since the TABLE_PREFIX, TABLEFORMAT, INSERTCOMMAND, and INSERTARGUMENTS
properties were only referenced in the Basiclist constructor, we can
remove the abstract keyword and provide the values as constructor
parameters.
2018-10-17 20:11:06 -07:00
Kenneth Skovhede 68d2f10475 Merge branch 'master' of github.com:duplicati/duplicati 2018-10-17 14:37:52 +02:00
Kenneth Skovhede 2826dbe6f0 Improved error message for faults in database filelists 2018-10-17 14:37:23 +02:00
Kenneth Skovhede d03a8a759f Spelling fix 2018-10-17 14:36:54 +02:00
Rune HenriksenandGitHub 6c47c39f2b Merge pull request #3431 from warwickmm/remove_unused_members
Remove unused class members
2018-10-17 00:40:11 +02:00
Kenneth Hsu 9e0b031fee Remove unused members. 2018-10-15 21:20:30 -07:00
Kenneth Hsu e16ab43d86 Fix typo in log message id. 2018-10-15 21:14:59 -07:00
Rune HenriksenandGitHub d86c6cce61 Merge pull request #3424 from warwickmm/flatten_aggregate_exceptions
Flatten AggregateExceptions before referencing InnerException
2018-10-14 12:21:12 +02:00
Kenneth Hsu 1d57ddd5a6 Flatten AggregateExceptions before referencing InnerException.
The InnerException property of an AggregateException can be another
AggregateException.  By calling Flatten(), we remove inner
AggregateExceptions so that the InnerExceptions property contains all
the original exceptions.  The InnerException property is the first
element of InnerExceptions.
2018-10-13 19:07:49 -07:00
Kenneth Hsu beb552fa9e Remove unnecessary use of partial keyword.
These classes are defined in a single location.
2018-10-13 16:53:28 -07:00
Kenneth Hsu 07c1d85b4a Remove empty statements. 2018-10-10 21:22:31 -07:00