haeaeae/duplicati
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
6,174 Commits 140 Branches 416 Tags
edbc7cd732b24e334e39e012663705308f3cd310
Commit Graph
391 Commits
Author SHA1 Message Date
Kenneth Hsu fcf89764c3 Remove unnecessary calls to ToString. 2018-12-31 14:29:44 -08:00
Kenneth Hsu e65bf19221 Remove unused String.Format arguments. 
We also make use of string interpolation to improve readability.
 2018-12-31 14:24:14 -08:00
Kenneth SkovhedeandGitHub ac606d887f Merge pull request #3510 from LacunaSoftware/improve-backup-logs-ui 
Improve UI for backup logs
 2018-12-11 10:28:05 +01:00
Mikael MelloandGitHub 172b0284ab localDatabase: Remove trailing exclamation mark on exception text 2018-12-03 08:13:58 -02:00
Mikael Mello ff2f89f00b Merge branch 'master' of github.com:duplicati/duplicati into improve-backup-logs-ui 
# Conflicts:
#	Duplicati/Library/Main/ResultClasses.cs
 2018-11-27 10:50:12 -02:00
Mikael Mello 1c94decf6c Serialize backup results in JSON format 2018-11-14 08:47:01 -02:00
verhoek ab12be6bbd Renamed IsClientLinux to IsClientPosix . 2018-11-03 09:26:04 +01:00
verhoek 8bb406cd15 Migrated to use the platform class. 2018-11-02 22:17:16 +01:00
verhoek b2cc18426c Renamed Library.IO to Library.Common.IO. 
Moved basic Platform functions to Library.Common.Platform.
Turned IO_OS into property within Library.Common.
 2018-11-02 21:34:07 +01:00
verhoek 9fb38ebe9a Continuation of Util.DirectorySeparatorString replacements. 2018-11-02 17:48:17 +01:00
verhoek c398dec768 Fixed relevant code issues brought up by codacity. 2018-10-29 12:11:56 +01:00
verhoek bc053df294 Moved basic IO helper functions to Library.IO. 2018-10-27 12:17:07 +02:00
Rune HenriksenandGitHub 0b3efc5dbb Merge pull request #3439 from warwickmm/constructor_virtual_members 
Avoid referencing virtual members in Basiclist constructor
 2018-10-18 17:02:29 +02:00
Kenneth Hsu 6f231f9190 Avoid referencing virtual members in Basiclist constructor. 
When referencing virtual members in a constructor, the behavior may be
ill-defined as the overridden implementation may depend on uninitialized
instance members.

Since the TABLE_PREFIX, TABLEFORMAT, INSERTCOMMAND, and INSERTARGUMENTS
properties were only referenced in the Basiclist constructor, we can
remove the abstract keyword and provide the values as constructor
parameters.
 2018-10-17 20:11:06 -07:00
Kenneth Skovhede 68d2f10475 Merge branch 'master' of github.com:duplicati/duplicati 2018-10-17 14:37:52 +02:00
Kenneth Skovhede 2826dbe6f0 Improved error message for faults in database filelists 2018-10-17 14:37:23 +02:00
Kenneth Hsu 9e0b031fee Remove unused members. 2018-10-15 21:20:30 -07:00
Kenneth Hsu beb552fa9e Remove unnecessary use of partial keyword. 
These classes are defined in a single location.
 2018-10-13 16:53:28 -07:00
Kenneth Hsu 07c1d85b4a Remove empty statements. 2018-10-10 21:22:31 -07:00
Kenneth Hsu d72128ec83 Remove unused method parameters. 2018-10-06 15:09:43 -07:00
Kenneth Hsu 9ce1e807c7 Remove unused variables and fields. 2018-09-29 10:41:27 -07:00
Kenneth Hsu f4f676a1de Remove unnecessary variable assignment. 
These variables are assigned values that are never read by any
subsequent instruction.
 2018-09-28 20:13:45 -07:00
Kenneth Skovhede 809ba9a856 Changed the default query to be v==2, as multiple users reported this to be fastest. 
The previous default query is now v==4.

Added an additional v==3, and a `LIMIT 1` clause to v==4 as suggested here:
https://forum.duplicati.com/t/release-2-0-3-10-canary-2018-08-30/4497/25
 2018-09-05 10:12:28 +02:00
Kenneth Skovhede ca1872ce57 Added an option to disable filelist consistency checks as it was reported to slow backups with a large number of filesets. 
This addresses #3194
 2018-08-14 15:21:54 +02:00
Kenneth Skovhede d0026d8028 Reworked the file-path query, and enabled experimentally changing it by setting the environment variable TEST_QUERY_VERSION=1 or TEST_QUERY_VERSION=2. 
Added check to the unittests to catch cases where it scans too many files.
 2018-08-13 13:23:59 +02:00
Kenneth Skovhede 4d1bea86a6 Attempt at making a leaner version of getting the previous file's information 2018-08-11 14:39:03 +02:00
Kenneth Skovhede 5507496352 Fixed the query to correctly extract metadata for a file, using the Metadataset indirection 2018-08-11 14:37:23 +02:00
Kenneth Skovhede 52cb9fb1f9 Removed the deprecated --store-metadata option. 
Rewrote the logic for pre-filtering files based on timestamps/metadata to be more verbose and well documented.
Fixed an issue where `--check-filetime-only` also checked the file size, which was not present due to the reduced query used to grab only the lastmodified information.
Fixed a problem where the check for existing metadata was wrong and produced a warning.

This fixes #3204
This handles some of #3194
 2018-08-11 11:48:19 +02:00
Kenneth SkovhedeandGitHub 64201ae706 Merge pull request #3314 from mnaiman/log_sql_variables 
Log sql variables
 2018-08-07 23:32:27 +02:00
Kenneth Skovhede 3831962c82 Fixed an infinite recursion issue 2018-08-07 13:35:30 +02:00
Kenneth Skovhede e9d7c47602 Disabled logging block and file database access to reduce overhead in these queries. 
Added an option to explicitly re-enable logging of the database queries (`--profile-all-database-queries`)
 2018-08-07 09:40:43 +02:00
Max123456 99bb089b8b log variables even in release 2018-07-06 19:44:05 +02:00
Max123456 af5e2119c0 typo 2018-07-06 19:41:25 +02:00
Kenneth SkovhedeandGitHub bbe8358ccb Merge pull request #3225 from tygill/fix/improve-repair 
Adds a check for BlocksetIDs that don't have any corresponding BlocksetEntrys to the broken fileset check.
 2018-06-14 09:20:59 +02:00
Kenneth Skovhede 4b3389f4b6 Fix the missing block references prior to looking for missing block info 2018-06-12 08:29:55 +02:00
Kenneth Skovhede 1f32047042 Don't remove the extra index files immediately, but wait for next compact 2018-06-11 11:20:12 +02:00
Kenneth Skovhede ec363f88a0 Fixed not deleting the non-index volumes 2018-06-11 10:34:32 +02:00
Kenneth Skovhede bce1db123a Merge branch 'master' into feature/speedup_backup_index_files 
# Conflicts:
#	Duplicati/Library/Utility/Utility.cs
 2018-06-08 10:31:27 +02:00
Kenneth Skovhede b534c5649e Fixed a shared buffer being re-used for multiple results. 2018-06-06 08:37:09 +02:00
Kenneth Skovhede d042e70ca2 Changed the returned IEnumerable values to be fully created, which avoids issues with locks and transactions being prematurely released. 
This might help with #3202
 2018-06-04 11:56:54 +02:00
Kenneth Hsu 20f2f37806 Remove unnecessary calls to String.Format. 2018-06-02 12:02:55 -07:00
Kenneth Hsu f12858e6a5 Mark fields that shouldn't be reassigned as readonly. 
This makes it explicit at compile-time that these fields should not be
reassigned outside the constructor.
 2018-05-25 10:04:52 -07:00
Tyler Gill 8acc9ba5c9 Blocksets with a length of 0 are not broken if the block they reference by hash is not listed. 2018-05-24 15:22:05 -06:00
Kenneth SkovhedeandGitHub fd26732e1f Merge pull request #3228 from warwickmm/use_string_join 
Simplify construction of query parameter string
 2018-05-23 11:11:02 +02:00
Kenneth SkovhedeandGitHub 19851c88f0 Merge pull request #3227 from warwickmm/use_string_builder 
Replace string concatenation with StringBuilder
 2018-05-23 11:10:36 +02:00
Tyler Gill bbdf4c2747 Add more broken file detection: 
Blocksets with either blockset entires or blocklist entries that refer to invalid / unreachable blocks are now treated as broken as well.
 2018-05-21 10:16:51 -06:00
Kenneth Hsu 2384e6eb30 Simplify construction of query parameter string. 2018-05-19 16:12:12 -07:00
Kenneth Hsu 0b016cea2c Replace string concatenation with StringBuilder. 
When appending to a string in a loop, using a StringBuilder should in
general yield better performance.
 2018-05-19 15:36:00 -07:00
Tyler Gill b5931b2771 Adds a check for BlocksetIDs that don't have any corresponding BlocksetEntrys to the broken fileset check. 
Bug #3210 (and several other possibly related ones) had cases where a recreated database would have these invalid blockset IDs.
It seems like they were caused by filesets referring to a blockset by hash, but not having any index or block file actually containing the block for that hash.
Also fixes countMissingInformation query - it should join with missingBlocklistVolumes, rather than missingBlocklistEntries, as it is selecting the VolumeID.
 2018-05-17 08:11:13 -06:00
verhoek 30cd41585b Corrected spelling function name. 2018-05-16 20:08:40 +02:00