Commit Graph
632 Commits
Author SHA1 Message Date
Rune HenriksenandGitHub be7edb580d Merge pull request #3410 from warwickmm/simplify_enumerating_collections
Simplify enumeration of collections
2018-10-07 19:06:28 +02:00
Kenneth Hsu 0c1ac9c489 Replace chained LINQ calls with call to overload with predicate.
This simplifies the code by reducing the number of enumerators created
while also making the code slightly more readable.
2018-10-06 16:20:18 -07:00
Rune Henriksen 306ccabfef updated MegaApiClient from 1.6.0 to 1.6.3 2018-10-04 00:34:49 +02:00
Kenneth Hsu e2bc85c7e4 Merge remote-tracking branch 'upstream/master' into constructor_virtual_members
Resolved Conflicts:
	Duplicati/Library/Backend/OneDrive/MicrosoftGraphBackend.cs
2018-10-01 17:15:58 -07:00
Rune HenriksenandGitHub 5f4236cbc2 Merge pull request #3399 from duplicati/remove_unused_variables_assignments
Remove unused variables, fields, and unnecessary assignments
2018-10-01 23:19:37 +02:00
Kenneth Hsu 024bc5bea2 Mark immutable field as readonly. 2018-09-30 15:45:42 -07:00
Kenneth Hsu ee14862db5 Add comment to clarify use of Lazy. 2018-09-30 15:06:55 -07:00
Kenneth Hsu f59607d94d Rename property. 2018-09-30 15:06:55 -07:00
Kenneth Hsu f9022fec66 Avoid referencing virtual members in constructor.
Since the call to GetRootPathFromUrl may be expensive, we cache the
value using a lazy initializer.
2018-09-30 15:06:49 -07:00
Kenneth Hsu 7cf830cad7 Provide protocol key to MicrosoftGraphBackend constructor.
This will help us avoid referencing virtual members in the constructor.
2018-09-30 10:59:26 -07:00
Kenneth Hsu 6215fe1ac5 Extract string to private constant.
This will allow us to provide the string as a parameter to the parent
class constructor to avoid referencing virtual members in the
constructor.
2018-09-30 10:56:59 -07:00
Kenneth Hsu 183ae4ede2 Remove additional unused variables. 2018-09-29 12:49:22 -07:00
Kenneth Hsu 9ce1e807c7 Remove unused variables and fields. 2018-09-29 10:41:27 -07:00
Kenneth Hsu 44b7c29489 Rename local variable to avoid hiding class field. 2018-09-28 20:57:44 -07:00
Kenneth SkovhedeandGitHub 0ec49d3a87 Merge pull request #3393 from warwickmm/fix_append_dir_separator
Fix behavior of AppendDirSeparator utility method
2018-09-28 22:24:11 +02:00
Kenneth SkovhedeandGitHub f24bce8e14 Merge pull request #3392 from warwickmm/simplify_method_resolution
Simplify method resolution by removing default parameters
2018-09-28 22:21:29 +02:00
Kenneth Hsu d4d1945faf Use utility method to append trailing slash.
This removes some duplicated code.
2018-09-22 10:19:45 -07:00
Kenneth Hsu 18aae7a5c4 Simplify method resolution by removing default parameters.
The previous implementations resulted in an overload being hidden by one
without a default parameter, making it unclear which method was being
called.  For example, consider the following signatures:

public MultipartItem(string content, string contenttype = null, string name = null, string filename = null)
public MultipartItem(string contenttype, string name = null, string filename = null)

From https://docs.microsoft.com/en-us/dotnet/csharp/programming-guide/classes-and-structs/named-and-optional-arguments,

> If two candidates are judged to be equally good, preference goes to a
> candidate that does not have optional parameters for which arguments
> were omitted in the call. This is a consequence of a general preference
> in overload resolution for candidates that have fewer parameters.
2018-09-20 19:30:49 -07:00
Kenneth Hsu 0d23302220 Use ordinal case-insensitive comparison instead of ToLower. 2018-09-19 15:21:59 -07:00
Kenneth Hsu eea479e056 Fix URL for Google Cloud Storage backend.
This fixes an issue where Google Cloud Storage users encountered the
following exception:

System.Net.WebException: The remote server returned an error: (404) Not Found.

The refactoring in revision 18de687530 ("Updated Put and Createfolder
using WebApi") omitted the "/o" in the endpoint for object uploads.

This addresses issue #3328.
2018-08-24 22:31:05 -07:00
Kenneth Skovhede c4b564358c Spelling fixes 2018-08-12 22:33:21 +02:00
Kenneth SkovhedeandGitHub d96043007c Merge pull request #3317 from verhoek/refactoring/ftp
Refactoring/ftp
2018-08-02 09:55:38 +02:00
verhoek dafee2b455 Removed unwanted character in setting passive mode. 2018-07-17 21:35:55 +02:00
verhoek 2e4a395402 Braces. 2018-06-28 23:18:18 +02:00
verhoek 470b83c416 Remove lambda. 2018-06-28 23:16:28 +02:00
verhoek 2bcc372d0a Simplified passivemode setting. 2018-06-28 23:10:35 +02:00
verhoek 65b3df52f2 Tidying up. 2018-06-28 21:07:23 +02:00
Kenneth Skovhede 31656b4eb3 Merge branch 'feature/repair_console_output' 2018-06-28 12:18:48 +02:00
Kenneth SkovhedeandGitHub 4b9c0ab9a2 Merge pull request #3289 from warwickmm/configure_await_false
Allow tasks to complete on any thread when context is irrelevant
2018-06-26 12:05:27 +02:00
Kenneth SkovhedeandGitHub 497daa5450 Merge pull request #3285 from snamds/VerifyRemoteList
Amazon cloud drive delay problems (amzcd-consistency-delay)
2018-06-26 12:01:55 +02:00
fgonzalez 74cd646fa6 Codacy changes 2018-06-25 09:08:15 +02:00
fgonzalez f4885a0ede Code cleaning 2018-06-22 09:06:28 +02:00
fgonzalez 3a8f958ba8 - No need to handle first attempt
- Default delay to 30s. 15s is not enough
2018-06-22 08:59:40 +02:00
Kenneth Hsu 54c4f9224d Allow tasks to complete on any thread when context is irrelevant.
When the code following the await can be executed on any thread, it's
recommended to use ConfigureAwait(false) to avoid unnecessary context
switching and potential deadlocks.
2018-06-21 19:28:27 -07:00
fgonzalez 6ae5267e07 Case not covered 2018-06-21 16:52:28 +02:00
fgonzalez dc760d2895 Amazon cloud drive delay problems (amzcd-consistency-delay)
- time delay between instances of AmzCD class was not respected
2018-06-21 16:08:18 +02:00
Kenneth Skovhede 98303a6249 Removed console output from the S3 module 2018-06-20 10:54:37 +02:00
Kenneth Skovhede e9850224e2 Made the gcs backend available again. 2018-06-18 15:05:02 +02:00
Kenneth Hsu 2717bbd09a Avoid null reference exceptions with Box.com backend.
This addresses issue #3276, and possibly issue #3062.
2018-06-16 11:18:59 -07:00
verhoek a850ed8f26 Removed inheritance in favor of separation of googledrive / cloud storage api. 2018-06-11 10:19:03 +02:00
verhoek 441d893a49 Changes to make codacy happier. 2018-06-09 14:19:18 +02:00
verhoek bc826b2300 Tidy up. 2018-06-09 11:07:13 +02:00
verhoek 2a964e0146 Reordered private and statics. 2018-06-09 11:04:12 +02:00
verhoek 65f079e745 Made bucketobjectpath private. 2018-06-09 10:58:34 +02:00
verhoek 7b5779ca5d Merge remote-tracking branch 'origin' into webapi/googlecloudstorage
# Conflicts:
#	Duplicati/Library/Backend/GoogleServices/GCSConfig.cs (line endings)
#	Duplicati/Library/Backend/GoogleServices/GoogleCloudStorage.cs (readonly)
2018-06-09 08:49:23 +02:00
verhoek c1832cab4e Fixed incorrect line endings. 2018-06-09 08:30:39 +02:00
verhoek 3fb7175931 Merge remote-tracking branch 'origin/master' into feature/tempdir
# Conflicts:
#	Duplicati/Server/Runner.cs (copied readonly prop)
2018-06-07 16:37:40 +02:00
Kenneth SkovhedeandGitHub c5c13ab242 Merge pull request #3257 from warwickmm/remove_redundant_tostring
Remove redundant calls to ToString
2018-06-07 13:36:20 +02:00
Kenneth Hsu 08a897d7b0 Remove redundant calls to ToString. 2018-06-04 20:15:34 -07:00
Tyler Gill 5be38df560 Fix typo in OAuthHttpClient 2018-06-04 14:59:58 -06:00