This PR adds a new locking service that keeps track of which local databases are currently in use by the server. If a database is in use due to a running task, immediate calls will now be rejected. Prior to this change, immediate calls could interfere with the running task, causing a backup to fail abruptly if the user attempted to check the logs or restore.
286 lines
9.6 KiB
C#
286 lines
9.6 KiB
C#
// Copyright (C) 2026, The Duplicati Team
|
|
// https://duplicati.com, hello@duplicati.com
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a
|
|
// copy of this software and associated documentation files (the "Software"),
|
|
// to deal in the Software without restriction, including without limitation
|
|
// the rights to use, copy, modify, merge, publish, distribute, sublicense,
|
|
// and/or sell copies of the Software, and to permit persons to whom the
|
|
// Software is furnished to do so, subject to the following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included in
|
|
// all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
|
|
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
// FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
|
|
// DEALINGS IN THE SOFTWARE.
|
|
|
|
using Duplicati.Library.Interface;
|
|
using Duplicati.Library.RestAPI;
|
|
using Duplicati.Library.Utility;
|
|
using Duplicati.Server;
|
|
using Duplicati.Server.Database;
|
|
using Duplicati.Server.Serialization.Interface;
|
|
using Duplicati.WebserverCore.Abstractions;
|
|
|
|
namespace Duplicati.WebserverCore.Services;
|
|
|
|
/// <summary>
|
|
/// Simple queue that will run the given task
|
|
/// </summary>
|
|
public class QueueRunnerService(
|
|
Connection connection,
|
|
EventPollNotify eventPollNotify,
|
|
INotificationUpdateService notificationUpdateService,
|
|
IProgressStateProviderService progressStateProviderService,
|
|
IApplicationSettings applicationSettings,
|
|
IDatabaseLockTracker databaseLockTracker) : IQueueRunnerService, IDisposable
|
|
{
|
|
private readonly object _lock = new();
|
|
/// <summary>
|
|
/// A thread-safe dictionary to store cached task results.
|
|
/// </summary>
|
|
private readonly Dictionary<long, CachedTaskResult> _taskCache = new();
|
|
|
|
/// <summary>
|
|
/// The maximum number of completed task results to keep in memory
|
|
/// </summary>
|
|
private static readonly int MAX_TASK_RESULT_CACHE_SIZE = 100;
|
|
|
|
private readonly List<IQueuedTask> _tasks = new();
|
|
private (Task? Task, IQueuedTask? QueuedTask, CancellationTokenSource? LockCts) _current;
|
|
private bool _isPaused;
|
|
private bool _isTerminated;
|
|
private readonly CancellationTokenSource _terminateCts = new();
|
|
|
|
public long AddTask(IQueuedTask task)
|
|
=> AddTask(task, false);
|
|
|
|
public long AddTask(IQueuedTask task, bool skipQueue)
|
|
{
|
|
lock (_lock)
|
|
if (skipQueue)
|
|
_tasks.Insert(0, task);
|
|
else
|
|
_tasks.Add(task);
|
|
|
|
eventPollNotify.SignalNewEvent();
|
|
eventPollNotify.SignalTaskQueueUpdate();
|
|
StartNextTask();
|
|
return task.TaskID;
|
|
}
|
|
|
|
public bool GetIsActive()
|
|
=> _current.Task != null;
|
|
|
|
public IQueuedTask? GetCurrentTask()
|
|
=> _current.QueuedTask;
|
|
|
|
public List<IQueuedTask> GetCurrentTasks()
|
|
{
|
|
lock (_lock)
|
|
return [.. _tasks];
|
|
}
|
|
|
|
public void Pause()
|
|
{
|
|
lock (_lock)
|
|
_isPaused = true;
|
|
}
|
|
|
|
public void Resume()
|
|
{
|
|
lock (_lock)
|
|
_isPaused = false;
|
|
|
|
StartNextTask();
|
|
}
|
|
|
|
public void Terminate(bool wait)
|
|
{
|
|
_isTerminated = true;
|
|
_terminateCts.Cancel();
|
|
if (wait)
|
|
{
|
|
var task = _current.Task;
|
|
if (task != null)
|
|
task.Await();
|
|
}
|
|
}
|
|
|
|
private void StartNextTask()
|
|
{
|
|
lock (_lock)
|
|
{
|
|
if (_isTerminated || _isPaused || (_current.Task != null && !_current.Task.IsCompleted))
|
|
return;
|
|
|
|
// Clean up completed tasks
|
|
if (_current.Task != null && _current.Task.IsCompleted)
|
|
{
|
|
_current.LockCts?.Dispose();
|
|
_current = (null, null, null);
|
|
}
|
|
|
|
if (_tasks.Count == 0)
|
|
return;
|
|
|
|
var nextTask = _tasks[0];
|
|
_tasks.RemoveAt(0);
|
|
_current = (Task.Run(() => RunTaskAsync(nextTask), CancellationToken.None), nextTask, null);
|
|
}
|
|
}
|
|
|
|
private async Task RunTaskAsync(IQueuedTask task)
|
|
{
|
|
var completed = false;
|
|
IAsyncDisposable? dbLock = null;
|
|
var lockCts = CancellationTokenSource.CreateLinkedTokenSource(_terminateCts.Token);
|
|
lock (_lock)
|
|
_current = (_current.Task, _current.QueuedTask, lockCts);
|
|
try
|
|
{
|
|
eventPollNotify.SignalNewEvent();
|
|
eventPollNotify.SignalTaskQueueUpdate();
|
|
task.TaskStarted = DateTime.UtcNow;
|
|
if (task.OnStarting != null)
|
|
await task.OnStarting().ConfigureAwait(false);
|
|
|
|
dbLock = await AcquireDatabaseLockAsync(task, lockCts.Token).ConfigureAwait(false);
|
|
|
|
await Runner.RunAsync(connection, eventPollNotify, notificationUpdateService, progressStateProviderService, applicationSettings, task, true).ConfigureAwait(false);
|
|
|
|
// If the task is completed, don't call OnFinished again
|
|
completed = true;
|
|
AddTaskResult(new CachedTaskResult(task.TaskID, task.BackupID, task.TaskStarted, task.TaskFinished ?? DateTime.Now, null));
|
|
if (task.OnFinished != null)
|
|
await task.OnFinished(null).ConfigureAwait(false);
|
|
}
|
|
catch (Exception ex)
|
|
{
|
|
connection.LogError(task.BackupID, "Error in worker", ex);
|
|
if (!completed)
|
|
{
|
|
AddTaskResult(new CachedTaskResult(task.TaskID, task.BackupID, task.TaskStarted, task.TaskFinished ?? DateTime.Now, ex));
|
|
if (task.OnFinished != null)
|
|
await task.OnFinished(ex).ConfigureAwait(false);
|
|
}
|
|
}
|
|
finally
|
|
{
|
|
if (dbLock != null)
|
|
await dbLock.DisposeAsync().ConfigureAwait(false);
|
|
task.TaskFinished = DateTime.UtcNow;
|
|
lock (_lock)
|
|
{
|
|
lockCts.Dispose();
|
|
_current = (null, null, null);
|
|
}
|
|
eventPollNotify.SignalNewEvent();
|
|
eventPollNotify.SignalTaskQueueUpdate();
|
|
eventPollNotify.SignalTaskCompleted(task.TaskID);
|
|
StartNextTask();
|
|
}
|
|
}
|
|
|
|
public IList<Tuple<long, string?>> GetQueueWithIds()
|
|
{
|
|
return (from n in GetCurrentTasks()
|
|
where n.BackupID != null
|
|
select new Tuple<long, string?>(n.TaskID, n.BackupID)).ToList();
|
|
}
|
|
|
|
|
|
/// <inheritdoc/>
|
|
public CachedTaskResult? GetCachedTaskResults(long taskID)
|
|
{
|
|
lock (_lock)
|
|
{
|
|
_taskCache.TryGetValue(taskID, out var result);
|
|
return result;
|
|
}
|
|
}
|
|
|
|
private void AddTaskResult(CachedTaskResult taskResult)
|
|
{
|
|
lock (_lock)
|
|
{
|
|
// If the task result is already in the cache, remove it
|
|
if (_taskCache.TryGetValue(taskResult.TaskID, out var existingResult))
|
|
{
|
|
// If the stored task result has an exception, do not overwrite it
|
|
if (existingResult.Exception != null)
|
|
return;
|
|
}
|
|
|
|
// Add/update the new task result in the cache
|
|
_taskCache[taskResult.TaskID] = taskResult;
|
|
|
|
// If the cache size exceeds the maximum, remove the oldest entry
|
|
while (_taskCache.Count >= MAX_TASK_RESULT_CACHE_SIZE)
|
|
{
|
|
var oldestTaskID = _taskCache.Keys.Min();
|
|
_taskCache.Remove(oldestTaskID);
|
|
}
|
|
}
|
|
}
|
|
|
|
/// <inheritdoc/>
|
|
public async Task<IBasicResults?> RunImmediatelyAsync(IQueuedTask task)
|
|
{
|
|
IAsyncDisposable? dbLock = null;
|
|
var dbPath = Runner.GetEffectiveDBPath(task);
|
|
|
|
// If we have a database to work with, make sure we can get the lock
|
|
if (!string.IsNullOrWhiteSpace(dbPath))
|
|
dbLock = databaseLockTracker.TryAcquire(dbPath)
|
|
?? throw new DatabaseLockedException(dbPath);
|
|
|
|
try
|
|
{
|
|
return await Runner.RunAsync(connection, eventPollNotify, notificationUpdateService, progressStateProviderService, applicationSettings, task, false).ConfigureAwait(false);
|
|
}
|
|
finally
|
|
{
|
|
if (dbLock != null)
|
|
await dbLock.DisposeAsync().ConfigureAwait(false);
|
|
}
|
|
}
|
|
|
|
/// <inheritdoc/>
|
|
public void CancelCurrentTaskLockWait(long taskID)
|
|
{
|
|
lock (_lock)
|
|
{
|
|
if (_current.QueuedTask?.TaskID == taskID && _current.LockCts != null)
|
|
_current.LockCts.Cancel();
|
|
}
|
|
}
|
|
|
|
/// <summary>
|
|
/// Acquires the database lock for a queued task, waiting until the lock is available
|
|
/// or the cancellation token is cancelled. Tasks without a database path (e.g. custom
|
|
/// runner tasks) skip locking.
|
|
/// </summary>
|
|
private async Task<IAsyncDisposable?> AcquireDatabaseLockAsync(IQueuedTask task, CancellationToken cancellationToken)
|
|
{
|
|
var dbPath = Runner.GetEffectiveDBPath(task);
|
|
if (string.IsNullOrWhiteSpace(dbPath))
|
|
return null;
|
|
|
|
return await databaseLockTracker.AcquireAsync(dbPath, cancellationToken).ConfigureAwait(false);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Disposes resources held by the queue runner, including the termination
|
|
/// cancellation token source used to cancel tasks waiting on the database lock.
|
|
/// </summary>
|
|
public void Dispose()
|
|
{
|
|
_terminateCts.Dispose();
|
|
}
|
|
} |