Files
duplicati/Duplicati/Library/Main/Backend/BackendManager.PendingOperation.cs
T
JamBalaya56562andClaude Opus 4.8 1470b05a4b Address PR review: async parity API, opt-in module, per-operation instance, tests
Responds to the review on #7020:
- IParity Create/Verify/Repair are now async (CancellationToken); the par2
  runner uses WaitForExitAsync and awaits the output reads directly.
- Removed ParityBase; Par2Parity implements IParity directly.
- parity-redundancy-level is parsed via Utility.ParseIntOption and validated as
  positive, and moved into the par2 module's own options. no-parity removed;
  parity-module now defaults to empty (opt-in) and is the sole toggle.
- The availability probe and "not found" warning are per-instance; BackendManager
  holds one shared parity instance per operation (SharedParityProvider), disposed
  with the manager, instead of constructing one per volume.
- The download repair path guards on Blocks/Files volume type; a successful parity
  repair now logs a warning; the test/verification flow disables repair
  (allowParityRepair=false) so damage is reported rather than masked.
- Added a full backup -> corrupt -> detect -> restore/recover integration test.
- Fix: par2cmdline 0.8.1 aborts on single-character protected filenames, so the
  working-copy base name is now "data" instead of "d". Verified end-to-end against
  real par2 in a Linux container (all parity tests pass).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-07-11 00:57:54 +09:00

256 lines
9.9 KiB
C#

using System;
using System.IO;
using System.Threading;
using System.Threading.Tasks;
using Duplicati.Library.Interface;
using Duplicati.Library.Main.Operation.Common;
using Duplicati.StreamUtil;
namespace Duplicati.Library.Main.Backend;
#nullable enable
partial class BackendManager
{
/// <summary>
/// Execution context for the backend manager
/// </summary>
/// <param name="ProgressHandler">The progress handler</param>
/// <param name="Statwriter">The stat writer</param>
/// <param name="Database">The database collector</param>
/// <param name="UploadThrottleManager">The upload throttle manager</param>
/// <param name="DownloadThrottleManager">The download throttle manager</param>
/// <param name="TaskReader">The task reader</param>
/// <param name="IsThrottleDisabled">Whether throttling is disabled</param>
/// <param name="Options">The options</param>
/// <param name="Parity">The shared parity module provider for the operation</param>
private sealed record ExecuteContext(
ProgressHandler ProgressHandler,
IBackendWriter Statwriter,
DatabaseCollector Database,
ThrottleManager UploadThrottleManager,
ThrottleManager DownloadThrottleManager,
ITaskReader TaskReader,
bool IsThrottleDisabled,
Options Options,
SharedParityProvider Parity);
/// <summary>
/// Lazily creates and owns a single parity module instance for the lifetime of a
/// backend operation (backup/restore/...). Sharing one instance keeps the module's
/// availability probe and "not found" warning to once per operation, and lets the
/// instance hold per-operation state. Thread-safe; disposed with the backend manager.
/// </summary>
private sealed class SharedParityProvider : IDisposable
{
/// <summary>
/// The options used to construct the parity module
/// </summary>
private readonly Options m_options;
/// <summary>
/// Lock guarding the lazy creation
/// </summary>
private readonly object m_lock = new();
/// <summary>
/// Whether the instance creation has been attempted
/// </summary>
private bool m_created;
/// <summary>
/// The shared parity module instance, or null if parity is disabled/unavailable
/// </summary>
private IParity? m_instance;
/// <summary>
/// Creates a new shared parity provider
/// </summary>
/// <param name="options">The options used to construct the parity module</param>
public SharedParityProvider(Options options)
{
m_options = options;
}
/// <summary>
/// Returns the shared parity module instance, or null if parity is disabled or
/// the module could not be loaded. The instance is created on first access and
/// reused for the remainder of the operation.
/// </summary>
public IParity? Get()
{
lock (m_lock)
{
if (!m_created)
{
m_created = true;
var module = m_options.ParityModule;
if (!string.IsNullOrEmpty(module))
{
try
{
m_instance = DynamicLoader.ParityLoader.GetModule(module, m_options.RawOptions);
}
catch (System.Reflection.TargetInvocationException tie) when (tie.InnerException != null)
{
// The module is created via reflection; surface the real
// constructor exception (e.g. an invalid option value) rather
// than the reflection wrapper.
System.Runtime.ExceptionServices.ExceptionDispatchInfo.Capture(tie.InnerException).Throw();
}
}
}
return m_instance;
}
}
/// <summary>
/// Disposes the shared parity module instance, if any
/// </summary>
public void Dispose()
{
lock (m_lock)
{
m_instance?.Dispose();
m_instance = null;
m_created = true;
}
}
}
/// <summary>
/// A base non-generic pending operation
/// </summary>
private abstract class PendingOperationBase
{
/// <summary>
/// The execution context
/// </summary>
public ExecuteContext Context { get; }
/// <summary>
/// Whether to wait for the operation to complete.
/// If false, the operation is queued and the task is returned after the operation is queued.
/// </summary>
public bool WaitForComplete { get; }
/// <summary>
/// The cancellation token
/// </summary>
public CancellationToken CancelToken { get; set; }
/// <summary>
/// The type of operation the pending operation represents
/// </summary>
public abstract BackendActionType Operation { get; }
/// <summary>
/// The logical remote filename, used for all bookkeeping (database updates,
/// progress events, logging). This is the full relative path as seen by the
/// caller (e.g. <c>subfolder/file.txt</c>).
/// </summary>
public virtual string RemoteFilename => string.Empty;
/// <summary>
/// The remote size, if any
/// </summary>
public virtual long Size => -1L;
/// <summary>
/// The name actually passed to the backend's put/get/delete call. When null
/// (the default), <see cref="GetEffectiveRemoteName"/> falls back to
/// <see cref="RemoteFilename"/> (the full relative path) - this is the
/// behavior for folder-enabled backends. For backends that do not support
/// folder operations, <see cref="BackendManager.ApplyPathTranslation"/> sets
/// this to just the filename part (the backend is pointed at the sub-folder
/// via <see cref="BackendUrlOverride"/>).
/// </summary>
public string? EffectiveRemoteName { get; set; }
/// <summary>
/// Returns the remote name to pass to the backend's put/get/delete call:
/// <see cref="EffectiveRemoteName"/> if set, otherwise <see cref="RemoteFilename"/>.
/// </summary>
public string GetEffectiveRemoteName()
=> string.IsNullOrEmpty(EffectiveRemoteName) ? RemoteFilename : EffectiveRemoteName!;
/// <summary>
/// The backend URL to use for this operation, or null to use the backend
/// manager's base backend URL. Set by <see cref="BackendManager.ApplyPathTranslation"/>
/// for non-folder backends to point the backend at the sub-folder containing
/// the file, so the flat put/get/delete call resolves to the right location.
/// </summary>
public string? BackendUrlOverride { get; set; }
/// <summary>
/// Sets the operation as cancelled
/// </summary>
public abstract void SetCancelled();
/// <summary>
/// Sets the operation as failed
/// </summary>
/// <param name="ex">The exception</param>
public abstract void SetFailed(Exception ex);
/// <summary>
/// Creates a new pending operation
/// </summary>
/// <param name="context">The execution context</param>
/// <param name="waitForComplete">Whether to wait for the operation to complete</param>
/// <param name="cancelToken">The cancellation token</param>
public PendingOperationBase(ExecuteContext context, bool waitForComplete, CancellationToken cancelToken)
{
Context = context;
WaitForComplete = waitForComplete;
CancelToken = cancelToken;
}
}
/// <summary>
/// The basic queued backend operation
/// </summary>
/// <remarks>
/// Creates a new pending operation
/// </remarks>
/// <param name="context">The execution context</param>
/// <param name="waitForComplete">Whether to wait for the operation to complete</param>
/// <param name="cancelToken">The cancellation token</param>
private abstract class PendingOperation<TResult>(ExecuteContext context, bool waitForComplete, CancellationToken cancelToken) : PendingOperationBase(context, waitForComplete, cancelToken)
{
/// <summary>
/// A signal for the task completion
/// </summary>
private readonly TaskCompletionSource<TResult> taskCompleteSignal = new TaskCompletionSource<TResult>(TaskCreationOptions.RunContinuationsAsynchronously);
/// <summary>
/// The task that is completed when the operation is done
/// </summary>
public Task<TResult> GetResultAsync() => taskCompleteSignal.Task;
/// <summary>
/// Sets the operation as complete
/// </summary>
public void SetComplete(TResult result)
{
taskCompleteSignal.TrySetResult(result);
}
/// <summary>
/// Sets the operation as failed
/// </summary>
/// <param name="ex">The exception</param>
public override void SetFailed(Exception ex)
{
taskCompleteSignal.TrySetException(ex);
}
/// <summary>
/// Sets the operation as cancelled
/// </summary>
public override void SetCancelled()
{
taskCompleteSignal.TrySetCanceled();
}
/// <summary>
/// Executes the operation
/// </summary>
/// <param name="backend">The backend to execute the operation on</param>
/// <param name="cancelToken">The cancellation token</param>
/// <returns>An awaitable task</returns>
public abstract Task<TResult> ExecuteAsync(IBackend backend, CancellationToken cancelToken);
}
}