Kenneth Skovhede
a7ef8e42f2
This PR is a security hardning change and will break some setups. The hardning is done to ensure the datafolder is not compromised and particularly that it is not maliciously seeded. The changes now **requires** that the datafolder is locked down with exact permissions, or Duplicati will refuse to use it. This is a change to prior functionality where the folder would simply be locked down if it was not already locked. Previously, a file named `insecure-permissions.txt` could be placed in the folder to instruct Duplicati not to set permissions. With this change that file is no longer supported. The only way to opt-out of the permission check is to supply `--allow-insecure-datafolder` or the environment variable `DUPLICATI__ALLOW_INSECURE_DATAFOLDER`. Once either of those are set, Duplicati will no longer check permissions and accept folders with other permissions. The setting can be applied to `preload.json`, but the file needs to be in a trusted location, which is either the directory with the binaries or the file pointed to by `DUPLICATI_PRELOAD_SETTINGS`. The setting cannot be placed in a `preload.json` file that is in an insecure folder as the folder is not read if the permissions are not correct. The previous paths `/usr/local/share/Duplicati/preload.json` and `C:\ProgramData\Duplicati\preload.json` are no longer supported as they cannot be guaranteed to be locked down. A `preload.json` in the datafolder is still supported, provided the folder passes the permission check (or the `--allow-insecure-datafolder` is passed to the executable). For most users, this should not cause any problems as Duplicati has been locking down the folders, so they should be correctly locked down already. The configuretool has been updated with a `secure-datafolder` command that can be used to force the correct permissions on a folder, in case the folder did not have the correct permissions. For some Docker setups it may not be possible to set the permissions and the check will fail. These setup will need to apply `DUPLICATI__ALLOW_INSECURE_DATAFOLDER=true` in the image to run without the protections.
86 lines
3.3 KiB
C#
86 lines
3.3 KiB
C#
// Copyright (C) 2026, The Duplicati Team
|
|
// https://duplicati.com, hello@duplicati.com
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a
|
|
// copy of this software and associated documentation files (the "Software"),
|
|
// to deal in the Software without restriction, including without limitation
|
|
// the rights to use, copy, modify, merge, publish, distribute, sublicense,
|
|
// and/or sell copies of the Software, and to permit persons to whom the
|
|
// Software is furnished to do so, subject to the following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included in
|
|
// all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
|
|
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
// FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
|
|
// DEALINGS IN THE SOFTWARE.
|
|
|
|
using System.CommandLine;
|
|
using System.CommandLine.Builder;
|
|
using System.CommandLine.Parsing;
|
|
using System.Reflection;
|
|
using Duplicati.CommandLine.ConfigureTool.Commands;
|
|
using Duplicati.Library.Interface;
|
|
|
|
namespace Duplicati.CommandLine.ConfigureTool;
|
|
|
|
/// <summary>
|
|
/// The main entry point for the ConfigureTool application.
|
|
/// </summary>
|
|
public static class Program
|
|
{
|
|
/// <summary>
|
|
/// The main entry point for the application.
|
|
/// </summary>
|
|
public static Task<int> MainAsync(string[] args)
|
|
{
|
|
Library.AutoUpdater.PreloadSettingsLoader.ConfigurePreloadSettings(ref args, Library.AutoUpdater.PackageHelper.NamedExecutable.ConfigureTool);
|
|
|
|
var httpsCmd = new Command("https", "Manage HTTPS certificates for the Duplicati server")
|
|
{
|
|
HttpsCommand.CreateGenerateCommand(),
|
|
HttpsCommand.CreateRenewCommand(),
|
|
HttpsCommand.CreateRegenerateCaCommand(),
|
|
HttpsCommand.CreateRemoveCommand(),
|
|
HttpsCommand.CreateShowCommand(),
|
|
HttpsCommand.CreateExportCommand(),
|
|
HttpsCommand.CreateExportCaCommand()
|
|
};
|
|
|
|
var secureDataFolderCmd = SecureDataFolderCommand.CreateSecureDataFolderCommand();
|
|
|
|
var rootCmd = new RootCommand("Duplicati Configure Tool")
|
|
{
|
|
httpsCmd,
|
|
secureDataFolderCmd
|
|
};
|
|
|
|
return new CommandLineBuilder(rootCmd)
|
|
.UseDefaults()
|
|
.UseExceptionHandler((ex, context) =>
|
|
{
|
|
var rex = ex is TargetInvocationException tie
|
|
? tie.InnerException
|
|
: ex;
|
|
|
|
if (rex is UserInformationException userInformationException)
|
|
{
|
|
Console.WriteLine("ErrorID: {0}", userInformationException.HelpID);
|
|
Console.WriteLine("Message: {0}", userInformationException.Message);
|
|
context.ExitCode = 2;
|
|
}
|
|
else
|
|
{
|
|
Console.WriteLine("Exception: " + rex);
|
|
context.ExitCode = 1;
|
|
}
|
|
})
|
|
.Build()
|
|
.InvokeAsync(args);
|
|
}
|
|
}
|