Kenneth Skovhede
ab29642e10
Add a synchronization point after recreating missing index files to ensure all uploads are settled and committed to the database before the backup process continues. This prevents a race condition where the backup could start while index files are still being uploaded. In this case, it would be possible for the backup to reference the file that is currently being deleted. This would be very rare in production as the delays have to align and the new data must be changed and processed very quickly to trigger the issue. In unittests we have observed the issue for a while but only showing up very rarely.
75 lines
3.4 KiB
C#
75 lines
3.4 KiB
C#
// Copyright (C) 2025, The Duplicati Team
|
|
// https://duplicati.com, hello@duplicati.com
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a
|
|
// copy of this software and associated documentation files (the "Software"),
|
|
// to deal in the Software without restriction, including without limitation
|
|
// the rights to use, copy, modify, merge, publish, distribute, sublicense,
|
|
// and/or sell copies of the Software, and to permit persons to whom the
|
|
// Software is furnished to do so, subject to the following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included in
|
|
// all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
|
|
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
// FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
|
|
// DEALINGS IN THE SOFTWARE.
|
|
|
|
using System.Threading.Tasks;
|
|
using Duplicati.Library.Main.Operation.Common;
|
|
|
|
namespace Duplicati.Library.Main.Operation.Backup;
|
|
|
|
internal static class RecreateMissingIndexFiles
|
|
{
|
|
/// <summary>
|
|
/// The tag used for log messages
|
|
/// </summary>
|
|
private static readonly string LOGTAG = Logging.Log.LogTagFromType(typeof(RecreateMissingIndexFiles));
|
|
|
|
public static async Task Run(BackupDatabase database, IBackendManager backendManager, Options options, ITaskReader taskreader)
|
|
{
|
|
if (options.IndexfilePolicy != Options.IndexFileStrategy.None)
|
|
{
|
|
var anyfiles = false;
|
|
await foreach (var blockfile in (await database.GetMissingIndexFilesAsync(taskreader.ProgressToken).ConfigureAwait(false)).ConfigureAwait(false))
|
|
{
|
|
if (!await taskreader.ProgressRendevouz().ConfigureAwait(false))
|
|
return;
|
|
|
|
Logging.Log.WriteInformationMessage(LOGTAG, "RecreateMissingIndexFile", "Re-creating missing index file for {0}", blockfile);
|
|
var w = await Common.IndexVolumeCreator.CreateIndexVolume(blockfile, options, database, taskreader.ProgressToken).ConfigureAwait(false);
|
|
|
|
if (!await taskreader.ProgressRendevouz().ConfigureAwait(false))
|
|
return;
|
|
|
|
anyfiles = true;
|
|
await database.UpdateRemoteVolumeAsync(w.RemoteFilename, RemoteVolumeState.Uploading, -1, null, false, default, null, taskreader.ProgressToken).ConfigureAwait(false);
|
|
|
|
if (options.Dryrun)
|
|
{
|
|
Logging.Log.WriteDryrunMessage(LOGTAG, "WouldUploadFile", "Would upload file: {0}", w.RemoteFilename);
|
|
}
|
|
else
|
|
{
|
|
await database.CommitTransactionAsync("RecreateMissingIndexFile", true, taskreader.ProgressToken).ConfigureAwait(false);
|
|
await backendManager.PutAsync(w, null, null, false, () => database.FlushBackendMessagesAndCommitAsync(backendManager, taskreader.ProgressToken), taskreader.ProgressToken).ConfigureAwait(false);
|
|
}
|
|
}
|
|
|
|
// If we uploaded/fixed any files, make sure the backup does not start before the files are settled
|
|
if (anyfiles)
|
|
{
|
|
await backendManager.WaitForEmptyAsync(taskreader.ProgressToken).ConfigureAwait(false);
|
|
await database.FlushBackendMessagesAndCommitAsync(backendManager, taskreader.ProgressToken).ConfigureAwait(false);
|
|
}
|
|
}
|
|
}
|
|
|
|
}
|
|
|