This PR has a large blast radius because it takes the final step and bumps up the Controller to be fully async. We have historically done a piece-by-piece update, so all operations were already async but the controller interface was kept synchronous. With this update, the controller is now fully async and all tests are updated. Most places where the new C# compiler warns about function names not ending in `Async` were also adressed, giving a massive refactor change. Functionally, no changes are done.
124 lines
5.4 KiB
C#
124 lines
5.4 KiB
C#
// Copyright (C) 2026, The Duplicati Team
|
|
// https://duplicati.com, hello@duplicati.com
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a
|
|
// copy of this software and associated documentation files (the "Software"),
|
|
// to deal in the Software without restriction, including without limitation
|
|
// the rights to use, copy, modify, merge, publish, distribute, sublicense,
|
|
// and/or sell copies of the Software, and to permit persons to whom the
|
|
// Software is furnished to do so, subject to the following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included in
|
|
// all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
|
|
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
// FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
|
|
// DEALINGS IN THE SOFTWARE.
|
|
|
|
using System.IO;
|
|
using NUnit.Framework;
|
|
using System.Linq;
|
|
using System;
|
|
using NUnit.Framework.Internal;
|
|
using System.IO.Compression;
|
|
using Duplicati.Library.DynamicLoader;
|
|
using System.Threading.Tasks;
|
|
|
|
namespace Duplicati.UnitTest
|
|
{
|
|
public class Issue6254 : BasicSetupHelper
|
|
{
|
|
[Test]
|
|
[Category("Targeted")]
|
|
public async Task VerifyCompactKeepsIndexFileBlocklistsAsync()
|
|
{
|
|
var testopts = TestOptions.Expand(new
|
|
{
|
|
no_encryption = true,
|
|
number_of_retries = 0,
|
|
keep_versions = 1,
|
|
no_auto_compact = true,
|
|
zip_compression_level = 0,
|
|
asynchronous_upload_limit = 1,
|
|
blocksize = "100kb",
|
|
dblock_size = "4mb"
|
|
});
|
|
|
|
var rnd = Random.Shared; //new Random(42);
|
|
var data1 = new byte[1024 * 1024 * 10];
|
|
rnd.NextBytes(data1);
|
|
var data2 = new byte[1024 * 1024 * 10];
|
|
rnd.NextBytes(data2);
|
|
|
|
// Create some files
|
|
for (var i = 0; i < 10; i++)
|
|
File.WriteAllBytes(Path.Combine(DATAFOLDER, $"a{i}"), data1.AsSpan().Slice(i, 1024 * 1024 * 2).ToArray());
|
|
|
|
// Make a backup
|
|
using (var c = new Library.Main.Controller("file://" + TARGETFOLDER, testopts, null))
|
|
TestUtils.AssertResults(await c.BackupAsync(new string[] { DATAFOLDER }));
|
|
|
|
// Add some second files
|
|
for (var i = 0; i < 10; i++)
|
|
File.WriteAllBytes(Path.Combine(DATAFOLDER, $"b{i}"), data2.AsSpan().Slice(i, 1024 * 1024 * 2).ToArray());
|
|
|
|
// Make a backup
|
|
using (var c = new Library.Main.Controller("file://" + TARGETFOLDER, testopts, null))
|
|
TestUtils.AssertResults(await c.BackupAsync(new string[] { DATAFOLDER }));
|
|
|
|
// Delete the first files
|
|
for (var i = 0; i < 8; i++)
|
|
File.Delete(Path.Combine(DATAFOLDER, $"a{i}"));
|
|
|
|
var indexfiles = Directory.GetFiles(TARGETFOLDER, "*.dindex.*", SearchOption.TopDirectoryOnly).ToHashSet();
|
|
|
|
// Make a backup
|
|
using (var c = new Library.Main.Controller("file://" + TARGETFOLDER, testopts, null))
|
|
TestUtils.AssertResults(await c.BackupAsync(new string[] { DATAFOLDER }));
|
|
|
|
// Now run compact
|
|
using (var c = new Library.Main.Controller("file://" + TARGETFOLDER, testopts, null))
|
|
TestUtils.AssertResults(await c.CompactAsync());
|
|
|
|
// Find the new index files
|
|
var newIndexFiles = Directory.GetFiles(TARGETFOLDER, "*.dindex.*", SearchOption.TopDirectoryOnly)
|
|
.Where(x => !indexfiles.Contains(x))
|
|
.ToList();
|
|
|
|
Assert.That(newIndexFiles.Count, Is.GreaterThan(0), "No new index files found");
|
|
|
|
// Check that the new index files contains the list folder
|
|
var matches = 0;
|
|
foreach (var file in newIndexFiles)
|
|
{
|
|
using var zip = new ZipArchive(File.OpenRead(file), ZipArchiveMode.Read);
|
|
if (zip.Entries.Any(x => x.FullName.StartsWith("list/")))
|
|
matches++;
|
|
}
|
|
|
|
// Test is essentially inconclusive here, as the repair does not cover the blocklist hashes
|
|
// but we cannot control it closely enough to make it always work
|
|
//Assert.That(matches, Is.EqualTo(newIndexFiles.Count), "No new index files found with list folder");
|
|
|
|
// Check that recreate does not load dblock files
|
|
BackendLoader.AddBackend(new DeterministicErrorBackend());
|
|
File.Delete(DBFILE);
|
|
|
|
DeterministicErrorBackend.ErrorGenerator = (action, remotename) =>
|
|
{
|
|
if (action.IsGetOperation && remotename.Contains(".dblock."))
|
|
return true;
|
|
return false;
|
|
};
|
|
|
|
using (var c = new Library.Main.Controller(new DeterministicErrorBackend().ProtocolKey + "://" + TARGETFOLDER, testopts, null))
|
|
TestUtils.AssertResults(await c.RepairAsync());
|
|
}
|
|
}
|
|
}
|
|
|