Tyler Gill
38883285ee
By changing to IEnumerable, it is possible to iterate only a portion of the list, which is useful when not all entries are needed (e.g., when testing a connection). All existing backends have been updated, and any which were able to be changed to yield return results in a straightforward way now do. Many backends had a try/catch in the List() method. Due to the fact that yield returns can't be placed within a try/catch block, these have been refactored to either scope the try/catch to the parts that (should) be the only places throwing exceptions, so that exceptions are still caught and handled. Note that lazy evaluation may cause some changes in behavior - exceptions that were previously thrown at the point of invokation of List() may now be thrown while it is being enumerated. I believe this will not be problematic though, as the only well-known exception seems to be FolderMissingException, which should be thrown by Test(), but TestList() attempts to enumerate the list to force this exception. Any places that require the legacy behavior can get it by simply converting the lazy enumerable to a List()
29 lines
891 B
C#
29 lines
891 B
C#
using System;
|
|
using System.Collections.Generic;
|
|
using System.Linq;
|
|
using System.Text;
|
|
using System.Threading.Tasks;
|
|
|
|
namespace Duplicati.Library.Interface
|
|
{
|
|
/// <summary>
|
|
/// Contains extension methods for the IBackend interfaces
|
|
/// </summary>
|
|
public static class BackendExtensions
|
|
{
|
|
/// <summary>
|
|
/// Tests a backend by invoking the List() method.
|
|
/// As long as the iteration can either complete or find at least one file without throwing, the test is successful
|
|
/// </summary>
|
|
/// <param name="backend">Backend to test</param>
|
|
public static void TestList(this IBackend backend)
|
|
{
|
|
// If we can iterate successfully, even if it's empty, then the backend test is successful
|
|
foreach (IFileEntry file in backend.List())
|
|
{
|
|
break;
|
|
}
|
|
}
|
|
}
|
|
}
|