Files
duplicati/Duplicati/Library/Main/Operation/Restore/VolumeDecryptor.cs
T
Kenneth Skovhede f03cf2f7a3 Detatch options on controller
When creating a new controller, the options dictionary was used by-reference.

This meant that code could update the options dictionary *after* creating the controller, which would not be thread-safe.

It does not have much effect on regular operations as the normal method is to create the dictionary, pass it, and not modify it.

But in the tests, we frequently re-use the dictionary and update it with new values to test various cases.

Due to the dictionary being a reference, the controller would update the dictionary to fit the operations, but this would reflect back into the tests, meaning that some tests were being run with options that were not supposed to be there.

This meant that at least two edge cases that we test for were never found to have errors, even though they do.

The first issue is the listing of files using a non-default blocksize. The second issue is recreating the database with a non-default file-hash algorithm.

This PR removes the reference passing, and fixes the issues that were uncovered.
2026-05-14 17:59:49 +02:00

119 lines
5.6 KiB
C#

// Copyright (C) 2026, The Duplicati Team
// https://duplicati.com, hello@duplicati.com
//
// Permission is hereby granted, free of charge, to any person obtaining a
// copy of this software and associated documentation files (the "Software"),
// to deal in the Software without restriction, including without limitation
// the rights to use, copy, modify, merge, publish, distribute, sublicense,
// and/or sell copies of the Software, and to permit persons to whom the
// Software is furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
// FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
// DEALINGS IN THE SOFTWARE.
using System;
using System.Diagnostics;
using System.Linq;
using System.Threading;
using System.Threading.Tasks;
using CoCoL;
using Duplicati.Library.Main.Volumes;
#nullable enable
namespace Duplicati.Library.Main.Operation.Restore
{
/// <summary>
/// Process that decrypts the volumes that the `VolumeDownloader` process has downloaded.
/// </summary>
internal class VolumeDecryptor
{
/// <summary>
/// The log tag for this class.
/// </summary>
private static readonly string LOGTAG = Logging.Log.LogTagFromType<VolumeDecryptor>();
/// <summary>
/// Runs the volume decryptor process.
/// </summary>
/// <param name="channels">The named channels for the restore operation.</param>
/// <param name="backend">The backend manager.</param>
/// <param name="options">The restore options.</param>
public static Task RunAsync(Channels channels, IBackendManager backend, Options options)
{
return AutomationExtensions.RunTask(
new
{
Input = channels.DecryptRequest.AsRead(),
Output = channels.VolumeResponse.AsWrite()
},
async self =>
{
Stopwatch? sw_read = options.InternalProfiling ? new() : null;
Stopwatch? sw_write = options.InternalProfiling ? new() : null;
Stopwatch? sw_decrypt = options.InternalProfiling ? new() : null;
Stopwatch? sw_bvr = options.InternalProfiling ? new() : null;
Stopwatch? sw_vw = options.InternalProfiling ? new() : null;
try
{
while (true)
{
// Get the block request and volume from the `VolumeDownloader` process.
sw_read?.Start();
var (volume_id, volume_name, volume) = await self.Input.ReadAsync().ConfigureAwait(false);
sw_read?.Stop();
Logging.Log.WriteExplicitMessage(LOGTAG, "DecryptVolume", null, "Decrypting volume {0} (ID: {1})", volume_name, volume_id);
// Decrypt the volume.
sw_decrypt?.Start();
var tmpfile = backend.DecryptFile(volume, volume_name, options, dispose: true);
sw_decrypt?.Stop();
Logging.Log.WriteExplicitMessage(LOGTAG, "DecryptVolume", null, "Decrypted volume {0} (ID: {1})", volume_name, volume_id);
// TODO These two steps could be moved to another process to allow even more parallelism.
sw_bvr?.Start();
var bvr = new BlockVolumeReader(options.CompressionModule, tmpfile, options);
sw_bvr?.Stop();
sw_vw?.Start();
var volume_wrapper = new VolumeWrapper(tmpfile, bvr);
sw_vw?.Stop();
Logging.Log.WriteExplicitMessage(LOGTAG, "BlockVolumeReader", null, "Created BlockVolumeReader for volume {0} (ID: {1})", volume_name, volume_id);
sw_write?.Start();
// Pass the decrypted volume to the `VolumeDecompressor` process.
await self.Output.WriteAsync((volume_id, volume_wrapper)).ConfigureAwait(false);
sw_write?.Stop();
Logging.Log.WriteExplicitMessage(LOGTAG, "DecryptVolume", null, "Passed decrypted volume {0} (ID: {1}) to next stage", volume_name, volume_id);
}
}
catch (RetiredException)
{
Logging.Log.WriteVerboseMessage(LOGTAG, "RetiredProcess", null, "Volume decryptor retired");
if (options.InternalProfiling)
{
Logging.Log.WriteProfilingMessage(LOGTAG, "InternalTimings", $"Read: {sw_read!.ElapsedMilliseconds}ms, Decrypt: {sw_decrypt!.ElapsedMilliseconds}ms, BlockVolumeReader: {sw_bvr!.ElapsedMilliseconds}ms, VolumeWrapper: {sw_vw!.ElapsedMilliseconds}ms, Write: {sw_write!.ElapsedMilliseconds}ms");
}
}
catch (Exception ex)
{
Logging.Log.WriteErrorMessage(LOGTAG, "DecryptionError", ex, "Error during decryption");
self.Input.Retire();
self.Output.Retire();
throw;
}
});
}
}
}