This PR fixes an issue with using a non-default compression method. The recreate database will detect the compression module correctly and restore everything. But when recreating the database it will look at the `compression-module` from the given options and persist this value into the database. If the recreate was made without passing in the compression module in the options, the default compression module would be persisted to the database, which would later cause problems for operations that rely on this value. With this PR there is a test for the behavior, and the compression module is extracted from the first volume, similar to how blocksize and other options are written back.
283 lines
12 KiB
C#
283 lines
12 KiB
C#
// Copyright (C) 2026, The Duplicati Team
|
|
// https://duplicati.com, hello@duplicati.com
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a
|
|
// copy of this software and associated documentation files (the "Software"),
|
|
// to deal in the Software without restriction, including without limitation
|
|
// the rights to use, copy, modify, merge, publish, distribute, sublicense,
|
|
// and/or sell copies of the Software, and to permit persons to whom the
|
|
// Software is furnished to do so, subject to the following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included in
|
|
// all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
|
|
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
// FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
|
|
// DEALINGS IN THE SOFTWARE.
|
|
using Duplicati.Library.Interface;
|
|
using Duplicati.Library.Utility;
|
|
using Newtonsoft.Json;
|
|
using System;
|
|
using System.Collections.Generic;
|
|
using System.IO;
|
|
|
|
namespace Duplicati.Library.Main.Volumes
|
|
{
|
|
public abstract class VolumeReaderBase : VolumeBase, IDisposable
|
|
{
|
|
public bool IsFullBackup { get; set; }
|
|
|
|
protected readonly bool m_disposeCompression = false;
|
|
protected ICompression m_compression;
|
|
protected Stream m_stream;
|
|
|
|
private static ICompression LoadCompressor(string compressor, Stream stream, Options options)
|
|
{
|
|
var tmp = DynamicLoader.CompressionLoader.GetModule(compressor, stream, Interface.ArchiveMode.Read, options.RawOptions);
|
|
if (tmp == null)
|
|
{
|
|
var name = "[stream]";
|
|
if (stream is FileStream fileStream)
|
|
name = fileStream.Name;
|
|
|
|
throw new Exception(string.Format("Unable to create {0} decompressor on file {1}", compressor, name));
|
|
}
|
|
|
|
return tmp;
|
|
}
|
|
|
|
private static ICompression LoadCompressor(string compressor, string file, Options options, out Stream stream)
|
|
{
|
|
stream = new System.IO.FileStream(file, FileMode.Open, FileAccess.Read, FileShare.Read);
|
|
return LoadCompressor(compressor, stream, options);
|
|
}
|
|
|
|
protected VolumeReaderBase(string compressor, string file, Options options)
|
|
: base(options)
|
|
{
|
|
m_compression = LoadCompressor(compressor, file, options, out m_stream);
|
|
|
|
ReadFileset();
|
|
|
|
ReadManifests(options);
|
|
|
|
m_disposeCompression = true;
|
|
}
|
|
|
|
protected VolumeReaderBase(ICompression compression, Options options)
|
|
: base(options)
|
|
{
|
|
m_compression = compression;
|
|
ReadManifests(options);
|
|
}
|
|
|
|
private void ReadFileset()
|
|
{
|
|
using (var s = m_compression.OpenRead(FILESET_FILENAME))
|
|
{
|
|
if (s == null)
|
|
{
|
|
IsFullBackup = new FilesetData().IsFullBackup; // use default value
|
|
}
|
|
else
|
|
{
|
|
using (var fs = new StreamReader(s, ENCODING))
|
|
{
|
|
FilesetData fileset = JsonConvert.DeserializeObject<FilesetData>(fs.ReadToEnd());
|
|
IsFullBackup = fileset.IsFullBackup;
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
private void ReadManifests(Options options)
|
|
{
|
|
if (options.DontReadManifests) return;
|
|
|
|
using (var s = m_compression.OpenRead(MANIFEST_FILENAME))
|
|
{
|
|
if (s == null)
|
|
{
|
|
throw new InvalidManifestException("No manifest file found in volume");
|
|
}
|
|
|
|
using (var fs = new StreamReader(s, ENCODING))
|
|
{
|
|
ManifestData.VerifyManifest(fs.ReadToEnd(), m_blocksize, options.BlockHashAlgorithm, options.FileHashAlgorithm);
|
|
}
|
|
}
|
|
}
|
|
|
|
public static FilesetData GetFilesetData(string compressor, string file, Options options)
|
|
{
|
|
using (var stream = new FileStream(file, FileMode.Open, FileAccess.Read, FileShare.Read))
|
|
using (var c = LoadCompressor(compressor, stream, options))
|
|
return GetFilesetData(c, options);
|
|
}
|
|
|
|
public static FilesetData GetFilesetData(ICompression compressor, Options options)
|
|
{
|
|
using (var s = compressor.OpenRead(FILESET_FILENAME))
|
|
{
|
|
if (s == null)
|
|
{
|
|
return new FilesetData(); // return default
|
|
}
|
|
|
|
using (var fs = new StreamReader(s, ENCODING))
|
|
{
|
|
return JsonConvert.DeserializeObject<FilesetData>(fs.ReadToEnd());
|
|
}
|
|
}
|
|
}
|
|
|
|
/// <summary>
|
|
/// Updates the options with data from the manifest file, but does not overwrite existing values
|
|
/// </summary>
|
|
/// <param name="compressor">The compressor to use</param>
|
|
/// <param name="file">The file to read the manifest from</param>
|
|
/// <param name="options">The options to update</param>
|
|
public static void UpdateOptionsFromManifest(string compressor, string file, Options options)
|
|
{
|
|
using (var stream = new System.IO.FileStream(file, FileMode.Open, FileAccess.Read, FileShare.Read))
|
|
using (var c = LoadCompressor(compressor, stream, options))
|
|
UpdateOptionsFromManifest(c, options);
|
|
|
|
}
|
|
|
|
/// <summary>
|
|
/// Updates the options with data from the manifest file, but does not overwrite existing values
|
|
/// </summary>
|
|
/// <param name="compressor">The compressor to use</param>
|
|
/// <param name="file">The file to read the manifest from</param>
|
|
/// <param name="options">The options to update</param>
|
|
public static void UpdateOptionsFromManifest(ICompression compressor, Options options)
|
|
{
|
|
using (var s = compressor.OpenRead(MANIFEST_FILENAME))
|
|
using (var fs = new StreamReader(s, ENCODING))
|
|
{
|
|
var d = JsonConvert.DeserializeObject<ManifestData>(fs.ReadToEnd());
|
|
if (d.Version > ManifestData.VERSION)
|
|
throw new InvalidManifestException("Version", d.Version.ToString(), ManifestData.VERSION.ToString());
|
|
|
|
if (string.IsNullOrWhiteSpace(options.RawOptions.GetValueOrDefault("blocksize")))
|
|
options.RawOptions["blocksize"] = d.Blocksize + "b";
|
|
if (string.IsNullOrWhiteSpace(options.RawOptions.GetValueOrDefault("block-hash-algorithm")))
|
|
options.RawOptions["block-hash-algorithm"] = d.BlockHash;
|
|
if (string.IsNullOrWhiteSpace(options.RawOptions.GetValueOrDefault("file-hash-algorithm")))
|
|
options.RawOptions["file-hash-algorithm"] = d.FileHash;
|
|
if (string.IsNullOrWhiteSpace(options.RawOptions.GetValueOrDefault("compression-module")))
|
|
options.RawOptions["compression-module"] = compressor.FilenameExtension;
|
|
}
|
|
}
|
|
|
|
public virtual void Dispose()
|
|
{
|
|
if (m_disposeCompression && m_compression != null)
|
|
{
|
|
m_compression.Dispose();
|
|
m_compression = null;
|
|
|
|
m_stream?.Dispose();
|
|
m_stream = null;
|
|
}
|
|
}
|
|
|
|
/// <summary>
|
|
/// Reads the blocklist from the file, not checking if the hash is correct
|
|
/// </summary>
|
|
/// <param name="compression">The compression to use</param>
|
|
/// <param name="filename">The file to read the blocklist from</param>
|
|
/// <param name="hashsize">The size of the hash</param>
|
|
/// <returns>The blocklist</returns>
|
|
public static IEnumerable<string> ReadBlocklistUnverified(ICompression compression, string filename, long hashsize)
|
|
{
|
|
var buffer = new byte[hashsize];
|
|
using (var fs = compression.OpenRead(filename))
|
|
{
|
|
int s;
|
|
var read = 0L;
|
|
while ((s = Library.Utility.Utility.ForceStreamRead(fs, buffer, buffer.Length)) != 0)
|
|
{
|
|
if (s != buffer.Length)
|
|
throw new InvalidDataException($"Premature End-of-stream encountered while reading blocklist hashes for {filename}. Got {s} bytes of {buffer.Length} at offset {read * buffer.Length}");
|
|
|
|
read++;
|
|
yield return Convert.ToBase64String(buffer);
|
|
}
|
|
}
|
|
}
|
|
|
|
/// <summary>
|
|
/// Read blocklist and check the hash. Throws InvalidDataException if not matching
|
|
/// </summary>
|
|
/// <param name="compression">The compression to use</param>
|
|
/// <param name="filename">The file to read the blocklist from</param>
|
|
/// <param name="hashsize">The size of the hash</param>
|
|
/// <param name="hash">The hash to check against</param>
|
|
/// <param name="blockHashAlgorithm">The block hash algorithm to use</param>
|
|
public static IEnumerable<string> ReadBlocklistVerified(ICompression compression, string filename, long hashsize, string hash, string blockHashAlgorithm)
|
|
{
|
|
var buffer = new byte[hashsize];
|
|
using var hashalg = HashFactory.CreateHasher(blockHashAlgorithm);
|
|
using var fs = compression.OpenRead(filename);
|
|
|
|
if (fs == null)
|
|
throw new InvalidDataException($"Blocklist file {filename} not found in archive");
|
|
|
|
int s;
|
|
var read = 0L;
|
|
while ((s = Library.Utility.Utility.ForceStreamRead(fs, buffer, buffer.Length)) != 0)
|
|
{
|
|
if (s != buffer.Length)
|
|
throw new InvalidDataException($"Premature End-of-stream encountered while reading blocklist hashes for {filename}. Got {s} bytes of {buffer.Length} at offset {read * buffer.Length}");
|
|
|
|
read++;
|
|
hashalg.TransformBlock(buffer, 0, s, buffer, 0);
|
|
yield return Convert.ToBase64String(buffer);
|
|
}
|
|
|
|
hashalg.TransformFinalBlock(buffer, 0, 0);
|
|
var calculatedHash = Convert.ToBase64String(hashalg.Hash);
|
|
if (hash != calculatedHash)
|
|
throw new InvalidDataException($"Blocklist hash does not match: expected {hash}, got {calculatedHash}");
|
|
}
|
|
|
|
protected static object SkipJsonToken(JsonReader reader, JsonToken type)
|
|
{
|
|
if (!reader.Read() || reader.TokenType != type)
|
|
throw new InvalidDataException(string.Format("Invalid JSON, expected \"{0}\", but got {1}, {2}", type, reader.TokenType, reader.Value));
|
|
|
|
return reader.Value;
|
|
}
|
|
|
|
protected static object ReadJsonProperty(JsonReader reader, string propertyname, JsonToken type)
|
|
{
|
|
var p = SkipJsonToken(reader, JsonToken.PropertyName);
|
|
if (p == null || p.ToString() != propertyname)
|
|
throw new InvalidDataException(string.Format("Invalid JSON, expected property \"{0}\", but got {1}, {2}", propertyname, reader.TokenType, reader.Value));
|
|
|
|
return SkipJsonToken(reader, type);
|
|
}
|
|
|
|
protected static string ReadJsonStringProperty(JsonReader reader, string propertyname)
|
|
{
|
|
return ReadJsonProperty(reader, propertyname, JsonToken.String).ToString();
|
|
}
|
|
|
|
protected static long ReadJsonInt64Property(JsonReader reader, string propertyname)
|
|
{
|
|
return Convert.ToInt64(ReadJsonProperty(reader, propertyname, JsonToken.Integer));
|
|
}
|
|
|
|
protected static DateTime ReadJsonDateTimeProperty(JsonReader reader, string propertyname)
|
|
{
|
|
return Library.Utility.Utility.DeserializeDateTime(ReadJsonStringProperty(reader, propertyname));
|
|
}
|
|
}
|
|
}
|