Files
duplicati/Duplicati/WebserverCore/Services/RemoteControllerHandler.cs
T
Kenneth Skovhede b26782ddf1 Improve config speed from console
This PR updates the remove configuration to receive configuration directly on connection, instead of waiting for the server to send it.

This also adds a hibernation setting that will let the server tell the client to stop connecting for a while which can reduce resource consumption at the cost of not being always available.
2026-04-21 14:47:03 +02:00

217 lines
11 KiB
C#

// Copyright (C) 2026, The Duplicati Team
// https://duplicati.com, hello@duplicati.com
//
// Permission is hereby granted, free of charge, to any person obtaining a
// copy of this software and associated documentation files (the "Software"),
// to deal in the Software without restriction, including without limitation
// the rights to use, copy, modify, merge, publish, distribute, sublicense,
// and/or sell copies of the Software, and to permit persons to whom the
// Software is furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
// FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
// DEALINGS IN THE SOFTWARE.
using System.Net.Http.Headers;
using Duplicati.Library.Logging;
using Duplicati.Library.RemoteControl;
using Duplicati.Server.Database;
using Duplicati.Server.Serialization;
using Duplicati.WebserverCore.Abstractions;
using Newtonsoft.Json;
namespace Duplicati.WebserverCore.Services;
/// <summary>
/// Controller for handling remote control messages.
/// </summary>
/// <param name="connection">The connection to the database</param>
/// <param name="httpClientFactory">The HTTP client factory</param>
/// <param name="jwtTokenProvider">The JWT token provider</param>
public class RemoteControllerHandler(Connection connection, IHttpClientFactory httpClientFactory, IJWTTokenProvider jwtTokenProvider, IApplicationSettings applicationSettings) : IRemoteControllerHandler
{
/// <summary>
/// The log tag for this class.
/// </summary>
private static readonly string LOGTAG = Log.LogTagFromType<RemoteControllerHandler>();
/// <inheritdoc/>
public Task<Dictionary<string, string?>> OnConnect(Dictionary<string, string?> metadata)
{
metadata["feature:additional-report-url"] = connection.ApplicationSettings.AdditionalReportUrl;
return Task.FromResult(metadata);
}
/// <inheritdoc/>
public Task ReKey(ClaimedClientData data)
{
var oldCerts = connection.ApplicationSettings.RemoteControlConfig == null
? null
: JsonConvert.DeserializeObject<RemoteControlConfig>(connection.ApplicationSettings.RemoteControlConfig)?.ServerCertificates;
connection.ApplicationSettings.RemoteControlConfig = JsonConvert.SerializeObject(new RemoteControlConfig
{
Token = data.JWT,
ServerCertificates = data.ServerCertificates ?? oldCerts ?? [],
ServerUrl = data.ServerUrl,
CertificateUrl = data.CertificateUrl
});
if (!applicationSettings.SettingsEncryptionKeyProvidedExternally)
{
// TODO: Implement changing the encryption key
// if (!string.IsNullOrWhiteSpace(data.LocalEncryptionKey) && data.LocalEncryptionKey != connection.ApplicationSettings.SettingsEncryptionKey)
// connection.ChangeDbKey(keydata.LocalEncryptionKey);
}
return Task.CompletedTask;
}
/// <inheritdoc/>
public async Task OnControl(KeepRemoteConnection.ControlMessage message)
{
// Make method async
await Task.CompletedTask;
Dictionary<string, string?>? result = null;
var refreshSettingsBy = DateTimeOffset.MinValue;
Log.WriteMessage(LogMessageType.Verbose, LOGTAG, "OnControl", "Received control message: {0}", message);
try
{
if (string.Equals(message.ControlRequestMessage.Command, ControlRequestMessage.UpdateSettingsCommand, StringComparison.OrdinalIgnoreCase))
{
result = new Dictionary<string, string?>
{
[ControlResponseMessage.SettingsVersionKey] = message.ControlRequestMessage.Parameters.GetValueOrDefault(ControlRequestMessage.SettingsVersionKey)
};
connection.ApplicationSettings.AdditionalReportUrl = message.ControlRequestMessage.Parameters.GetValueOrDefault(ControlRequestMessage.ReportUrlKey);
connection.ApplicationSettings.RemoteControlDashboardUrl = message.ControlRequestMessage.Parameters.GetValueOrDefault(ControlRequestMessage.DashboardUrlKey);
connection.ApplicationSettings.RemoteControlStorageApiId = message.ControlRequestMessage.Parameters.GetValueOrDefault(ControlRequestMessage.StorageApiIdKey);
connection.ApplicationSettings.RemoteControlStorageApiKey = message.ControlRequestMessage.Parameters.GetValueOrDefault(ControlRequestMessage.StorageApiKeyKey);
connection.ApplicationSettings.RemoteControlStorageEndpointUrl = message.ControlRequestMessage.Parameters.GetValueOrDefault(ControlRequestMessage.StorageEndpointUrlKey);
var newLicenseKey = message.ControlRequestMessage.Parameters.GetValueOrDefault(ControlRequestMessage.ClientLicenseKeyKey);
var currentLicenseKey = connection.ApplicationSettings.ClientLicenseKey;
if (newLicenseKey != currentLicenseKey)
{
connection.ApplicationSettings.ClientLicenseKey = newLicenseKey;
Duplicati.Proprietary.LicenseChecker.LicenseHelper.SetRemoteClientLicenseKey(newLicenseKey);
}
var backupConfigs = message.ControlRequestMessage.Parameters
.Where(kv => kv.Key.StartsWith(ControlRequestMessage.BackupConfigKeyPrefix, StringComparison.OrdinalIgnoreCase))
.Select(kv => kv.Key)
.ToHashSet();
var existingBackups = connection.Backups.Where(x => !string.IsNullOrWhiteSpace(x.ExternalID) && x.ExternalID.StartsWith(ControlRequestMessage.BackupConfigKeyPrefix, StringComparison.OrdinalIgnoreCase))
.ToDictionary(x => x.ExternalID!, x => x);
var deletedBackupIds = existingBackups.Where(kv => !backupConfigs.Contains(kv.Key)).Select(kv => kv.Value.ID).ToList();
foreach (var id in deletedBackupIds)
connection.DeleteBackup(long.Parse(id));
foreach (var externalId in backupConfigs)
{
var config = message.ControlRequestMessage.Parameters.GetValueOrDefault(externalId);
if (string.IsNullOrWhiteSpace(config))
continue;
using var reader = new StringReader(config);
var importData = Serializer.Deserialize<Server.Serializable.ImportExportStructure>(reader);
if (importData?.Backup == null)
continue;
importData.Backup.ExternalID = externalId;
importData.Backup.ID = null;
importData.Backup.SetDBPath(null);
importData.Backup.Metadata = null;
// Keep ID and DBPath if the backup already exists
if (existingBackups.TryGetValue(externalId, out var existing))
importData.Backup.ID = existing.ID;
connection.AddOrUpdateBackupAndSchedule(importData.Backup, importData.Schedule);
}
try
{
// Check if we need to delay the next reconnection
var refreshSettingsByValue = message.ControlRequestMessage.Parameters.GetValueOrDefault(ControlRequestMessage.RefreshSettingsByKey);
if (!string.IsNullOrWhiteSpace(refreshSettingsByValue) && long.TryParse(refreshSettingsByValue, out var refreshSettingsByLong) && refreshSettingsByLong > 0)
{
var target = DateTimeOffset.FromUnixTimeSeconds(refreshSettingsByLong);
if (target > DateTimeOffset.UtcNow)
refreshSettingsBy = target;
// Agent keeps its own config, and does not support connection delays
if (applicationSettings.Origin != "Agent")
{
var connstr = connection.ApplicationSettings.RemoteControlConfig;
if (!string.IsNullOrWhiteSpace(connstr))
{
var prevCfg = JsonConvert.DeserializeObject<RemoteControlConfig>(connstr);
if (prevCfg != null)
connection.ApplicationSettings.RemoteControlConfig = JsonConvert.SerializeObject(
prevCfg with { RefreshSettingsBy = target }
);
}
}
}
}
catch (Exception ex)
{
Log.WriteMessage(LogMessageType.Error, LOGTAG, "OnControl", ex, "Failed to update refreshSettingsBy");
}
}
}
catch (Exception ex)
{
Log.WriteMessage(LogMessageType.Error, LOGTAG, "OnControl", ex, "Failed to handle control message: {0}", message);
message.Respond(new ControlResponseMessage(false, null, ex.Message));
return;
}
// Respond first, then disconnect if needed
message.Respond(new ControlResponseMessage(true, result, null));
if (refreshSettingsBy > DateTimeOffset.UtcNow)
{
Log.WriteMessage(LogMessageType.Information, LOGTAG, "OnControl", "Requesting disconnect after responding to control message");
message.RequestDisconnect(refreshSettingsBy);
}
}
/// <inheritdoc/>
public async Task OnMessage(KeepRemoteConnection.CommandMessage commandMessage)
{
if (connection.ApplicationSettings.DisableConsoleControl)
{
commandMessage.Respond(new CommandResponseMessage(501, "Remote control is disabled.", null));
return;
}
using var httpClient = httpClientFactory.CreateClient();
var token = jwtTokenProvider.CreateAccessToken("remote-control", jwtTokenProvider.TemporaryFamilyId, TimeSpan.FromMinutes(2));
httpClient.BaseAddress = new Uri($"{(connection.ApplicationSettings.UseHTTPS ? "https" : "http")}://127.0.0.1:{connection.ApplicationSettings.LastWebserverPort}");
httpClient.DefaultRequestHeaders.Authorization = new AuthenticationHeaderValue("Bearer", token);
var psk = Middlewares.PreSharedKeyFilter.PreSharedKey;
if (!string.IsNullOrWhiteSpace(psk))
httpClient.DefaultRequestHeaders.Add(Middlewares.PreSharedKeyFilter.HeaderName, psk);
await commandMessage.Handle(httpClient);
}
}