This PR fixes the issues with not correctly loading and disposing modules. Prior to this PR, there would be only a single instance of each module loaded, which would be configured and later disposed, meaning that the same instance would be used after being disposed, and disposed multiple times. This mostly worked, but it could carry configuration details over between unrelated runs. This fixes #6314
202 lines
8.4 KiB
C#
202 lines
8.4 KiB
C#
// Copyright (C) 2025, The Duplicati Team
|
|
// https://duplicati.com, hello@duplicati.com
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a
|
|
// copy of this software and associated documentation files (the "Software"),
|
|
// to deal in the Software without restriction, including without limitation
|
|
// the rights to use, copy, modify, merge, publish, distribute, sublicense,
|
|
// and/or sell copies of the Software, and to permit persons to whom the
|
|
// Software is furnished to do so, subject to the following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included in
|
|
// all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
|
|
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
// FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
|
|
// DEALINGS IN THE SOFTWARE.
|
|
using Duplicati.Library.Interface;
|
|
using Duplicati.Library.Main;
|
|
using Duplicati.Library.Utility;
|
|
using Duplicati.Server;
|
|
using Duplicati.Server.Database;
|
|
using Duplicati.WebserverCore.Abstractions;
|
|
using Duplicati.WebserverCore.Exceptions;
|
|
using Microsoft.AspNetCore.Mvc;
|
|
using InvalidCertificateException = Duplicati.Library.Utility.SslCertificateValidator.InvalidCertificateException;
|
|
|
|
namespace Duplicati.WebserverCore.Endpoints.V1
|
|
{
|
|
public class RemoteOperation : IEndpointV1
|
|
{
|
|
private record RemoteOperationInput(string path);
|
|
|
|
public static void Map(RouteGroupBuilder group)
|
|
{
|
|
group.MapPost("/remoteoperation/dbpath", ([FromBody] RemoteOperationInput input)
|
|
=> ExecuteDbPath(input.path))
|
|
.RequireAuthorization();
|
|
|
|
group.MapPost("/remoteoperation/test", ([FromServices] Connection connection, [FromServices] IApplicationSettings applicationSettings, [FromQuery] bool? autocreate, [FromBody] RemoteOperationInput input, CancellationToken cancelToken)
|
|
=> ExecuteTest(connection, applicationSettings, input.path, autocreate ?? false, cancelToken))
|
|
.RequireAuthorization();
|
|
|
|
group.MapPost("/remoteoperation/create", ([FromBody] RemoteOperationInput input, CancellationToken cancelToken)
|
|
=> ExecuteCreate(input.path, cancelToken))
|
|
.RequireAuthorization();
|
|
}
|
|
|
|
private static Dto.GetDbPathDto ExecuteDbPath(string uri)
|
|
{
|
|
var path = CLIDatabaseLocator.GetDatabasePathForCLI(uri, null, false, false);
|
|
return new Dto.GetDbPathDto(!string.IsNullOrWhiteSpace(path), path);
|
|
}
|
|
|
|
private static Dictionary<string, string?> ParseUrlOptions(Connection connection, Library.Utility.Uri uri)
|
|
{
|
|
var qp = uri.QueryParameters;
|
|
|
|
var opts = Runner.GetCommonOptions(connection);
|
|
foreach (var k in qp.Keys.Cast<string>())
|
|
opts[k] = qp[k];
|
|
|
|
return opts;
|
|
}
|
|
|
|
private static IEnumerable<IGenericModule> ConfigureModules(IDictionary<string, string?> opts)
|
|
{
|
|
var modules = Library.DynamicLoader.GenericLoader.Modules.OfType<IConnectionModule>()
|
|
.Select(x => Library.DynamicLoader.GenericLoader.GetModule(x.Key))
|
|
.WhereNotNull()
|
|
.ToArray();
|
|
|
|
foreach (var n in modules)
|
|
n.Configure(opts);
|
|
|
|
return modules;
|
|
}
|
|
private record TupleDisposeWrapper(IBackend Backend, IEnumerable<IGenericModule> Modules) : IDisposable
|
|
{
|
|
public void Dispose()
|
|
{
|
|
Backend.Dispose();
|
|
foreach (var n in Modules)
|
|
if (n is IDisposable disposable)
|
|
disposable.Dispose();
|
|
}
|
|
}
|
|
|
|
private static async Task<TupleDisposeWrapper> GetBackend(Connection connection, IApplicationSettings applicationSettings, string url, CancellationToken cancelToken)
|
|
{
|
|
var uri = new Library.Utility.Uri(url);
|
|
var opts = ParseUrlOptions(connection, uri);
|
|
|
|
var tmp = new[] { uri };
|
|
await SecretProviderHelper.ApplySecretProviderAsync([], tmp, opts, Library.Utility.TempFolder.SystemTempPath, applicationSettings.SecretProvider, cancelToken);
|
|
url = tmp[0].ToString();
|
|
|
|
var modules = ConfigureModules(opts);
|
|
var backend = Library.DynamicLoader.BackendLoader.GetBackend(url, new Dictionary<string, string>());
|
|
return new TupleDisposeWrapper(backend, modules);
|
|
}
|
|
|
|
private static Exception GetInnerException<T>(Exception ex) where T : Exception
|
|
{
|
|
var original = ex;
|
|
while (true)
|
|
{
|
|
if (ex == null)
|
|
return original;
|
|
|
|
if (ex is T)
|
|
return (T)ex;
|
|
|
|
if (ex.InnerException == null)
|
|
throw new ArgumentNullException(nameof(ex.InnerException));
|
|
|
|
ex = ex.InnerException;
|
|
}
|
|
}
|
|
|
|
private static async Task ExecuteTest(Connection connection, IApplicationSettings applicationSettings, string url, bool autoCreate, CancellationToken cancelToken)
|
|
{
|
|
TupleDisposeWrapper? wrapper = null;
|
|
|
|
try
|
|
{
|
|
wrapper = await GetBackend(connection, applicationSettings, url, cancelToken);
|
|
|
|
using (var b = wrapper.Backend)
|
|
{
|
|
try { await b.TestAsync(cancelToken).ConfigureAwait(false); }
|
|
catch (Exception ex) when (GetInnerException<FolderMissingException>(ex) is FolderMissingException)
|
|
{
|
|
if (!autoCreate)
|
|
throw;
|
|
|
|
await b.CreateFolderAsync(cancelToken).ConfigureAwait(false);
|
|
await b.TestAsync(cancelToken).ConfigureAwait(false);
|
|
}
|
|
|
|
return;
|
|
}
|
|
}
|
|
catch (Exception ex) when (GetInnerException<FolderMissingException>(ex) is FolderMissingException)
|
|
{
|
|
if (autoCreate)
|
|
throw new ServerErrorException("error-creating-folder");
|
|
throw new ServerErrorException("missing-folder");
|
|
}
|
|
catch (Exception ex) when (GetInnerException<InvalidCertificateException>(ex) is InvalidCertificateException icex)
|
|
{
|
|
if (string.IsNullOrWhiteSpace(icex.Certificate))
|
|
throw new ServerErrorException(icex.Message);
|
|
else
|
|
throw new ServerErrorException("incorrect-cert:" + icex.Certificate);
|
|
}
|
|
catch (Exception ex) when (GetInnerException<Library.Utility.HostKeyException>(ex) is Library.Utility.HostKeyException hex)
|
|
{
|
|
if (string.IsNullOrWhiteSpace(hex.ReportedHostKey))
|
|
throw new ServerErrorException(hex.Message);
|
|
else
|
|
{
|
|
throw new ServerErrorException($@"incorrect-host-key:""{hex.ReportedHostKey}"", accepted-host-key:""{hex.AcceptedHostKey}""");
|
|
}
|
|
}
|
|
catch (UserInformationException uex)
|
|
{
|
|
throw new ServerErrorException($@"error-id:{uex.HelpID}, user-information:{uex.Message}");
|
|
}
|
|
catch (Exception ex)
|
|
{
|
|
throw new ServerErrorException(ex.Message);
|
|
}
|
|
finally
|
|
{
|
|
wrapper?.Dispose();
|
|
}
|
|
}
|
|
|
|
|
|
private static async Task ExecuteCreate(string uri, CancellationToken cancelToken)
|
|
{
|
|
try
|
|
{
|
|
using (var b = Duplicati.Library.DynamicLoader.BackendLoader.GetBackend(uri, new Dictionary<string, string>()))
|
|
await b.CreateFolderAsync(cancelToken).ConfigureAwait(false);
|
|
}
|
|
catch (UserInformationException uex)
|
|
{
|
|
throw new ServerErrorException($@"error-id:{uex.HelpID}, user-information:{uex.Message}");
|
|
}
|
|
catch (Exception ex)
|
|
{
|
|
throw new ServerErrorException(ex.Message);
|
|
}
|
|
}
|
|
|
|
}
|
|
} |