From 151eae66bebd41c1b217fa94e4c2e44feaa46c8b Mon Sep 17 00:00:00 2001
From: Zuujis <160198409+zuujiscom@users.noreply.github.com>
Date: Fri, 23 Oct 2026 16:39:19 -0500
Subject: [PATCH] fix(app): no unused screen picker code on FreeBSD (#8469)

FreeBSD (and every other OS without a capture backend) compiles the
screen colour picker's stub capture, which never reads monitor placements
or builds images. The build warned about the unused ScreenImage import,
the never-read Placement fields, find_monitor and count. Compile those
only where a capture backend or the tests use them.

Seen in the FreeBSD aarch64 CI build; checked with `cargo check -p
photocraft --all-targets` on FreeBSD 15.1 aarch64 (no warnings) and macOS.
---
 apps/photocraft/src/screen_color.rs | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/apps/photocraft/src/screen_color.rs b/apps/photocraft/src/screen_color.rs
index 8a0d4ca901..ec8cd6378c 100644
--- a/apps/photocraft/src/screen_color.rs
+++ b/apps/photocraft/src/screen_color.rs
@@ -1,6 +1,11 @@
 //! Desktop colour capture starts only on an explicit UI request. No snapshots are written to
 //! disk, transmitted or retained after a pick. Wayland delegates to its permission portal.
-use photocraft_ui_egui::screen_picker::{Capture, MAX_PIXELS, Pending, ScreenImage, Service};
+use photocraft_ui_egui::screen_picker::{Capture, Pending, Service};
+// Only the platform capture backends (and the tests) build images and check sizes.
+#[cfg(any(target_os = "linux", target_os = "macos", target_os = "windows", test))]
+use photocraft_ui_egui::screen_picker::MAX_PIXELS;
+#[cfg(any(target_os = "linux", target_os = "macos", target_os = "windows"))]
+use photocraft_ui_egui::screen_picker::ScreenImage;
 
 pub fn service(cc: &eframe::CreationContext<'_>, wayland: bool) -> Option<Service> {
     if !cfg!(any(target_os = "linux", target_os = "macos", target_os = "windows")) {
@@ -34,6 +39,7 @@ pub fn service(cc: &eframe::CreationContext<'_>, wayland: bool) -> Option<Servic
     }))
 }
 #[derive(Clone, Copy)]
+#[cfg_attr(not(any(target_os = "linux", target_os = "macos", target_os = "windows", test)), allow(dead_code))]
 struct Placement {
     index: usize,
     x: i32,
@@ -41,9 +47,11 @@ struct Placement {
     width: u32,
     height: u32,
 }
+#[cfg(any(target_os = "linux", target_os = "macos", target_os = "windows", test))]
 fn find_monitor(placements: &[Placement], x: i32, y: i32, w: u32, h: u32) -> Option<usize> {
     placements.iter().find(|p| p.x == x && p.y == y && p.width == w && p.height == h).map(|p| p.index)
 }
+#[cfg(any(target_os = "linux", target_os = "macos", target_os = "windows", test))]
 fn count(width: usize, height: usize) -> Result<usize, String> {
     width.checked_mul(height).filter(|&n| n > 0 && n <= MAX_PIXELS).ok_or_else(|| "Screen capture exceeds the 64 MP memory budget".into())
 }